[TQ Binaries] Discussion and documentation

Korvacs · 01/15/2012, 01:44

Quote:

Originally Posted by Kiyono

I noticed that Exodus had it right before you posted, also found master15's CoEmuv2 guide on this and I apparently already had the RedemptionCO source but it never even occurred to me that it might have TQ's npc system, lol Not sure what PMCO is? Link?

It could be me but 2031 doesn't have subtypes?

But since you say so, it's either the unknown or the npc_mode.

//edit For some reason, RedemptionCO's system and Exodus use exactly the same structs (ActionStruct/TaskStruct even the spaces are in the same place) so that either means that Exodus' system is based on this or vice versa but since RedemptionCO's implementation was flawed (what was wrong with it again?) Exodus' version should be flawed too.

The wiki isnt always correct sadly, somethings may be missing.

Essentially the action system should be treated as a series of If statements where by you progress by these statements being true/false through a tree.

That system doesnt do this correctly under a few circumstances which means that its entirely flawed, which results in a number of npcs having to be done manually (ie. not using the actionhandler at all for anything). As a result that means that the action system is being massively under utilised (something like 3% of the total number of actiontypes are handled). So thats basically whats wrong with it.

lostsolder05 · 01/15/2012, 04:24

Quote:

Originally Posted by Kiyono

//edit For some reason, RedemptionCO's system and Exodus use exactly the same structs (ActionStruct/TaskStruct even the spaces are in the same place) so that either means that Exodus' system is based on this or vice versa but since RedemptionCO's implementation was flawed (what was wrong with it again?) Exodus' version should be flawed too.

Part of it was based off ImmuneOnes implementation I had just taken it a lot further then he did.

Quote:

Originally Posted by Korvacs

The wiki isnt always correct sadly, somethings may be missing.

Essentially the action system should be treated as a series of If statements where by you progress by these statements being true/false through a tree.

That system doesnt do this correctly under a few circumstances which means that its entirely flawed, which results in a number of npcs having to be done manually (ie. not using the actionhandler at all for anything). As a result that means that the action system is being massively under utilised (something like 3% of the total number of actiontypes are handled). So thats basically whats wrong with it.

TQs NPC implementation was of the last things I was working on, so yeah it's not nearly near complete(however it is the furthest public implementation I've personally seen). But, that's why I had C# dialogs still in there.

Kiyono · 01/15/2012, 10:40

Quote:

Originally Posted by Korvacs

The wiki isnt always correct sadly, somethings may be missing.

Essentially the action system should be treated as a series of If statements where by you progress by these statements being true/false through a tree.

That system doesnt do this correctly under a few circumstances which means that its entirely flawed, which results in a number of npcs having to be done manually (ie. not using the actionhandler at all for anything). As a result that means that the action system is being massively under utilised (something like 3% of the total number of actiontypes are handled). So thats basically whats wrong with it.

I see, then do you also happen to know under which circumstances these flaws become noticeable? Depending on how much I care about those circumstances I might just implement RedemptionCO's system since I'm not striving for a perfect system.

Korvacs · 01/15/2012, 10:59

Quote:

Originally Posted by Kiyono

I see, then do you also happen to know under which circumstances these flaws become noticeable? Depending on how much I care about those circumstances I might just implement RedemptionCO's system since I'm not striving for a perfect system.

Well, if you look at the system and see how many npcs are handled separately, then you can probably work out that its pretty often.

Kiyono · 01/15/2012, 11:12

Well it's not that many, 11 NPCs + the warehouses, far from what I call many seeing the amount of NPCs there are and it seems that the only reason those are done in the source is because it's missing some handled action types unless I'm missing something of course. If that's all then I can just handle the action types (ok, it probably won't be that simple.) and make it work.

Korvacs · 01/15/2012, 11:26

The system has a flawed way of determining if it should use the NextID for the next action or the FailedID, so as a result some basic stuff works, but the rest of it doesnt, so saying "I can just handle the action types" is definitely not true in this case.

Kiyono · 01/15/2012, 11:40

Haven't looked that far yet. I'm going through the code while implementing it so I'll encounter it at some point and I'll think about it when it happens.
//edit Well I didn't exactly come far, server crashes when the npc option is something that is not 255.
//edit It probably has to do with how I did this:

Spoiler

Code:

public static void Text(GameClient Client, string str_text)
        {
            str_text = str_text.Replace("~", " ") + "\n";
            const int BaseSize = 0x11;
            byte* ptr = stackalloc byte[BaseSize];
            NpcClickPacket* Reply;
            Reply = NpcClickPacket.Create(ptr, str_text.Length);
            Reply->ResponseID = NpcClickID.Dialogue;
            Reply->Input = str_text;
            Client.Send(Reply);
        }
        public static void Avatar(GameClient Client, ushort str_avatar)
        {
            const int BaseSize = 0x11;
            byte* ptr = stackalloc byte[BaseSize];
            NpcClickPacket* Reply;
            Reply = NpcClickPacket.Create(ptr, 0);
            Reply->ResponseID = NpcClickID.Avatar;
            Reply->Avatar = str_avatar;
            Client.Send(Reply);
        }
        public static void Link(GameClient Client, string str_text, byte link)
        {
            str_text = str_text.Replace("~", " ") + "\n";
            const int BaseSize = 0x11;
            byte* ptr = stackalloc byte[BaseSize];
            NpcClickPacket* Reply;
            Reply = NpcClickPacket.Create(ptr, str_text.Length);
            Reply->ResponseID = NpcClickID.Option;
            Reply->OptionID = link;
            Reply->Input = str_text;
            Client.Send(Reply);
        }
        public static void Input(GameClient Client, string str_text, byte link)
        {
            const int BaseSize = 0x11;
            byte* ptr = stackalloc byte[BaseSize];
            NpcClickPacket* Reply;
            Reply = NpcClickPacket.Create(ptr, 0);
            Reply->ResponseID = NpcClickID.Input;
            Reply->MaxInputLength = (ushort)str_text.Length;
            Reply->OptionID = link;
            Client.Send(Reply);
        }
        public static void Finish(GameClient Client)
        {
            const int BaseSize = 0x11;
            byte* ptr = stackalloc byte[BaseSize];
            NpcClickPacket* Reply;
            Reply = NpcClickPacket.Create(ptr, 0);
            Reply->ResponseID = NpcClickID.Finish;
            Reply->DontDisplay = false;
            Client.Send(Reply);
        }

Code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Runtime.InteropServices;

namespace ConquerServer_v2.Packet_Structures
{
    public enum NpcClickID : byte
    {
        None = 0x00,
        Dialogue = 0x01,
        Option = 0x02,
        Input = 0x03,
        Avatar = 0x04,
        Finish = 0x64,
        DeleteGuildMember = 0x66
    }

    [StructLayout(LayoutKind.Explicit)]
    /// <summary>
    /// 0x7EF (Client->Server),
    /// 0x7F0 (Client->Server)
    /// 
    /// </summary>
    public unsafe struct NpcClickPacket
    {
        [FieldOffset(0)]
        public ushort Size;
        [FieldOffset(2)]
        public ushort Type;
        [FieldOffset(4)]
        public uint NpcID;
        [FieldOffset(8)]
        public ushort Avatar;
        [FieldOffset(8)]
        public ushort MaxInputLength;
        [FieldOffset(10)]
        public byte OptionID;
        [FieldOffset(11)]
        public NpcClickID ResponseID;
        [FieldOffset(12)]
        public bool DontDisplay;
        [FieldOffset(13)]
        public byte InputLength;
        [FieldOffset(14)]
        private sbyte szInput;
        public string Input
        {
            get { fixed (sbyte* ptr = &szInput) { return new string(ptr, 0, InputLength); } }
            set { fixed (sbyte* ptr = &szInput) { value.CopyTo(ptr); } }
        }
        /// <summary>
        /// Initializes a memory-block to be a NpcClickPacket, of type 0x7F0
        /// </summary>
        /// <param name="Ptr">The memory-block (make sure this has sufficient size for your string).</param>
        /// <param name="TextLength">The length of your input string.</param>
        /// <returns></returns>
        public static NpcClickPacket* Create(void* Ptr, int TextLength)
        {
            NpcClickPacket* packet = (NpcClickPacket*)Ptr;
            packet->Size = (ushort)(0x11 + TextLength);
            packet->Type = 0x7F0;
            packet->OptionID = 0xFF;
            packet->DontDisplay = true;
            packet->InputLength = (byte)TextLength;
            return packet;
        }
    }
}

Original code in the source:

Code:

public static int Dialog(INpcPlayer Player, string[] Dlg)
        {
            const int BaseSize = 0x11;
            byte* ptr = stackalloc byte[BaseSize];
            int string_size = 0;
            NpcClickPacket* Reply;

            foreach (string parse_dlg in Dlg)
            {
                if (parse_dlg.StartsWith("AVATAR"))
                {
                    string str_avatar = parse_dlg.Substring(7, parse_dlg.Length - 7);
                    Reply = NpcClickPacket.Create(ptr, 0);
                    Reply->ResponseID = NpcClickID.Avatar;
                    Reply->Avatar = ushort.Parse(str_avatar);
                    Player.Send(Reply);
                }
                else if (parse_dlg.StartsWith("TEXT"))
                {
                    string str_text = parse_dlg.Substring(5, parse_dlg.Length - 5);
                    if (string_size < str_text.Length)
                    {
                        string_size = str_text.Length;
                        byte* temp = stackalloc byte[BaseSize + string_size];
                        ptr = temp;
                    }
                    Reply = NpcClickPacket.Create(ptr, str_text.Length);
                    Reply->ResponseID = NpcClickID.Dialogue;
                    Reply->Input = str_text;
                    Player.Send(Reply);
                }
                else if (parse_dlg.StartsWith("OPTION"))
                {
                    string str_op_num = parse_dlg.Substring(6, parse_dlg.IndexOf(' ') - 6);
                    string str_op_text = parse_dlg.Substring(6 + str_op_num.Length + 1, parse_dlg.Length - 6 - str_op_num.Length - 1);
                    if (string_size < str_op_text.Length)
                    {
                        string_size = str_op_text.Length;
                        byte* temp = stackalloc byte[BaseSize + string_size];
                        ptr = temp;
                    }
                    Reply = NpcClickPacket.Create(ptr, str_op_text.Length);
                    Reply->ResponseID = NpcClickID.Option;
                    Reply->OptionID = (byte)short.Parse(str_op_num);
                    Reply->Input = str_op_text;
                    Player.Send(Reply);
                }
                else if (parse_dlg.StartsWith("INPUT"))
                {
                    string str_in_num = parse_dlg.Substring(5, parse_dlg.IndexOf(' ') - 5);
                    string str_txt_len = parse_dlg.Substring(5 + str_in_num.Length + 1, parse_dlg.Length - 5 - str_in_num.Length - 1);
                    Reply = NpcClickPacket.Create(ptr, 0);
                    Reply->ResponseID = NpcClickID.Input;
                    Reply->MaxInputLength = ushort.Parse(str_txt_len);
                    Reply->OptionID = (byte)short.Parse(str_in_num);
                    Player.Send(Reply);
                }
                else if (parse_dlg.StartsWith("NOP"))
                    continue;
                else
                    throw new ArgumentException("Failed to parse npc dialog statement `" + parse_dlg + "`");
            }
            Reply = NpcClickPacket.Create(ptr, 0);
            Reply->ResponseID = NpcClickID.Finish;
            Reply->DontDisplay = false;
            Player.Send(Reply);
            return 0;
        }

I don't know how to use pointers >_>

CptSky · 01/15/2012, 21:16

Quote:

Originally Posted by Kiyono

I don't know how to use pointers >_>

So, don't use them?

Kiyono · 01/15/2012, 21:37

From now on I won't.

Spirited · 01/19/2012, 01:19

Quote:

Originally Posted by CptSky

So, don't use them?

Some people are terrified by pointers.
It still puzzles me (since to be considered as a basic programmer, you need to know pointers inside and out).

~~I don't have a username~~ · 01/19/2012, 08:37

Pointers are nothing hard, once you understand how they work.

Code:

ushort SomeValue = *(ushort*)(pointer + 10);

Meaning:

Code:

VALUE = USHORT VALUE OF (POINTER + OFFSET)

And same the other way around.

Code:

*(ushort*)(pointer + 10) = SomeValue;

Meaning:

Code:

USHORT VALUE OF (POINTER + OFFSET) = VALUE

Whatever.

Code:

int somevalue = 10;//declaring a variable
int* somepointer = &somevalue;//declaring a pointer of somevalue's address
int address = (int)somepointer;//Getting the address of somepointer
int value = *somepointer;//Getting the value of somepointer

Korvacs · 01/19/2012, 10:00

Can anyone help me with this?

I figured i would ask in the EO section since its the EO source im looking at but it was a pointless exercise....

nTL3fTy · 01/19/2012, 16:15

Quote:

Originally Posted by Korvacs

Can anyone help me with this?

I figured i would ask in the EO section since its the EO source im looking at but it was a pointless exercise....

It's labeled that in EO, but it's something different in CO.

Code:

enum ENUM_MAPTYPE {
    MAPTYPE_NORMAL		= 0x0000,    // 00
    MAPTYPE_PKFIELD		= 0x0001,    // 01
    MAPTYPE_CHGMAP_DISABLE	= 0x0002,    // 02                    // magic call team member
    MAPTYPE_RECORD_DISABLE	= 0x0004,    // 04
    MAPTYPE_PK_DISABLE		= 0x0008,    // 08
    MAPTYPE_BOOTH_ENABLE	= 0x0010,    // 16 
    MAPTYPE_TEAM_DISABLE	= 0x0020,    // 32
    MAPTYPE_TELEPORT_DISABLE	= 0x0040,    // 64                    // chgmap by action
    MAPTYPE_SYN_MAP		= 0x0080,    // 128
    MAPTYPE_PRISON_MAP		= 0x0100,    // 256
    MAPTYPE_WING_DISABLE	= 0x0200,    // 512                    // bowman fly disable
    MAPTYPE_FAMILY		= 0x0400,    // 1024
    MAPTYPE_MINEFIELD		= 0x0800,    // 2048
    MAPTYPE_CALLNEWBIE_DISABLE	= 0x1000,    // 4096
    MAPTYPE_REBORN_NOW_ENABLE	= 0x2000,    // 8192
    MAPTYPE_NEWBIE_PROTECT	= 0x4000,    // 16384    
}

That should make a bit more sense.

Korvacs · 01/19/2012, 16:22

Yeah i know what it does and how it works, but i dont know what it does. For example we have one that disables PK which is pretty obvious, this is part of the battle system for eo and doesnt really have any real explanation as to what it actually does, except that i know that it acts sort of like arena in that it determines if you receive a flashing name or not. So i need to know what it does....i thought that was clear in my thread

CptSky · 01/19/2012, 16:48

Quote:

Originally Posted by Korvacs

Yeah i know what it does and how it works, but i dont know what it does. For example we have one that disables PK which is pretty obvious, this is part of the battle system for eo and doesnt really have any real explanation as to what it actually does, except that i know that it acts sort of like arena in that it determines if you receive a flashing name or not. So i need to know what it does....i thought that was clear in my thread

MAPTYPE_NEWBIE_PROTECT (DEAD_ISLAND in EO) is the newbie protection on map. By memory, it was lvl 26- that was protected from being killed by other people.