Calling a buff item instead of skill

[elitemember21]

I tried adding guild buff and it's working fine however i would like to call a scroll instead of skill.

I tried editing the code from BUFF_SKILL TO BUFF_ITEM but it won't work.
What i did was. BUFF_SKILL, SI_BUFF_GUILD01 to BUFF_ITEM, II_SYS_SYS_SCR_NEW

Here's the part of code that i tried editing. Wish to hear from experienced people. Thanks a lot.

#ifdef __GUILD_BUFF
void CDPSrvr::OnBuffGuildByAPP( CAr & ar, DPID dpidCache, DPID dpidUser, LPBYTE, u_long )
{
#ifdef __FIX_ANTI_HACKING
try{
#endif // __FIX_ANTI_HACKING	
    CUser* pUser = g_UserMng.GetUser( dpidCache, dpidUser );
    CMover* pMover = pUser;
    int nCurSel;
    int nGold;
    nGold = 0;
    int valid = 0;
    ar >> nCurSel;
    CCtrl* pCtrl = (CCtrl*)pMover;
    CGuild *pGuild = pUser->GetGuild();
    if( IsValidObj( pUser ) )
    {
        if ( pGuild )
        {
            switch( nCurSel )
            {
                case 0:
                {
                    if ( pGuild->m_nLevel > 19 )
                    {
                        if(    pUser->HasBuff(BUFF_SKILL, SI_BUFF_GUILD01) )
                            valid = 1;
                       
                        if ( valid != 1 )
                        {
                            nGold = 250000000;
                            if ( pUser->GetGold() > nGold )
                            {   
                                pUser->AddGold( -nGold );
                                pCtrl->DoAddBuff( SI_BUFF_GUILD01, 1, pCtrl );
                            }
                            else
                                pUser->AddDefinedText( TID_GUILD_ERROR_NO_PENYA );
                        }
                        else
                            pUser->AddDefinedText( TID_GUILD_DEJA_BUFF );
                    }
                    else
                    {
                        pUser->AddDefinedText( TID_GUILD_LOW_LVL );
                    }
                }
                break;
                case 1:
                {
                    if ( pGuild->m_nLevel > 29 )
                    {
                        if(    pUser->HasBuff(BUFF_SKILL, SI_BUFF_GUILD02) )
                            valid = 1;
                       
                        if ( valid != 1 )
                        {
                            nGold = 250000000;
                            if ( pUser->GetGold() > nGold )
                            {   
                                pUser->AddGold( -nGold );
                                pCtrl->DoAddBuff( SI_BUFF_GUILD02, 1, pCtrl );
                            }
                            else
                                pUser->AddDefinedText( TID_GUILD_ERROR_NO_PENYA );
                        }
                        else
                            pUser->AddDefinedText( TID_GUILD_DEJA_BUFF );
                    }
                    else
                    {
                        pUser->AddDefinedText( TID_GUILD_LOW_LVL );
                    }
                }
                break;
                case 2:

Anyone?

[cookie69]

CUser* pUser = g_UserMng.GetUser( dpidCache, dpidUser );
CMover* pMover = pUser;
int nCurSel;
int nGold;
nGold = 0;
int valid = 0;
ar >> nCurSel;
CCtrl* pCtrl = (CCtrl*)pMover;
CGuild *pGuild = pUser->GetGuild();

Are you serious?

[ZeroTwo02]

Originally Posted by cookie69

Are you serious?

Same for

CCtrl* pCtrl = (CCtrl*)pMover;

need to check the pMover... or check the pUser before

CMover* pMover = pUser;

[cookie69]

Originally Posted by naruto66620

Same for

CCtrl* pCtrl = (CCtrl*)pMover;

need to check the pMover... or check the pUser before

CMover* pMover = pUser;

Nop, this will never trigger the exception. You can cast any pointer to NULL as long as you do not use the pointer reference.

So:

CMover* pMover = pUser;
and
CCtrl* pCtrl = (CCtrl*)pMover;

Will never trigger any exception as you do not do for example

pMover -> DoSomething()

By the way, if you want to close the game client when a bot/cheat is detected, it is not recommended at all to call ExitProcess() or any exit API. It is better to just crash it like this:

int * ptr = 0;
*p = 5;

[elitemember21]

Thank you all for answering my question. I didn't create that code i just leeched it from somewhere.

Would you mind telling me more about how because i'm kinda clueless about it.
I thought i just needed to replace BUFF_SKILL to BUFF_ITEM but i was really wrong.
I tried editing some stuff too and unfortunately didn't change a thing.

[Mike Oxmaul]

DoApplySkill(obj, ItemProp, nullptr, false, 0 ,0 0);

[elitemember21]

Originally Posted by Jupsi332

DoApplySkill(obj, ItemProp, nullptr, false, 0 ,0 0);

Though i don't really understand much on how to completely make it work.
I'm still trying my best to make it work.
If there's someone who's willing to share some codes please do. Thanks a lot.

[yasukomoonflyff]

if(pUser->GetGuild() != NULL )
{
if( pUser->GetGuild()->m_nLevel >= 30)
{
if( !pUser->HasBuff( BUFF_ITEM, II_SYS_SYS_GUILDBUFF_LV30 ) )
{
ItemProp* pProp = prj.GetItemProp( II_SYS_SYS_GUILDBUFF_LV30 );
if( pProp )
{
pUser->DoApplySkill( pUser, pProp, NULL );
}
}
}
}

go edit