Truly, how well are the binaries coded?

Lateralus · 01/17/2011, 06:24

I've done a bit of poking around at it with olly, and it seems to me that it's pretty inefficient. First thing I noticed was that it was reading monster drops from a file for EACH monster instead of just simply doing a few calculations...

Your thoughts and opinions?

zhalyn · 01/17/2011, 06:43

Wot do you mean Binary?

shitboi · 01/17/2011, 07:52

I am guessing he meant the client source code

~~Syst3m_W1z4rd~~ · 01/17/2011, 11:40

You mean the actual C++ code?

Is the monster **** included in the NPCServer, then I guess you could look the exactly code, because the real sourcecode for that have been leeched.

legomans · 01/17/2011, 11:41

.exe = binary
usually.

nTL3fTy · 01/17/2011, 15:37

Quote:

Originally Posted by Lateralus

I've done a bit of poking around at it with olly, and it seems to me that it's pretty inefficient. First thing I noticed was that it was reading monster drops from a file for EACH monster instead of just simply doing a few calculations...

Your thoughts and opinions?

I don't think you were looking at the real calculation for monster drops. If you look in the database, there are a few columns in cq_monstertype that specify the level range and types of generated drops.

id	name	level	drop_armet	drop_necklace	drop_armor	drop_ring	drop_weapon	drop_shield	drop_shoes	drop_hp	drop_mp
1	Pheasant	1	99	99	99	99	99	99	99	1000000	1001000
2	Turtledove	7	99	0	99	0	0	99	1	1000000	1001000
57	BullMonster	112	9	22	9	22	22	9	23	1002020	1002040

Lateralus · 01/17/2011, 18:30

Quote:

Originally Posted by nTL3fTy

I don't think you were looking at the real calculation for monster drops. If you look in the database, there are a few columns in cq_monstertype that specify the level range and types of generated drops.

id name level drop_armet drop_necklace drop_armor drop_ring drop_weapon drop_shield drop_shoes drop_hp drop_mp
1 Pheasant 1 99 99 99 99 99 99 99 1000000 1001000
2 Turtledove 7 99 0 99 0 0 99 1 1000000 1001000
57 BullMonster 112 9 22 9 22 22 9 23 1002020 1002040

Sorry, I meant for medicine and money drops.

gabrola · 01/19/2011, 00:18

Let me rephrase your title. "Truly how bad are binaries coded?"
My answer, TQ coded it

~~pro4never~~ · 01/19/2011, 02:35

Being a 'professional' company, obviously it would be better coded then most of what pservers will ever see. That being said, it's TQ we're talking about... they are not exactly that professional of a company and their products always seem to have some fairly large flaws.

So yahh... far from surprised if they have some nasty holes in their bins. I mean look at how much resources they tend to hog any server hosting the leaked ones and how much the official servers lag! A bit of optimization server side and they could probably fix almost all of that.

shitboi · 01/19/2011, 05:21

i remembered talking to a friendly GM ages back on eagle server, she mentioned that ALL TQ servers are wrote and maintained by 1 guy, that includes crazytao, conquer, eudemons and etc ... Back then my impression was, Wow, what a guy. Now, my impression is, how cheap the company is.

Huseby · 01/19/2011, 07:26

Quote:

Originally Posted by shitboi

i remembered talking to a friendly GM ages back on eagle server, she mentioned that ALL TQ servers are wrote and maintained by 1 guy, that includes crazytao, conquer, eudemons and etc ... Back then my impression was, Wow, what a guy. Now, my impression is, how cheap the company is.

lol, no.
TQ digital is a respected online gaming company in China.

gabrola · 01/19/2011, 11:34

Quote:

Originally Posted by Huseby

lol, no.
TQ digital is a respected online gaming company in China.

They're still cheap bastards and we know how bad their programmer(s) are.

~~Syst3m_W1z4rd~~ · 01/19/2011, 12:50

Quote:

Originally Posted by gabrola

They're still cheap bastards and we know how bad their programmer(s) are.

But they still beats us.

shitboi · 01/19/2011, 13:44

the company is definitely cheap, but nothing can be said about their programmer since he might be heavily overloaded.
Well whoever programmed conquer is definitely way better than me, lol.

© Haydz · 01/19/2011, 14:02

Quote:

Originally Posted by shitboi

the company is definitely cheap, but nothing can be said about their programmer since he might be heavily overloaded.
Well whoever programmed conquer is definitely way better than me, lol.

There's definitely more than one programmer at TQ.

If you read through the EO source, there's various signatures placed by them all over it, to signify its their work etc.

For Example:

Code:

	//---jinggy---begin
	//Íæ¼ÒÌØÊâ×´Ì¬µ÷½Ú dodge Öµ
	IStatus * pStatus = QueryStatus(STATUS_ADJUST_DODGE);
	if (pStatus)
	{
		nDge = ::CutTrail(0, AdjustData(nDge, pStatus->GetPower()));			
	}		
	//---jinggy---end

Code:

// self_defence     // add huang 2004.1.14

Code:

// pk increase    // tudo 2004.1.11   // Ã»¸Ä

Code:

// °´ÕÕ 2004.10.28µÄ°¸×ÓÐÞ¸Ä	---- zlong

There's quite a lot more scattered around, that's just half of the User.cpp