Conquer Resource Wiki

[CptSky]

Originally Posted by Nullable

sizeof doesn't work that way.. you should read something about it or better try doing it yourself, and remember that the packet i'm reading is actually a pointer to the actual packet allocated on heap, in simple words sizeof doesn't work like this with pointers

When I will return to the C/C++, I will check for this operator Anyway, thanks, it's good to know that.

[Korvacs]

Small Update:

Im going to be adding 5165 packets this weekend, and probably restructing the packet layouts to have a more definative way of doing things. If anyone has any suggestions as to how they would like to see the packets layed out please post here, ill happily take a look at what you have to say, it was after all made for the community (ie. you guys).

[KraHen]

Originally Posted by Korvacs

Small Update:

Im going to be adding 5165 packets this weekend, and probably restructing the packet layouts to have a more definative way of doing things. If anyone has any suggestions as to how they would like to see the packets layed out please post here, ill happily take a look at what you have to say, it was after all made for the community (ie. you guys).

I`d personally like to see the offset numbers :P

[Korvacs]

Offsets are something that i considered originally, but i rejected it because i beleived that the community would struggle to understand the concept, ill have anouther think about them and see if i can make it simpler.

[KraHen]

Originally Posted by Korvacs

Offsets are something that i considered originally, but i rejected it because i beleived that the community would struggle to understand the concept, ill have anouther think about them and see if i can make it simpler.

You could include an article about them as well and this would solve the problem

[Korvacs]

Originally Posted by ElDeRnEcRo

You could include an article about them as well and this would solve the problem

Yeah thats a good idea.

I have started replacing the packet structures with a new layout using a table, which includes the offset, im also going to write a page about bytes/ushorts/uints/ulongs, and the offsets to help people to understand things alittle more, im also going to re-write all of the values to help make them more standard accross the wiki and easier to understand.

[Nullable]

Originally Posted by Korvacs

Yeah thats a good idea.

I have started replacing the packet structures with a new layout using a table, which includes the offset, im also going to write a page about bytes/ushorts/uints/ulongs, and the offsets to help people to understand things alittle more, im also going to re-write all of the values to help make them more standard accross the wiki and easier to understand.

Love the new layout of the packets, it's amazing anyhow there is an error in this: exactly at the exp variable in the 4267 version, here is the correct one:

PHP Code:

            (ushort)Length;
            (ushort)1006;
            (uint)(Character.UID);
            (uint)(Character.Model);
            (ushort)(Character.Hair);
            (ushort)(0);
            (uint)(Money);
            (ulong)(Experience); // Exactly here :P
            (uint)(0);
            (uint)(0);
            (uint)(0);
            (ushort)(Strength);
            (ushort)(Agility);
            (ushort)(Vitality);
            (ushort)(Spirit);
            (ushort)(AttributePoints);
            (ushort)(Hitpoints);
            (ushort)(Mana);
            (ushort)(PkPoints);
            (byte)(Character.Level);
            (byte)(Character.Job);
            (byte)(0);
            (byte)(Character.RebornCount);
            (byte)1;
            (byte)(2);
            (string with length)Character.Name
            (string with length)Character.Spouse 


[Korvacs]

Experience in the 4267 client never gets high enough to require a ulong, so strictly speaking its a uint for that packet

[Nullable]

Originally Posted by Korvacs

Experience in the 4267 client never gets high enough to require a ulong, so strictly speaking its a uint for that packet

Packet never worked with me using a uint, it worked with a ulong though

[Korvacs]

Originally Posted by Nullable

Packet never worked with me using a uint, it worked with a ulong though

It doesnt atually make the slightest bit of difference, but you can do this if you like:

PHP Code:

 (ushort)Length;
            (ushort)1006;
            (uint)(Character.UID);
            (uint)(Character.Model);
            (ushort)(Character.Hair);
            (ushort)(0);
            (uint)(Money);
            (uint)(Experience); // Change this
            (uint)(0); //Add this
            (uint)(0);
            (uint)(0);
            (uint)(0);
            (ushort)(Strength);
            (ushort)(Agility);
            (ushort)(Vitality);
            (ushort)(Spirit);
            (ushort)(AttributePoints);
            (ushort)(Hitpoints);
            (ushort)(Mana);
            (ushort)(PkPoints);
            (byte)(Character.Level);
            (byte)(Character.Job);
            (byte)(0);
            (byte)(Character.RebornCount);
            (byte)1;
            (byte)(2);
            (string with length)Character.Name
            (string with length)Character.Spouse 


[Nullable]

Originally Posted by Korvacs

It doesnt atually make the slightest bit of difference, but you can do this if you like:

PHP Code:

 (ushort)Length;
            (ushort)1006;
            (uint)(Character.UID);
            (uint)(Character.Model);
            (ushort)(Character.Hair);
            (ushort)(0);
            (uint)(Money);
            (uint)(Experience); // Change this
            (uint)(0); //Add this
            (uint)(0);
            (uint)(0);
            (uint)(0);
            (ushort)(Strength);
            (ushort)(Agility);
            (ushort)(Vitality);
            (ushort)(Spirit);
            (ushort)(AttributePoints);
            (ushort)(Hitpoints);
            (ushort)(Mana);
            (ushort)(PkPoints);
            (byte)(Character.Level);
            (byte)(Character.Job);
            (byte)(0);
            (byte)(Character.RebornCount);
            (byte)1;
            (byte)(2);
            (string with length)Character.Name
            (string with length)Character.Spouse 


I know what you mean, 4 + 4 = 8 obviously, but wouldn't it be easier to build it up as a ulong instead of adding another blank uint, that's just my opinion.. anyhow it's fine as long as the packet posted on the wiki is fine

[Korvacs]

Ah well, i use a pointer for my packets so for me its:

PHP Code:

                *(ushort*)PTR = (ushort)Buffer.Length;
                *((ushort*)(PTR + 2)) = 1006;
                *((uint*)(PTR + 4)) = Char.characterID;
                *((uint*)(PTR + 8)) = (uint)(Char.avatar * 10000) + Char.modelID;
                *((ushort*)(PTR + 12)) = Char.hairStyle;
                *((uint*)(PTR + 16)) = Char.InventoryGold;
                *((uint*)(PTR + 20)) = Char.experience;
                *((ushort*)(PTR + 40)) = Char.strengthPoints;
                *((ushort*)(PTR + 42)) = Char.agilityPoints;
                *((ushort*)(PTR + 44)) = Char.vitalityPoints;
                *((ushort*)(PTR + 46)) = Char.spiritPoints;
                *((ushort*)(PTR + 48)) = Char.statPoints;
                *((ushort*)(PTR + 50)) = Char.health;
                *((ushort*)(PTR + 52)) = Char.mana;
                *((ushort*)(PTR + 54)) = Char.pkPoints;
                *((byte*)(PTR + 56)) = Char.level;
                *((byte*)(PTR + 57)) = Char.profession;
                *((byte*)(PTR + 59)) = Char.reborn;
                *((byte*)(PTR + 60)) = 1;
                *((byte*)(PTR + 61)) = 2; 


[Nullable]

Originally Posted by Korvacs

Ah well, i use a pointer for my packets so for me its:

PHP Code:

                *(ushort*)PTR = (ushort)Buffer.Length;
                *((ushort*)(PTR + 2)) = 1006;
                *((uint*)(PTR + 4)) = Char.characterID;
                *((uint*)(PTR + 8)) = (uint)(Char.avatar * 10000) + Char.modelID;
                *((ushort*)(PTR + 12)) = Char.hairStyle;
                *((uint*)(PTR + 16)) = Char.InventoryGold;
                *((uint*)(PTR + 20)) = Char.experience;
                *((ushort*)(PTR + 40)) = Char.strengthPoints;
                *((ushort*)(PTR + 42)) = Char.agilityPoints;
                *((ushort*)(PTR + 44)) = Char.vitalityPoints;
                *((ushort*)(PTR + 46)) = Char.spiritPoints;
                *((ushort*)(PTR + 48)) = Char.statPoints;
                *((ushort*)(PTR + 50)) = Char.health;
                *((ushort*)(PTR + 52)) = Char.mana;
                *((ushort*)(PTR + 54)) = Char.pkPoints;
                *((byte*)(PTR + 56)) = Char.level;
                *((byte*)(PTR + 57)) = Char.profession;
                *((byte*)(PTR + 59)) = Char.reborn;
                *((byte*)(PTR + 60)) = 1;
                *((byte*)(PTR + 61)) = 2; 


esshh too many de-reference operators, i wrap them up in a class

PHP Code:

public static int WriteUInt64(byte[] Packet, int Offset, ulong Arg)
        {
            fixed (byte* pckt = Packet)
            {
                *(pckt + Offset) = (byte)(Arg);
                *(pckt + Offset + 1) = (byte)(Arg >> 8);
                *(pckt + Offset + 2) = (byte)(Arg >> 16);
                *(pckt + Offset + 3) = (byte)(Arg >> 24);
                *(pckt + Offset + 4) = (byte)(Arg >> 32);
                *(pckt + Offset + 5) = (byte)(Arg >> 40);
                *(pckt + Offset + 6) = (byte)(Arg >> 48);
                *(pckt + Offset + 7) = (byte)(Arg >> 56);

                return (Offset + 8);
            }
        } 


[Korvacs]

Nice, im going to do that at some point i think.

If anyone else sees anything that looks wrong, or they have anything to add please post here, i have done one or two 5165 packets, but as you can see im only just half way through converting the existing packets.

[ImFlamedCOD]

When i get a chance Korvacs when i get home ill check my wiki for packets that you don't have. But if i'm not mistaken you got all the ones i have.