Progress bar not working.

[LordGragen.]

i was looking at angelius guide and found this about progress bar





so friend of my helped me build one, but it didnt work so here is how we did and i hope to get answer for

for the npc part we did this for testing

  case 8:
                                            {
                                                Data gData = new Data("Pick");
                                                gData.UID = client.Entity.UID;
                                                gData.dwParam = 220;
                                                gData.ID = 164;
                                                gData.Facing = Enums.ConquerAngle.East;
                                                gData.EffectTimeout = 2;
                                                break;
                                            }

and for the data.cs part we did this

 public Data(string effectName)
        {
            Buffer = new byte[45 + effectName.Length];
            WriteUInt16((ushort)Buffer.Length, 0, Buffer);
            WriteUInt16(10010, 2, Buffer);
            StringCount = 1;
            EffectName = effectName;
        }


public Game.Enums.ConquerAngle Facing
        {
            get
            {
                return (Game.Enums.ConquerAngle)Buffer[22];
            }
            set
            {
                WriteUInt32((uint)value, 22, Buffer);
            }
        }

 public uint EffectTimeout
        {
            set
            {
                WriteUInt32(value, 32, Buffer);
            }
        }

        public byte StringCount
        {
            set
            {
                WriteByte(value, 37, Buffer);
            }
        }

        public byte EffectNameLength
        {
            set
            {
                WriteByte(value, 38, Buffer);
            }
        }

        public string EffectName
        {
            set
            {
                WriteString(value, 39, Buffer);
                EffectNameLength = (byte)value.Length;
            }
        }

to be honest i think the code looks fine, but since its not working then of corse its not.

[littlechris95]

Try putting:

client.Send(gData);

After:

gData.EffectTimeout = 2;

[LordGragen.]

Originally Posted by littlechris95

Try putting:

After:

i just did and now when i use the case 8 it dc me, not the source just loging me off from the server

[Super Aids]

"gData.Facing = Enums.ConquerAngle.East;"
Why do you make it face east? Why not use the direction of your player?
However are you appending "TQServer" to the packet?

Please post a packet dump.

[LordGragen.]

you talking about the packet 10010?

[_DreadNought_]

Using the packet writer he is, TQServer will indeed be added to the end of the packet.

The packet is incorrect.

The code snippet someone gave you was right, You initialized a packet instance and the variables, but you never actually done anything with it.

so yes, client.send(gData.toArray()); was right.

If you get DC'd - That most likely means the packet is invalid and you need to double check it using a packet sniffer and not relying on packet structures posted by other people (Hard lesson well learned, ty ulti)

[LordGragen.]

okay thx will see what i can come up ith

[teroareboss1]

public Data(string effectName)
{

Buffer = new byte[46 + effectName.Length];
WriteUInt16((ushort)(Buffer.Length - 8), 0, Buffer);

WriteUInt16(10010, 2, Buffer);
StringCount = 1;
EffectName = effectName;
}

[LordGragen.]

Originally Posted by teroareboss1

public Data(string effectName)
{

Buffer = new byte[46 + effectName.Length];
WriteUInt16((ushort)(Buffer.Length - 8), 0, Buffer);

WriteUInt16(10010, 2, Buffer);
StringCount = 1;
EffectName = effectName;
}

thank you, i also fixed that. and added

client.Send(gData.ToArray()); on npc part

now it dont dc anymore but still not showing.

[urgabel]

Originally Posted by teroareboss1

Buffer = new byte[46 + effectName.Length];

Could you explain why 46, please?

I think it should be 45, as Angelius posted; if last data before "TQServer" string is EffectName, the total length of the packet would be 39 + effectName.Length + "TQServer".Length - 2 = 45 + efectName.Length
If the packet length (first 2 bytes) also must be included in PacketLength( at offest 2), then replace 45 by 47. Anyway, I cannot see how it could be 46.

Also I wonder why it is not needed to write a timestamp in offset 16...

[teroareboss1]

Originally Posted by urgabel

Could you explain why 46, please?

I think it should be 45, as Angelius posted; if last data before "TQServer" string is EffectName, the total length of the packet would be 39 + effectName.Length + "TQServer".Length - 2 = 45 + efectName.Length
If the packet length (first 2 bytes) also must be included in PacketLength( at offest 2), then replace 45 by 47. Anyway, I cannot see how it could be 46.

Also I wonder why it is not needed to write a timestamp in offset 16...

yeah,you right is 47. I have not read all of the packet, only the first part.
and I knew that the size is "46" at packet 10010

[LordGragen.]

 public Data(string effectName)
        {
            Buffer = new byte[47 + effectName.Length];
            WriteUInt16((ushort)(Buffer.Length - 8), 0, Buffer);
            WriteUInt16(10010, 2, Buffer);
            StringCount = 1;
            EffectName = effectName;
        }

here we go.

[teroareboss1]

the problem is here : gData.Facing = Enums.ConquerAngle.East;

east = 5;

use:

        public enum BarProgress
        {
                InProgress = 1,
                FullProgress = 2
        }
        public BarProgress ProcesBar { get { return (BarProgress)ReadByte(22); } set { WriteByte((byte)value, 22); } }

[{ Angelius }]

Originally Posted by LordGragen.

  case 8:
                                            {
                                                Data gData = new Data("Pick");
                                                gData.UID = client.Entity.UID;
                                                gData.dwParam = 220;
                                                gData.ID = 164;
                                                gData.Facing = Enums.ConquerAngle.East;
                                                gData.EffectTimeout = 2;
                                                break;
                                            }

 public Data(string effectName)
        {
            Buffer = new byte[45 + effectName.Length];
            WriteUInt16((ushort)Buffer.Length, 0, Buffer);
            WriteUInt16(10010, 2, Buffer);
            StringCount = 1;
            EffectName = effectName;
        }

A- You don't have to use the get/set property because you will never have to read any data from that packet.

B- I don't think that a Timeout of 2 seconds will work try 4+

C- I see you are setting ->

gData.UID = client.Entity.UID;
gData.dwParam = 220;
gData.ID = 164;

But you are not really writing those values to the buffer.

So a simple byte array wold do the job perfectly without complicating things, Something like...

PHP Code:

void Sen_Effect(IClient Client, uint data_8, ushort Type, ushort direction,  uint LoopTime, string EffectName)
    {
        //38 + 1 + 8 + EffectName.Length = 47 + EffectName.Length
        //Where 38 is the normal 10010 packet length, 1 for the extra byte at offset 38, 8 for the Server Stamp
        byte[] Packet = new byte[47 + EffectName.Length];
        WriteUInt16(Packet.Length - 8, 0, Packet);
        WriteUInt16(10010, 2, Packet);
        WriteUInt32(Client.UID, 4, Packet);
        WriteUInt32(data_8, 8, Packet);
        WriteUInt16(Type, 20, Packet);
        WriteUInt16(direction, 22, Packet);
        WriteUInt32(LoopTime, 32, Packet);
        WriteByte(1, 37, Packet);
        WriteByte(EffectName.Length, 38, Packet);
        WriteString(EffectName, 39, Packet);
        Client.send(Packet); 
    } 


To call it -> Sen_Effect(Client, 220, 164, 1, 5, "Pick");

Good luck.

[LordGragen.]

thank you all very very much for all the help.

very grateful.

now i can start my garden system.