[Non-Mini Release] Rewriting Client Notification Handler

[NorseGodTyr]

Originally Posted by #HB

Hmmm works fine for me.

Your problem is here anyways:

if (chat = g_notificationhandler.GetKillNotify(uqdata->ObjNameStrID))
{
	swprintf_s(buffer, sizeof(buffer), g_textmanager->GetStringTextByCode(chat)->c_str(), KillerName.c_str());
	g_interface->ShowBlueNotify(buffer);
	sysmsg->Write(UNIQUE_KILL_SYSTEM_COLOR, buffer);
}

You have to be exceeding the buffer size or messing up arguments, ex:

ok found the problem changed to swprintf

Originally Posted by Goosxc

My game stuck after i load monster the unique

also after i killed the unique i got the same error @norsegodtyr

change by

if (chat = g_notificationhandler.GetKillNotify(uqdata->ObjNameStrID))
{
swprintf_s(buffer, sizeof(buffer), g_textmanager->GetStringTextByCode(chat)->c_str(), KillerName.c_str());
g_interface->ShowBlueNotify(buffer);
sysmsg->Write(UNIQUE_KILL_SYSTEM_COLOR, buffer);
}

swprintf_s to swprintf

[irockalone]

any help?

[#HB]

Originally Posted by NorseGodTyr

swprintf_s to swprintf

Which means your buffer is messed up or it exceeds limit, so its no good to modify it to swprintf.

swprintf_s is limited by the dest buffer size that you specify so if you exceed it, you should be getting that error.

While swprintf just fills the dest buffer with the same size of the source, so it doesn't really care if it exceeds the dest buffer size, AKA if source size is greater than dest size, you'll modify bytes that don't really belong to your dest buffer, which is not safe AT ALL.

That's probably why swprintf is not considered safe.

So, you can try increasing the buffer size.

Originally Posted by irockalone

any help?

You seem to miss includes somehow or VC packages.

Originally Posted by *Deadly

Is it possible to use some other color like the Pink, Green and Blue notifications on the middle of the screen?

Should be possible, but its not related to this topic. Have a look at resinfo files as well, the color could be there as well.

Originally Posted by *Deadly

when I tried to change the hex color of ShowBlueNotify or Pink to something else and build, it started crashing my client the unique appears.

You must've modified something else that isn't really related to it.

[NorseGodTyr]

Originally Posted by #HB

Which means your buffer is messed up or it exceeds limit, so its no good to modify it to swprintf.

swprintf_s is limited by the dest buffer size that you specify so if you exceed it, you should be getting that error.

While swprintf just fills the dest buffer with the same size of the source, so it doesn't really care if it exceeds the dest buffer size, AKA if source size is greater than dest size, you'll modify bytes that don't really belong to your dest buffer, which is not safe AT ALL.

That's probably why swprintf is not considered safe.

So, you can try increasing the buffer size.

i have try to increase but not work so i changed to swprintf and work fine without any crash/error

[*Deadly]

Originally Posted by #HB

You must've modified something else that isn't really related to it.

i modified those hex colors

void CGInterface::ShowBlueNotify(std::wstring msg)
{
	reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B580)(this, &msg);
}

void CGInterface::ShowBlueNotify(std::wstring* msg)
{
	reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B580)(this, msg);
}

[irockalone]

Originally Posted by #HB

Which means your buffer is messed up or it exceeds limit, so its no good to modify it to swprintf.

swprintf_s is limited by the dest buffer size that you specify so if you exceed it, you should be getting that error.

While swprintf just fills the dest buffer with the same size of the source, so it doesn't really care if it exceeds the dest buffer size, AKA if source size is greater than dest size, you'll modify bytes that don't really belong to your dest buffer, which is not safe AT ALL.

That's probably why swprintf is not considered safe.

So, you can try increasing the buffer size.



You seem to miss includes somehow or VC packages.



Should be possible, but its not related to this topic. Have a look at resinfo files as well, the color could be there as well.



You must've modified something else that isn't really related to it.

what VC should i use? and can you share link for download?

[#HB]

Originally Posted by *Deadly

i modified those hex colors

void CGInterface::ShowBlueNotify(std::wstring msg)
{
	reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B580)(this, &msg);
}

Uhm... These are not colors, these are addresses. Anyways this is out of topic, so please keep this outta here.

Originally Posted by irockalone

what VC should i use? and can you share link for download?

Originally Posted by #HB

NOTE: Structures found in the files are for VC80 libs, back when strings were 28 bytes. You'll face errors, if you work with any later compiler.

[irockalone]

Originally Posted by #HB

Uhm... These are not colors, these are addresses. Anyways this is out of topic, so please keep this outta here.

its been 2 hour while i m looking for VC80 SP but there's nothing exists like MS stopped supporting this lol
i would be thankful if you shared a link for this.

[#HB]

Originally Posted by irockalone

its been 2 hour while i m looking for VC80 SP but there's nothing exists like MS stopped supporting this lol
i would be thankful if you shared a link for this.

VC80 is pretty old yeah, but sadly we have to stick with it, you have 2 options:

• Download Visual Studio 2005
• 

No matter what option you choose, you still need to keep up with Joymax allocator, so flo's reconstructed JoymaxAllocator in would be great to ensure the safety of your std lib.

[irockalone]

Originally Posted by #HB

VC80 is pretty old yeah, but sadly we have to stick with it, you have 2 options:

• Download Visual Studio 2005
• 

No matter what option you choose, you still need to keep up with Joymax allocator, so flo's reconstructed JoymaxAllocator in would be great to ensure the safety of your std lib.

after including all neccessary directories

[*Deadly]

Originally Posted by #HB

Uhm... These are not colors, these are addresses. Anyways this is out of topic, so please keep this outta here.

Ah, thanks I don't actually know c++

[nevet.S]

Can it work for taiwan v1.258 files?

[#HB]

Originally Posted by nevet.S

Can it work for taiwan v1.258 files?

It can, you'll need to adapt with addresses difference, and you'll probably need to add new types and also maybe modify an old type, since there's a big version difference between the files.