Stat Scroll Dosent work help!

[DevilArrow]

Hi Guys ! i have a problem i add the Stat Scroll, in DB+media
the problem is when i use i dosent get the Statpoints my Hp and mp are the same, who can help me ?
here is my
_addtimedJOB

 Spoiler

USE [SRO_VT_SHARD]
GO
/****** Object: StoredProcedure [dbo].[_AddTimedJob] Script Date: 02/25/2017 08:34:15 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO




ALTER procedure [dbo].[_AddTimedJob]
@CharID int,
@Category tinyint,
@JobID int,
@Keep int,
@Data1 int,
@Data2 int,
--##begin due to develop composite item
@Data3 int,
@Data4 int,
@Data5 int,
@Data6 int,
@Data7 int,
@Data8 int,
@64 bigint,
@JID int
--##end due to develop composite item
as
if(@JobID = '33788')
begin
declare @ int
declare @Intellect int
declare @MaxLevel int
declare @tatPoint int
select @MaxLevel = MaxLevel from _Char where CharID = @CharID
set @tatPoint = (@MaxLevel*3)-3
set @MaxLevel = @MaxLevel+19
UPDATE _Char SET Strength=@MaxLevel, Intellect=@MaxLevel, RemainStatPoint @tatPoint WHERE CharID=@CharID
return -3
end
if (not exists (select CharID from _Char with (nolock) where CharID = @CharID))
return -1
if @Keep <= 0)
return -2
declare @JobID int
set @JobID = 0
--##begin due to develop composite item
insert into _TimedJob(CharID,Category,JobID,TimeToKeep,Data1,D ata2,Data3,Data4,Data5,Data6,Data7,Data8,Serial64, JID)
values(@CharID, @Category, @JobID, @Keep, @Data1, @Data2, @Data3, @Data4, @Data5, @Data6, @Data7, @Data8, @64, @JID)
--##end due to develop composite item
set @JobID = @@identity
if (@@error <> 0 or @@rowcount = 0)
return -3
return @JobID

[blapanda]

Why did you add them to your _AddTimedJob proc? That one is totally wrong for this kind of processing.
Usually, you are using up a scroll, which has to be registered via "_AddLogItem" on a starting parameter:

IF (@Operation = 41) -- item usage
	BEGIN
		IF (@ItemRefID = 47374) -- item ID
... -- code goes on

You can then either directly execute your "reset stats" lines within that query line, or make it more clean and exec a different procedure located inside your shard database (which is more likely for the case of sorting stuff as they used to be).

Sum:
Scroll Usage ingame > hooks up with "_AddLogItem (LOG database)" and NOT with "_AddTimedJob (SHARD database)" > executes query if conditions are met (operation type (behavior: scroll usage) and item ID) and executes the custom reset query right away or in another procedure.

[DevilArrow]

Originally Posted by blapanda

Why did you add them to your _AddTimedJob proc? That one is totally wrong for this kind of processing.
Usually, you are using up a scroll, which has to be registered via "_AddLogItem" on a starting parameter:

IF  [MENTION=1059401]operation[/MENTION] = 41) -- item usage
	BEGIN
		IF (@ItemRefID = 47374) -- item ID
... -- code goes on

You can then either directly execute your "reset stats" lines within that query line, or make it more clean and exec a different procedure located inside your shard database (which is more likely for the case of sorting stuff as they used to be).

Sum:
Scroll Usage ingame > hooks up with "_AddLogItem (LOG database)" and NOT with "_AddTimedJob (SHARD database)" > executes query if conditions are met (operation type (behavior: scroll usage) and item ID) and executes the custom reset query right away or in another procedure.

ok
i change it to additemlog

 Spoiler

/* --- Stat Reset Scroll */
if(@ItemRefID = 'Stat scroll Item ID Here' )
BEGIN
IF ( @ = '41')

BEGIN
declare @ int
declare @ int
declare @ int
declare @tatPoint int
select @ = MaxLevel from SRO_VT_SHARD.DBO._Char where CharID = @CharID
set @tatPoint = @*3)-3
set @ = @+19
UPDATE SRO_VT_SHARD.DBO._Char SET Strength @, Intellect @, RemainStatPoint @tatPoint WHERE CharID @CharID
return -3
END
END

but i have this error

[Bokyyy]

but i have this error

You are missing bracket and comma at those red error lines.

[DevilArrow]

i fix it ! thx all!

[leo2111]

Originally Posted by blapanda

Why did you add them to your _AddTimedJob proc? That one is totally wrong for this kind of processing.
Usually, you are using up a scroll, which has to be registered via "_AddLogItem" on a starting parameter:

IF (@Operation = 41) -- item usage
	BEGIN
		IF (@ItemRefID = 47374) -- item ID
... -- code goes on

You can then either directly execute your "reset stats" lines within that query line, or make it more clean and exec a different procedure located inside your shard database (which is more likely for the case of sorting stuff as they used to be).

Sum:
Scroll Usage ingame > hooks up with "c (LOG database)" and NOT with "_AddTimedJob (SHARD database)" > executes query if conditions are met (operation type (behavior: scroll usage) and item ID) and executes the custom reset query right away or in another procedure.

because _AddLogItem is exploitable, _AddTimedJob is safe

 Spoiler

[White Ros3]

USE This

PHP Code:

 IF (@Operation = 41) -- remove stats 
    BEGIN
    IF (@ItemRefID = 93002) --- RefObjCommon ID-----
    BEGIN
      declare  [MENTION=314361]strength[/MENTION] int
            declare  [MENTION=5100626]Intellect[/MENTION] int
            declare  [MENTION=1017443]maxlevel[/MENTION] int
            declare  [MENTION=3093238]remains[/MENTION]tatPoint int
            select  [MENTION=1017443]maxlevel[/MENTION] = MaxLevel from SRO_VT_SHARD.DBO._Char where CharID =  [MENTION=395373]Chari[/MENTION]D
            set  [MENTION=3093238]remains[/MENTION]tatPoint =   [MENTION=1017443]maxlevel[/MENTION]*3)-3
            set  [MENTION=1017443]maxlevel[/MENTION] =  [MENTION=1017443]maxlevel[/MENTION]+19
            UPDATE SRO_VT_SHARD.DBO._Char SET Strength  [MENTION=1017443]maxlevel[/MENTION], Intellect  [MENTION=1017443]maxlevel[/MENTION], RemainStatPoint  [MENTION=3093238]remains[/MENTION]tatPoint WHERE CharID  [MENTION=395373]Chari[/MENTION]D
            END
            END 


 IF (@Operation = 41) -- remove stats 
	BEGIN
	IF (@ItemRefID = 93002)
	BEGIN
	  declare [MENTION=314361]strength[/MENTION] int
            declare [MENTION=5100626]Intellect[/MENTION] int
            declare [MENTION=1017443]maxlevel[/MENTION] int
            declare [MENTION=3093238]remains[/MENTION]tatPoint int
            select [MENTION=1017443]maxlevel[/MENTION] = MaxLevel from SRO_VT_SHARD.DBO._Char where CharID = [MENTION=395373]Chari[/MENTION]D
            set [MENTION=3093238]remains[/MENTION]tatPoint =  [MENTION=1017443]maxlevel[/MENTION]*3)-3
            set [MENTION=1017443]maxlevel[/MENTION] = [MENTION=1017443]maxlevel[/MENTION]+19
            UPDATE SRO_VT_SHARD.DBO._Char SET Strength [MENTION=1017443]maxlevel[/MENTION], Intellect [MENTION=1017443]maxlevel[/MENTION], RemainStatPoint [MENTION=3093238]remains[/MENTION]tatPoint WHERE CharID [MENTION=395373]Chari[/MENTION]D
			END
			END