[Request]Dupe fix again

[Svinseladden]

please can someone that know this make a dupe fix for ep5? i been reading this up and down now for day's all i can find is deleted stuff

and 995 of the posts turn out to link to the same page's that are deleted. the litle pro's ps_ fix and some other guy that left this place..

isnt there a easy way to just get that loggout time to work? i have tried alot of the stuff and it does 2 things..

give me alot of error codes or the other one works (command compleat)

but items keep on getting lost. even old stuff LOL

there has to be a way even a tutorial on how it should work so you can check all you need to check and see if you have in your db..

[Tradehappy]

There are alot of links here. The packet based fixed is in the last section.

[Svinseladden]

thanks i have that but i still can't find a dupe fix.. i hade one that worked but after all the attacks i hade for 6 month mine wasent working anymore.

i mabe use a old db but i use the banes ep5 and i can't find a dupe fix for that db i have,.. like i said all i have tried give me buggs like items sudenly is just gone from the db. from guild wh and so on.. and no it's not dupe items..

or i get alot of errors..

[Tradehappy]

Originally Posted by Iulian01

For those who need Dupe Fix check The Admin Panel NEW by Dash

Maybe this one?

[Svinseladden]

angain thanks but iss don't support

sql_connect and i don't have the php skill to change that to ODBC_connect

sorry..

[VIAT]

this has all 3 of EarthCrush's dupe fixes. that it? or you talking about lph ps_game.exe or the the ether one? just let me know i got them all lol^^

[Svinseladden]

have that thanks. i'll try this..

i used the admin pack one and that gave me a big error. about everyone couldnt loggin. +the sql and server was lagging insanly..

kk first one i get:

Msg 102, Level 15, State 1, Line 3
Incorrect syntax near '@UserUID'.
Msg 137, Level 15, State 1, Line 32
Must declare the scalar variable "@LoginTime".
Msg 137, Level 15, State 2, Line 36
Must declare the scalar variable "@UserIP".
Msg 137, Level 15, State 1, Line 41
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 46
Must declare the scalar variable "@UserUID".
Msg 156, Level 15, State 1, Line 50
Incorrect syntax near the keyword 'ELSE'.
Msg 102, Level 15, State 1, Line 59
Incorrect syntax near '.'.
Msg 137, Level 15, State 2, Line 62
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 67
Must declare the scalar variable "@UserUID".
Msg 102, Level 15, State 1, Line 69
Incorrect syntax near 'OFF'.

number 2:

Msg 102, Level 15, State 1, Procedure usp_Try_GameLogout_R, Line 43
Incorrect syntax near '3.'.
Msg 319, Level 15, State 1, Procedure usp_Try_GameLogout_R, Line 43
Incorrect syntax near the keyword 'with'. If this statement is a common table expression, an xmlnamespaces clause or a change tracking context clause, the previous statement must be terminated with a semicolon.

and number 3

Msg 102, Level 15, State 1, Line 5
Incorrect syntax near '…'.
Msg 137, Level 15, State 2, Line 11
Must declare the scalar variable "@ActionTime".
Msg 137, Level 15, State 2, Line 12
Must declare the scalar variable "@ActionTime".
Msg 137, Level 15, State 2, Line 13
Must declare the scalar variable "@ActionTime".
Msg 137, Level 15, State 2, Line 16
Must declare the scalar variable "@ActionType".
Msg 137, Level 15, State 2, Line 22
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 26
Must declare the scalar variable "@CharID".
Msg 137, Level 15, State 2, Line 30
Must declare the scalar variable "@ActionType".
Msg 137, Level 15, State 2, Line 37
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 42
Must declare the scalar variable "@Value2".
Msg 137, Level 15, State 1, Line 47
Must declare the scalar variable "@Sql".
Msg 137, Level 15, State 2, Line 54
Must declare the scalar variable "@Sql".

i just need help fixing this 1 time for all please.. what is my bugg?

[·Tyler·]

Your above errors are from you just executing the queries.. you have to paste the edited code into your stored procedures. Are people this lazy?

Msg 102, Level 15, State 1, Line 5
Incorrect syntax near '…'.

Do you think this really can be part of a stored procedure? Or you didn't bother looking and just thought someone else would look for you?

Msg 137, Level 15, State 1, Line 32
Must declare the scalar variable "@LoginTime".
Msg 137, Level 15, State 2, Line 36
Must declare the scalar variable "@UserIP".
Msg 137, Level 15, State 1, Line 41
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 46
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 62
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 67
Must declare the scalar variable "@UserUID".
Msg 102, Level 15, State 1, Line 69

Msg 137, Level 15, State 2, Line 11
Must declare the scalar variable "@ActionTime".
Msg 137, Level 15, State 2, Line 12
Must declare the scalar variable "@ActionTime".
Msg 137, Level 15, State 2, Line 13
Must declare the scalar variable "@ActionTime".
Msg 137, Level 15, State 2, Line 16
Must declare the scalar variable "@ActionType".
Msg 137, Level 15, State 2, Line 22
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 26
Must declare the scalar variable "@CharID".
Msg 137, Level 15, State 2, Line 30
Must declare the scalar variable "@ActionType".
Msg 137, Level 15, State 2, Line 37
Must declare the scalar variable "@UserUID".
Msg 137, Level 15, State 2, Line 42
Must declare the scalar variable "@Value2".
Msg 137, Level 15, State 1, Line 47
Must declare the scalar variable "@Sql".
Msg 137, Level 15, State 2, Line 54
Must declare the scalar variable "@Sql".

This here is obviously where someone removed the top portion of the stored procedure where it declared the variables that are in every stored procedure. You might want to read what people post before just copy and pasting it into your manager then hitting that Execute button.

Tyler

Edit:

I actually downloaded the above file to see what the '3.' error was:

3. Modify [PS_GameLog].[dbo].[usp_Insert_Action_Log_E] Update your file with the changes highlighted below.

Spoiler:

People are getting too lazy now, the new tools people create are handy, but it makes people think they can just copy and paste things and expect everything just to work, and when it doesn't, come running to the forums instead of looking at what they actually did, which is what they should do, which is what every developer here has done, that is how people learn. If you look at what errors you get, you learn why you get them, or how you have gotten them, and boom, you can start solving your own problems instead of posting the same stuff over and over.


Here is your fix.

 Spoiler

Instead of putting files for you to download, I am going to show you the parts of the files you need to add to your procedures.

Edits to make to the PS_userdata.dbo.usp_Try_GameLogin_Taiwan:

Under DECLARE you must declare the variable @LeaveDate

Like so:

@LeaveDate datetime

You need to add this instead of the current select statement for the UserUID:

SELECT @UserUID=[UserUID], @Status=[Status], @Leave=[Leave], @LeaveDate=LeaveDate 
FROM Users_Master 
WHERE UserID = @UserID AND Pw = @InPassword

-- NotExist User OR Leave User
IF( @UserUID = 0)
BEGIN
	SET @Status = -3
END
ELSE IF (@Leave = 1) --This blocks a logged in account from being kicked
BEGIN
	SET @Status = -5
END
ELSE IF (DATEDIFF(SECOND, @LeaveDate, GETDATE()) < 6)--This is the time delay
BEGIN
	SET @Status = -7
END

*Remove the password check for the OMGWeb Database.

Under --Log Insert, add the UPDATE statement inside the IF statement, below is an example:

IF( @Status = 0 OR @Status = 16 OR @Status = 32 OR @Status = 48 OR @Status = 64 OR @Status = 80 )
BEGIN
    UPDATE Users_Master SET Leave = 1, JoinDate = GETDATE() WHERE UserUID = @UserUID
    EXEC usp_Insert_LoginLog_E @SessionID=@SessionID, @UserUID=@UserUID, @UserIP=@UserIP, @LogType=0, @LogTime=@LoginTime, @LoginType=@LoginType
END

Edits to make to PS_userdata.dbo.usp_Try_GameLogout_R

Add this after the IF statements:

UPDATE Users_Master SET Leave = 1, JoinDate = GETDATE() WHERE UserUID = @UserUID

Edits to make to PS_GameLog.dbo.usp_Insert_Action_Log_E

You must declare the variable @CharLeave below the AS like so:

DECLARE @CharLeave int

Add this:

SET @CharLeave=1

Then below that:

IF @ActionType = '116'--Trade Item-remove item from originator
BEGIN
	WAITFOR DELAY '00:00:05'--Time delay to give the duper time to log out fully
	
	SELECT @CharLeave=Leave
	FROM PS_userdata.dbo.Users_Master
	WHERE UserUID=@UserUID

	IF @CharLeave=0
	BEGIN
		EXEC PS_GameData.dbo.usp_Save_Char_Item_Del_E @CharID=@CharID, @IDList=@Value1
	END
END

IF @ActionType = '164'--Trade Gold-remove gold from originator
BEGIN

	WAITFOR DELAY '00:00:05'--Time delay to give the duper time to log out fully

	SELECT @CharLeave=Leave
	FROM PS_userdata.dbo.Users_Master
	WHERE UserUID=@UserUID

	IF @CharLeave=0
	BEGIN
		UPDATE PS_GameData.dbo.Chars
		SET [Money]=@Value2
		WHERE PS_GameData.dbo.Chars.CharID=@CharID
	END
END

You are now done.

Credits to EarthCrush *[GM]Father* for this.

[Svinseladden]

well this is why.. i hade to change the old one that totaly messed up sql (admin panel so that's why i run this..

btw:

Under DECLARE you must declare the variable @LeaveDate

DECLARE

@Leave tinyint,
@Status smallint,

@CompanyIP varchar(15),
@TempIP varchar(15),
@Check int,
@LeaveDate datetime,

that's there right?


and for number 3:

Edits to make to PS_GameLog.dbo.usp_Insert_Action_Log_E

You must declare the variable @CharLeave below the AS like so:

Code:
DECLARE @CharLeave intAdd this:

Code:
SET @CharLeave=1

mine is like this:

AS

DECLARE @CharLeave int

SET @yyyy = datepart(yyyy, @ActionTime)
SET @mm = datepart(mm, @ActionTime)
SET @dd = datepart(dd, @ActionTime)
SET @CharLeave = 1

both there right?


and after i juast edited everything in that old i hade i got alot of bad red ones. isnt there 1 i can check that works? one i can't just run but i need to see where i might have gone wrong..


i need a compleate for all 3 just to check. i have never used this stuff before i need to learn how this stuff works too..

[·Tyler·]

Originally Posted by Svinseladden

@LeaveDate datetime,

Remove the comma after datetime, but yes that is where it goes.

Originally Posted by Svinseladden

AS

DECLARE @CharLeave int

SET @yyyy = datepart(yyyy, @ActionTime)
SET @mm = datepart(mm, @ActionTime)
SET @dd = datepart(dd, @ActionTime)
SET @CharLeave = 1

This is correct too.

Adding the things to your own procedures allows you to see how they work instead of just pressing the execute button on someone elses work. If you have screwed your procedures up, you can always download the files and get fresh procedures, then add the edits from above to them.

Tyler

[Svinseladden]

i'll try thanks

[aboldijar2]

I make the edits this way on an EP4 server but I get the account doesn't exist message.Is there another way to fix duping on EP4 servers?

[aboldijar2]

Bump