[Release/Bugfix] New login packet by Entwell

Tbp123 · 08/08/2018, 19:27

Basically, Entwell (or Gameforge, idk) has changed their login packet parts and your login server will crash if you log in with the lastest NosTale client to your server.

Fix:

Go -> OpenNos.GameObject.Packets.ClientPackets.LoginPack et.cs LINE 28

Replace this:

Code:

        [PacketIndex(4)]
        public string ClientData { get; set; }

For this:

Code:

        [PacketIndex(4)]
        public string ClientDataOld { get; set; }

        [PacketIndex(5)]
        public string ClientData { get; set; }

Then, go OpenNos.Handler.LoginPacketHandler.cs LINE 149 (I'm not sure about the code line)

And replace this:

Code:

                                string[] clientData = loginPacket.ClientData.Split('.');

For this:

Code:

                                string[] clientData = loginPacket.ClientData.Split('.');

                                    if(clientData.Length < 2)
                                    {
                                        clientData = loginPacket.ClientDataOld.Split('.');
                                    }

Done, it's fixed.

darkriderse83 · 08/08/2018, 20:19

what is the file to change?

MarsBounty · 08/08/2018, 20:27

Quote:

Originally Posted by Tbp123

Go -> OpenNos.GameObject.Packets.ClientPackets.LoginPack et.cs LINE 28

Then, go OpenNos.Handler.LoginPacketHandler.cs LINE 149 (I'm not sure about the code line)

Done, it's fixed.

i think there

GGGGame · 08/08/2018, 22:03

In reality it is less complicated, but ok °-°

Tbp123 · 08/10/2018, 02:12

Quote:

Originally Posted by GGGGame

In reality it is less complicated, but ok °-°

Well, you could just change the packet index of the ClientData var, but what if someone with the old client tries to log in

Itachi-Senpai · 08/10/2018, 02:21

Great job :3

0Lucifer0 · 08/11/2018, 00:31

this is not a really good way to fix the login packet.
This is a better way:

Tbp123 · 08/11/2018, 12:10

Quote:

Originally Posted by 0Lucifer0

this is not a really good way to fix the login packet.
This is a better way:

I didn't know what was the "NONE" ^^

0Lucifer0 · 08/11/2018, 12:16

None just mean not any / again a new way to null value on packet... seems entwell doesn’t care about doing the same thing 10 different way

Tbp123 · 08/11/2018, 12:36

Quote:

Originally Posted by 0Lucifer0

None just mean not any / again a new way to null value on packet... seems entwell doesn’t care about doing the same thing 10 different way

about none

i meant the variable was filled with what, if its not none, what would it be, so i didnt know what it was so i just made it a string

and yeh, but why does entwell do this, im wondering

0Lucifer0 · 08/11/2018, 12:45

It’s a guid

erixor · 08/12/2018, 00:39

If you want to add a GUID to the loginpacket, you have to replace the Convert.ChangeType in the packetfactory with a TypeDescriptor.GetConverter, for example:

before:
return Convert.ChangeType(currentValue, packetPropertyType.GenericTypeArguments[0]);

after:
return TypeDescriptor.GetConverter(packetPropertyType.Gen ericTypeArguments[0]).ConvertFromInvariantString(currentValue);

m.one · 03/14/2021, 19:21

This fix doesn't work anymore?
I just get another error after this fix..

Spoiler

erixor · 03/14/2021, 19:42

Quote:

Originally Posted by m.one

This fix doesn't work anymore?
I just get another error after this fix..

Spoiler

System.IndexOutOfRangeException: Index was outside the bounds of the array.
at OpenNos.Handler.LoginPacketHandler.VerifyLogin(Log inPacket loginPacket) in C:\Users\Administrator\Desktop\OpenNos-dev\OpenNos.Handler\LoginPacketHandler.cs:line 152
at OpenNos.GameObject.ClientSession.TriggerHandler(St ring packetHeader, String packet, Boolean force, Boolean ignoreAuthority) in C:\Users\Administrator\Desktop\OpenNos-dev\OpenNos.GameObject\Networking\ClientSession.cs :line 550
at OpenNos.GameObject.ClientSession.HandlePackets() in C:\Users\Administrator\Desktop\OpenNos-dev\OpenNos.GameObject\Networking\ClientSession.cs :line 467
at OpenNos.GameObject.ClientSession.<.ctor>b__12_0(In t64 x) in C:\Users\Administrator\Desktop\OpenNos-dev\OpenNos.GameObject\Networking\ClientSession.cs :line 87
at System.Reactive.AnonymousSafeObserver`1.OnNext(T value)
at System.Reactive.Linq.ObservableImpl.Timer.Periodic ._.Tick(Int64 count)
at System.Reactive.Concurrency.DefaultScheduler.<>c__ DisplayClass7_0`1.<SchedulePeriodic>b__1()
at System.Reactive.Concurrency.AsyncLock.Wait(Action action)
at System.Threading.ExecutionContext.RunInternal(Exec utionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionCon text executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.TimerQueueTimer.CallCallback()
at System.Threading.TimerQueueTimer.Fire()
at System.Threading.QueueUserWorkItemCallback.System. Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()

No, this fix doesn't work anymore, this post is from 2018. That was before Entwell/Gameforge started implementing internationalization in their client. The NsTesT packet has changed a lot since then. You can probably find it somewhere on this forum by taking a look, since people are constantly asking for a fix