[FIX][C++] SQL Injection in Messenger and Guild

[.Alpha.]

Hello,


today there were attacks to several servers all using the same exploits.
I will not further explain the method used to attack these servers.


To fix it go to messenger_manager.cpp:


Search for the function MessengerManager::RemoveFromList

Replace it with this:

void MessengerManager::RemoveFromList(MessengerManager::keyA account, MessengerManager::keyA companion)
{
    if (companion.empty())
        return;

    char companionEscaped[CHARACTER_NAME_MAX_LEN * 2 + 1];
    DBManager::instance().EscapeString(companionEscaped, sizeof(companionEscaped), companion.c_str(), companion.length());


    DBManager::instance().Query("DELETE FROM messenger_list%s WHERE account='%s' AND companion = '%s'",
                                get_table_postfix(), account.c_str(), companionEscaped);


    __RemoveFromList(account, companion);

    sys_log(1, "Messenger Remove %s %s", account.c_str(), companion.c_str());

    TPacketGGMessenger pack;
    pack.bHeader = HEADER_GG_MESSENGER_REMOVE;
    strlcpy(pack.szAccount, account.c_str(), sizeof(pack.szAccount));
    strlcpy(pack.szCompanion, companion.c_str(), sizeof(pack.szCompanion));
    P2P_MANAGER::instance().Send(&pack, sizeof(TPacketGGMessenger));
}

Credits go to ricky92 and WoM2

[Frosty(´ー｀)]

best guy miau ♥

[NordMT2]

Bester Typ <3

[H4C0K1]

Thanks! <3

[SeaD12345]

Thank you.

[fcsk_aim]

Thanks sir.

[Jelfina]

Danke fürs Teilen und vorallem für die schnellen Absprachen im Fix. Hervorragende Arbeit!

[EA ZY]

Mal wieder super von dir, dass du es mit der Community teilst!
So ne Scheiße muss wirklich nicht sein...

[DeadBreakZz]

Danke

[Myrelle]

Dankesehr ♥

[MQTT.]

Endlich!

[IkoLollo]

Is possible to create one .dif for every game 2089m? My old server has 2089m.

[rollback]

Originally Posted by IkoLollo

Is possible to create one .dif for every game 2089m? My old server has 2089m.

Make an update and use the source. There's no reason to keep developing on this old revision.

[Marius Sorin]

A question. Did anyone tested this fix or it`s just posted for +1?

[rollback]

Originally Posted by Marius Sorin

A question. Did anyone tested this fix or it`s just posted for +1?

Just by reading the code you can see that this fix will work.