Hy, guys i just started to develop metin2Source.
Who the **** writen LibSql.a ?
AsyncSQL.H
dunno. The formatting certainly isn't. Also, abusing stdafx out-of-tree. Ugh. And OS-specific synch. Reserved identifiers. C-style structs. Mixing tabs and spaces. DWORD. ******* m_sem not even used. Copying full async resultset into a container eagerly? Oh. And using mySql
Storing SQLResult* in a vector, not honouring Rule Of Three. The ******* type not even polymorphic, so use vector, or stable_vector if you must. Not typedeffing the container or using auto for the iterators. Using strange names for iterators (past?). Nohting ever initializes m_pkSQL. So that's encapsulation disavowed then.
What happened to smart pointers... uiResultsPos in the database layer?!?!##!@# Not using prepared statements and bound arguments. C-style error handling through multiple non-encapsulated field. Read: missing errorhandling. CAsyncSQL2 - naming fail.
CAsyncSQL looks somewhat saner. Possibly because it was nicked from somewhere?