[Source]Combo Box Fix

[Rhyder`]

Im going to Share The combobox fix of Caja

If you want extended /ci(createitem):

WndControl.cpp
Search for:

int CWndComboBox::AddString( LPCTSTR lpszString )
{
    int nNum = m_wndListBox.AddString( lpszString );
    CRect rect = m_wndListBox.GetWindowRect( TRUE );
    rect.bottom = rect.top + ( ( nNum + 1 ) * ( m_pFont->GetMaxHeight() + 3 ) ) + 8;
    m_wndListBox.SetWndRect( rect );
    return nNum;
}

Replace by:

int CWndComboBox::AddString( LPCTSTR lpszString )
{
    int nNum = m_wndListBox.AddString( lpszString );
    CRect rect = m_wndListBox.GetWindowRect( TRUE );
 
    if(nNum > 10)
        nNum = 10;
    DEBUG_ONLY(IRALog::GetInstance()->Debug("CWndComboBox::AddString : nNum[%d]", nNum));
    rect.bottom = rect.top + ( ( nNum + 1 ) * ( m_pFont->GetMaxHeight() + 3 ) ) + 8;
    m_wndListBox.SetWndRect( rect );
    return nNum;
}

.
.
To edit Height of combo box:

nNum > 10

nNum = 10
Replace 10 what ever you wan't its either 15 or 20

Picture:



Credits: 99.99% Caja
00.01% Me

[Supr3matt]

Already had, but will serve other people, thanks for sharing

[Shiaru]

or just use this, is also included here & better:

[Rhyder`]

Originally Posted by Shiaru

or just use this, is also included here & better:

yeah that is extended admin create item while mine is for the combo box only.
but thanks for your

[adeilson123]

Originally Posted by jayjei14

Im going to Share The combobox fix of Caja

WndControl.cpp
Search for:

int CWndComboBox::AddString( LPCTSTR lpszString )
{
    int nNum = m_wndListBox.AddString( lpszString );
    CRect rect = m_wndListBox.GetWindowRect( TRUE );
    rect.bottom = rect.top + ( ( nNum + 1 ) * ( m_pFont->GetMaxHeight() + 3 ) ) + 8;
    m_wndListBox.SetWndRect( rect );
    return nNum;
}

Replace by:

int CWndComboBox::AddString( LPCTSTR lpszString )
{
    int nNum = m_wndListBox.AddString( lpszString );
    CRect rect = m_wndListBox.GetWindowRect( TRUE );
 
    if(nNum > 10)
        nNum = 10;
    DEBUG_ONLY(IRALog::GetInstance()->Debug("CWndComboBox::AddString : nNum[%d]", nNum));
    rect.bottom = rect.top + ( ( nNum + 1 ) * ( m_pFont->GetMaxHeight() + 3 ) ) + 8;
    m_wndListBox.SetWndRect( rect );
    return nNum;
}

Picture:



Credits: 99.99% Caja
00.01% Me

I pitched well before...
My source already has this.
you guys got from my source UPDATE 3 ...

[Rhyder`]

Originally Posted by adeilson123

I pitched well before...
My source already has this.
you guys got from my source UPDATE 3 ...

o.O caja already have this at french forum of jtb1 when your source are not finish yet!

[arnootie]

dont work.. its messes around with the typ's?...

look:



its on type stromblade, and i got shields, etc etc.. and as you can see i got the update of you're scrol bar..

[sbobetcom]

int CWndComboBox::AddString( LPCTSTR lpszString )
{
	int nNum = m_wndListBox.AddString( lpszString );
	CRect rect = m_wndListBox.GetWindowRect( TRUE );
	int nNum2 = nNum;
	if (nNum2 > 20)
	{
	    nNum2 = 20;
	}
	rect.bottom = rect.top + ( ( nNum2 + 1 ) * ( m_pFont->GetMaxHeight() + 3 ) ) + 8;
	m_wndListBox.SetWndRect( rect );
	return nNum;
}

Credits: 100% V15Source China

[Rhyder`]

Originally Posted by sbobetcom

int CWndComboBox::AddString( LPCTSTR lpszString )
{
	int nNum = m_wndListBox.AddString( lpszString );
	CRect rect = m_wndListBox.GetWindowRect( TRUE );
	int nNum2 = nNum;
	if (nNum2 > 20)
	{
	    nNum2 = 20;
	}
	rect.bottom = rect.top + ( ( nNum2 + 1 ) * ( m_pFont->GetMaxHeight() + 3 ) ) + 8;
	m_wndListBox.SetWndRect( rect );
	return nNum;
}

Credits: 100% V15Source China

O.o try to look on ltd source :P

[sbobetcom]

[Rhyder`]

Originally Posted by sbobetcom

your nNum2 > 20

my nNum > 10 Thats why it's short

[Jomex]

Actually you are tards....

It will cause all data after nNum **** up.

TIP: Check Admin Create Item functioning with nNum set to 10.

[DardanDev]

Originally Posted by Jomex

Actually you are tards....

It will cause all data after nNum **** up.

TIP: Check Admin Create Item functioning with nNum set to 10.

Yep!

Just modify this line:

rect.bottom = rect.top + ( ( nNum + 1 ) * ( m_pFont->GetMaxHeight() + 3 ) ) + 8;

and change it to this:

rect.bottom = rect.top + ( ( (nNum <= 15 ? nNum : 15) + 1 ) * ( m_pFont->GetMaxHeight() + 3 ) ) + 8;

Change 15 to whatever you want, it changes the size of the combobox.

Regards, Me;