[Release]Fixed Trading Packet

[Arcо]

Originally Posted by _Decker

I did everything you said.
I replaced the first code with the second code.

Read the directions.
Actually read them, don't skim through it.

[jitus2]

Again thank you arco.

I still have a small display bug for certain items:



This is not very annoying, and the bug occurs only for a few rare items.

[Arcо]

That's probably your client, make sure you have an itemminicon for that item.

[jitus2]

Agree =)
thx
I take this opportunity to ask a small question which I have great need, how can I do to change the name of an npc?

[xScott]

great release

[-Shunsui-]

Good Job, SON!

jk jk, But Good release

[ramix]

the erro i see in my packet is

public static COPacket TradeItem(Game.Item I)
        {
            byte[] Packet = new byte[8 + 48];
            COPacket P = new COPacket(Packet);
            P.WriteInt16((ushort)(Packet.Length - 8));
            P.WriteInt16((ushort)0x3f0);
            P.WriteInt32(I.UID);
            P.WriteInt32(I.ID);
            P.WriteInt16(I.CurDur);
            P.WriteInt16(I.MaxDur);
            P.WriteInt16(2);
            P.WriteInt16(0);
            P.WriteInt32(I.TalismanProgress);
            [COLOR="Red"]P.Move(2);[/COLOR]            
            P.WriteByte((byte)I.Soc1);
            P.WriteByte((byte)I.Soc2);
            P.WriteInt16((ushort)I.Effect);
            P.WriteByte(I.Plus);
            P.WriteByte(I.Bless);
            if (I.FreeItem)
                P.WriteByte(1);
            else
                P.WriteByte(0);
            P.WriteByte(I.Enchant);
            P.Move(6);
            if (I.Locked)            
                P.WriteInt16(3);            
            else P.WriteInt16(0);
            P.WriteInt32((uint)I.Color);

            P.WriteInt32(I.Progress);

            return P;
        }

to that

public static COPacket TradeItem(Game.Item I)
        {
            byte[] Packet = new byte[8 + 48];
            COPacket P = new COPacket(Packet);
            P.WriteInt16((ushort)(Packet.Length - 8));
            P.WriteInt16((ushort)0x3f0);
            P.WriteInt32(I.UID);
            P.WriteInt32(I.ID);
            P.WriteInt16(I.CurDur);
            P.WriteInt16(I.MaxDur);
            P.WriteInt16(2);
            P.WriteInt16(0);
            P.WriteInt32(I.TalismanProgress);
            [COLOR="Red"]P.Move(0);[/COLOR]            
            P.WriteByte((byte)I.Soc1);
            P.WriteByte((byte)I.Soc2);
            P.WriteInt16((ushort)I.Effect);
            P.WriteByte(I.Plus);
            P.WriteByte(I.Bless);
            if (I.FreeItem)
                P.WriteByte(1);
            else
                P.WriteByte(0);
            P.WriteByte(I.Enchant);
            P.Move(6);
            if (I.Locked)            
                P.WriteInt16(3);            
            else P.WriteInt16(0);
            P.WriteInt32((uint)I.Color);

            P.WriteInt32(I.Progress);

            return P;
        }

ty and great release

[Korvacs]

P.Move(0);

This can be removed completely, its meant to move the write position in the buffer forward a number of spaces, by setting it to 0 it doesnt move at all and your just giving your processor some work to do for no reason at all.

[copz1337]

mind explaining what the bug with the original packet was?

[ArtOfWar]

Originally Posted by copz1337

mind explaining what the bug with the original packet was?

The bug was that if you trade something full +12 it show it as just super not +12 or anything

[Decker_]

Thanks Arco, I got it working!
+k

[darkdestiny54]

Great Job ^^ Works perfectly!

[Arcо]

Originally Posted by copz1337

mind explaining what the bug with the original packet was?

Click the link in my first post, you will see.

[Decker_]

Originally Posted by copz1337

mind explaining what the bug with the original packet was?

Example:
Let's say you trade a Super bow +12 2soc sdg, and they put it on the trade list, the other person see's it only as a super bow, not as a super +12 2soc sdg bow.

I hope I helped!

[ArtOfWar]

Yeah this fixed the trading perfectly thanks .Arco