How to edit PK Mode System Message like Real Conquer Online .- TQ.Elgahed

[TQ-Challenger]

By the name of the god



========================



lets open PacketHandler.cs



and search this code :

PHP Code:

        static void ChangePKMode(Data generalData, Client.GameState client)

        {

            client.Entity.AttackPacket = null;

            client.Entity.PKMode = (Game.Enums.PKMode)(byte)generalData.dwParam;

            client.Send(generalData);

        } 


Then replace it with this code

PHP Code:

        #region ChangePKMode

        static void ChangePKMode(Data generalData, Client.GameState client)

        {

            client.Entity.AttackPacket = null;

            client.Entity.PKMode = (Game.Enums.PKMode)(byte)generalData.dwParam;

            client.Send(generalData);

            if (client.Entity.PKMode == Game.Enums.PKMode.PK)

            {

                client.Send(new Message("Free PK mode. You can attack monster and all players.", System.Drawing.Color.Red, Message.Talk));

            }

            if (client.Entity.PKMode == Game.Enums.PKMode.Capture)

            {

                client.Send(new Message("Capture PK mode. You can only attack monsters, black-name and blue-name players.", System.Drawing.Color.Red, Message.Talk));

            }

            if (client.Entity.PKMode == Game.Enums.PKMode.Peace)

            {

                client.Send(new Message("Peace mode. You can only attack monsters.", System.Drawing.Color.Red, Message.Talk));

            }

            if (client.Entity.PKMode == Game.Enums.PKMode.Team)

            {

                client.Send(new Message("Team PK mode. You can attack monster and all players except your teammates.", System.Drawing.Color.Red, Message.Talk));

            }

        }

        #endregion 


Done .

[nTL3fTy]

This is definitely one of those times you use an if-else if (at least):

if (client.Entity.PKMode == Game.Enums.PKMode.PK) 
{ 
    client.Send(new Message("Free PK mode. You can attack monster and all players.", System.Drawing.Color.Red, Message.Talk)); 
} 
else if (client.Entity.PKMode == Game.Enums.PKMode.Capture) 
{ 
    client.Send(new Message("Capture PK mode. You can only attack monsters, black-name and blue-name players.", System.Drawing.Color.Red, Message.Talk)); 
} 
else if (client.Entity.PKMode == Game.Enums.PKMode.Peace) 
{ 
    client.Send(new Message("Peace mode. You can only attack monsters.", System.Drawing.Color.Red, Message.Talk)); 
} 
else if (client.Entity.PKMode == Game.Enums.PKMode.Team) 
{ 
    client.Send(new Message("Team PK mode. You can attack monster and all players except your teammates.", System.Drawing.Color.Red, Message.Talk)); 
}

[Mr_PoP]

Originally Posted by nTL3fTy

This is definitely one of those times you use an if-else if (at least):

if (client.Entity.PKMode == Game.Enums.PKMode.PK) 
{ 
    client.Send(new Message("Free PK mode. You can attack monster and all players.", System.Drawing.Color.Red, Message.Talk)); 
} 
else if (client.Entity.PKMode == Game.Enums.PKMode.Capture) 
{ 
    client.Send(new Message("Capture PK mode. You can only attack monsters, black-name and blue-name players.", System.Drawing.Color.Red, Message.Talk)); 
} 
else if (client.Entity.PKMode == Game.Enums.PKMode.Peace) 
{ 
    client.Send(new Message("Peace mode. You can only attack monsters.", System.Drawing.Color.Red, Message.Talk)); 
} 
else if (client.Entity.PKMode == Game.Enums.PKMode.Team) 
{ 
    client.Send(new Message("Team PK mode. You can attack monster and all players except your teammates.", System.Drawing.Color.Red, Message.Talk)); 
}

or switch() case{} ?

[pro4never]

was just gonna say...

USE SWITCH!

That being said, he did say at LEAST use if/elseif which makes him correct anyways :P

[Korvacs]

Don't use a switch, switches perform worse than if/else at lower iterations like this.

[Spirited]

Or... just have one statement and use a string array to tell the client what message to display.

[pro4never]

Originally Posted by Korvacs

Don't use a switch, switches perform worse than if/else at lower iterations like this.

Interesting, at what point does switch become more efficient? or is it one of those things used more for aesthetic appeal then actual performance? I for some reason had it in my mind that switch became more efficient after a fairly low number of if/else if statements but I'm probably wrong.

[Spirited]

Originally Posted by pro4never

Interesting, at what point does switch become more efficient? or is it one of those things used more for aesthetic appeal then actual performance? I for some reason had it in my mind that switch became more efficient after a fairly low number of if/else if statements but I'm probably wrong.

Here's my opinion on it:
I did a little research, and in the long run (depending on how many cases the statement is checking...) if else statements perform the worst. In situations where there are less than 5 cases being checked, an if-else structure performs the best. However, when you're dealing with that little of a switch, you should always consider how to write it as one statement.

This is how I'd do it:
client.Send(new ClientMessage(PkNotifications[generalAction.PrimaryAction], ChatTone.System).ToPointer());

[nTL3fTy]

Originally Posted by Fаng

This is how I'd do it:
client.Send(new ClientMessage(PkNotifications[generalAction.PrimaryAction], ChatTone.System).ToPointer());

What happens if I'm on a proxy and send PKMode 50?

[pro4never]

Originally Posted by nTL3fTy

What happens if I'm on a proxy and send PKMode 50?

While I'm sure he'd account for this... it does make it a less elegant solution when you add in all sorts of error checking.

[Spirited]

Originally Posted by nTL3fTy

What happens if I'm on a proxy and send PKMode 50?

I check the range before I even assign it. I'm showing you the message line, not how I assign everything.

[nTL3fTy]

Originally Posted by Fаng

I check the range before I even assign it. I'm showing you the message line, not how I assign everything.

I was going on the assumption that generalData was your packet instance and PrimaryAction was a field in the packet. Considering that, it seemed as though you were just taking the field from the packet with no range checks. If this isn't correct, I'm clearly confused.

[Mr_PoP]

well use switch.
In the worst case the compiler will generate the same code as a if-else chain, so you don't lose anything. If in doubt put the most common cases first into the switch statement.

In the best case the optimizer may find a better way to generate the code. Common things a compiler does is to build a binary decision tree (saves compares and jumps in the average case) or simply build a jump-table (works without compares at all).

[Korvacs]

Originally Posted by pro4never

Interesting, at what point does switch become more efficient? or is it one of those things used more for aesthetic appeal then actual performance? I for some reason had it in my mind that switch became more efficient after a fairly low number of if/else if statements but I'm probably wrong.

Test i've read show that it varies under different circumstance, and your own benchmark will also show this most likely, the general rule of thumb is that if the number of conditions is 5 or more then use a switch as the switch will use a Hashtable which adds a reasonable amount of overhead (lookup + jump), otherwise in basically all cases if/else would be preferred.

[Spirited]

Originally Posted by nTL3fTy

I was going on the assumption that generalData was your packet instance and PrimaryAction was a field in the packet. Considering that, it seemed as though you were just taking the field from the packet with no range checks. If this isn't correct, I'm clearly confused.

That's correct. I'm using the general packet like everyone else does ... I error check it BEFORE I handle it. If it's correct, I use the data in the packet. Problem?