Co2 Redux v2 Bow Proficiency problem

[youssef911]

Hello all, it has been a while since i last visited the forum. I have been trying for hours to solve this problem but it seems i have not had any luck.

Expected behavior:
when i hit monsters single arrow with bow or at TG the proficiency percentage increases till it reaches 100% then the skill levels. this should happen for all levels until it is maxed out.

Actual Behavior:
when i hit monsters or TG stake with single arrow the proficiency behaves normally until level 2. when the bow proficiency reaches level 3, the percentage resets each time it reaches 10%. however the actual experience gained is still recorded. So if i keep on hitting and i let it reset for 10 times it actually levels up but the problem is i do not know how much percent is left this way. i started debugging the addProficiencyExperience() function but it seems to be working exactly fine. in fact the bow is the only weapon that has this problem, all single handed or two handed weapons at least the mostly used ones i tried work fine i did not notice any behavior like this from any other proficiency.

I am hoping someone can tell me where i can find the code to debug that is specific for showing the percentage left for proficiency level up for bow.

If that is a client sided issue can it be solved?

Thank you all.

[Spirited]

Weird. Was it fixed in the 3.0 version by any chance? Can you post the function to here so we can take a look at what you currently have?

[Super Aids]

I would debug the handler for bow attacks, it's most likely an issue with not updating the client properly. So step through the whole handler and not just that function, as you said it actually works, it just doesn't show properly. So I would throw my 2 cents at it happening a step further back than that function.

[youssef911]

here are the proficiency functions

 Spoiler

#region AddOrUpdateProf
public void AddOrUpdateProf(ushort _id, ushort _level, uint _exp = 0)
{
ConquerProficiency prof;
if (proficiencies.ContainsKey(_id))
{
proficiencies[_id].Level = _level;
proficiencies[_id].Experience = _exp;
proficiencies[_id].Save();
prof = proficiencies[_id];
}
else
{
prof = ConquerProficiency.Create(owner.UID, _id, _level, _exp);
proficiencies.TryAdd(prof.ID, prof);
prof.Save();
}
prof.Send(owner);

}
public void AddProficiencyExperience(ushort _id, ulong _amount)
{
if (_amount == 0)
return;
if (!proficiencies.ContainsKey(_id))
AddOrUpdateProf(_id, 1);
else
{
var prof = proficiencies[_id];
if (prof.Level >= 20)
return;
prof.Experience += (uint)_amount;
while (prof.Level < Constants.ProficiencyLevelExperience.Length && prof.Experience >= Constants.ProficiencyLevelExperience[prof.Level])
{
prof.Experience -= Constants.ProficiencyLevelExperience[prof.Level];
prof.Level++;
if (prof.PreviousLevel != 0 && (prof.PreviousLevel / 2) < prof.Level)
{
prof.Level = prof.PreviousLevel;
prof.PreviousLevel = 0;
prof.Save();
}
}
prof.Send(owner);
}
}
#endregion
#region AddOrUpdateSkill
public void AddSkillExperience(ushort _id, ulong _amount)
{
if (_amount == 0)
return;
if (!skills.ContainsKey(_id))
return;
var skill = skills[_id];
if (skill.Info == null || owner.Level < skill.Info.NeedLevel && skill.Info.NeedLevel > 0)
return;
skill.Experience += (uint)_amount;
while (skill.Experience > skill.Info.NeedExp && skill.Info.NeedExp > 0)
{

byte AddOn = 0;
if (skill.PreviousLevel != 0 && (skill.PreviousLevel / 2) < (skill.Level + 1))
{
AddOn = (byte)(skill.PreviousLevel - (skill.Level + 1));
}
var dbSkill = Database.ServerDatabase.Context.MagicType.GetMagic typeByIDAndLevel(skill.ID, (ushort)(skill.Level + 1 + AddOn));
if (dbSkill == null)
dbSkill = Database.ServerDatabase.Context.MagicType.GetMagic typeByIDAndLevel(skill.ID, (ushort)(skill.Level + 1));//Failsafe
if (dbSkill == null)
return;

ConquerSkill x;
if (skills.TryRemove(skill.ID, out x))
{
skill.Experience -= skill.Info.NeedExp;
skill.Level = dbSkill.Level;
skill.ID = dbSkill.ID;
skill.Save();
skills.TryAdd(skill.ID, skill);
}
}
skill.Send(owner);
}

And here is the launch attack handler

 Spoiler

#region Launch Attack
private void LaunchAttack()
{
try
{
target = owner.Map.Search<Entity>(targetUID);
if (!owner.Alive || target == null || !IsValidTarget(target) || !IsInAttackRange(target) || target.HasEffect(ClientEffect.Fly) && target.AttackRange < 5)
{ AbortAttack(); return; }

//Do not check equipment if we have none
if (owner.Equipment != null)
{
skill = GetWeaponSkill();
if (skill != null)
{ location = target.Location; LaunchSkill(); return; }
}
DisplaySuperGemEffects();
//Deal damage to target
state = SkillState.Attack;
nextTrigger = Common.Clock + owner.AttackSpeed / (owner.HasEffect(ClientEffect.Cyclone) ? 3 : 1);
uint dmg;

if (owner.WeaponType == 500)
{
ConquerItem item;

owner.Equipment.TryGetItemBySlot(5, out item);

if (item == null || item.Durability < 1)
{
AbortAttack(); return;
}
if (!owner.Map.IsTGMap && item != null)
{
item.Durability -= 1;
owner.Send(ItemInformationPacket.Create(item, ItemInfoAction.Update));

if (item.Durability == 0)

{
uint id = item.StaticID;
AutoEquip(item, id);

}


}
dmg = owner.CalculateBowDamage(target, null, true);

}

else
dmg = owner.CalculatePhysicalDamage(target, null, true);



if (owner is Player)
{


var expGain = owner.CalculateExperienceGain(target, dmg);
((Player)owner).GainExperience(expGain);
//proficiency experience
if (owner.Map.IsTGMap)
{
expGain = 1000 * expGain;
AddProficiencyExperience(owner.WeaponType, expGain);

}
//proficiency experience on monsters
else
{

AddProficiencyExperience(owner.WeaponType, expGain);

}


}
else if (owner is Pet)
{
if (((Pet)owner).PetOwner != null)
{
var expGain = owner.CalculateExperienceGain(target, dmg);
((Pet)owner).PetOwner.GainExperience(expGain);
}

}
target.ReceiveDamage(dmg, owner.UID);

if (!target.Alive)
{
if (target is SOB)
{
target.Kill(1, owner.UID);
owner.SendToScreen(InteractPacket.Create(owner.UID , target.UID, (ushort)target.Location.X, (ushort)target.Location.Y, (owner.WeaponType == 500 ? InteractAction.Shoot : InteractAction.Attack), dmg), true);
}
else
{

owner.SendToScreen(InteractPacket.Create(owner.UID , target.UID, (ushort)target.Location.X, (ushort)target.Location.Y, (owner.WeaponType == 500 ? InteractAction.Shoot : InteractAction.Attack), dmg), true);

if (owner.HasEffect(ClientEffect.Cyclone))
{
((Player)owner).KOCount++;
owner.ClientEffects[ClientEffect.Cyclone] += 700;
target.Kill(65541 * ((Player)owner).KOCount, owner.UID);
}
else if (owner.HasEffect(ClientEffect.Superman))
{
((Player)owner).KOCount++;
owner.ClientEffects[ClientEffect.Superman] += 700;
target.Kill(65541 * ((Player)owner).KOCount, owner.UID);
}
else
{
target.Kill(1, owner.UID);

}

}
}
else
owner.SendToScreen(InteractPacket.Create(owner.UID , target.UID, (ushort)target.Location.X, (ushort)target.Location.Y, (owner.WeaponType == 500 ? InteractAction.Shoot : InteractAction.Attack), dmg), true);
}
catch (Exception p)
{ AbortAttack(); }

}
#endregion

[luizinhofox]

check the weapon.dat on the client if it is changed, it can solve your problem.

[youssef911]

Originally Posted by luizinhofox

check the weapon.dat on the client if it is changed, it can solve your problem.

Inside the client folder there are 2 files called WeaponSkilllLevelExp.ini but i change them nothing happens. and i found no weapon.dat on the client (5065) however i can say all the files are last modified between 2003 and 2005. i tried to follow the function till the [1025] WeaponProficiency packet. but every thing seems to be going fine. i dont know if i missed something but all it does is check for wep id , and skill experience then add id to the id of the player after calculating the exp based on dmg and all. so i am still lost here on where does the code make the percentage of gained vs needed exp then send it to display to user. For example when i made the team member mini-map search i had to send the member id and locX and locY and so it updates on case 106. but with this one i dont see any change to percentage or anything of that sort. maybe it is handled by the client. but if so then the values passed from the server may be messed up. but then again how does the skill normally lvl when it reaches maximum experience needed for that level?
i am a bit lost here i would really apreciate some help xD

[Ultimation]

LOL

[Ism33lawy]

Originally Posted by Ultimation

LOL

Glad to see you, I am proud of you.

[pintinho12]

Community is getting interesting

[KraHen]

Keep it to the thread pls.

[Latyos]

I have the same problem currently. I'm pretty sure it's a client-side problem as experience/level values update properly on server-side.

For me, it's not only bow but any weapon. What happens is that, when you get to 25% of experience on proficiency, on client-side, it reverts back to 0% and starts counting again. On server-side, experience is up-to-date though. After it reverts back from 25% to 0% 3 times (75% in total), on 4th 25%, it suddenly levels up.

WeaponSkillLevelExp.ini values in client are same with the ones in server.

[denominator]

Did you figure out what the issue was?

[youssef911]

I did not figure the issue out yet actually. It has been about 2 years since I last coded in CO2 and I am back now, This bug is really killing my mind still cant figure out the root cause.

Also you are correct it is not only limited to the Bow proficiency, this issue is a global one on all weapon types

guys I think I found out the issue. The issue was in this line var buffer = new byte[24];
it was defined initially as new byte[22]. And we are passing 4 + 8 + 22 = 24;
so we were skipping 2 bytes on each send which I think was the reason for messing up the exp calculation on the client.

This is the fixed file if you are using Redux

[1025] WeaponProficiency.cs

 Spoiler

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using Redux.Structures;
using Redux.Database.Domain;

namespace Redux.Packets.Game
{
public unsafe struct WeaponProficiencyPacket
{
public ushort ID;
public ushort Level;
public uint Experience;
public static WeaponProficiencyPacket Create(ConquerProficiency prof)
{
var packet = new WeaponProficiencyPacket();
packet.ID = prof.ID;
packet.Level = prof.Level;
packet.Experience = prof.Experience;
return packet;
}
public static implicit operator byte[](WeaponProficiencyPacket packet)
{
var buffer = new byte[24];
fixed (byte* ptr = buffer)
{
PacketBuilder.AppendHeader(ptr, buffer.Length, Constants.MSG_PROFICIENCY);
*((ushort*)(ptr + 4)) = packet.ID;
*((ushort*)(ptr + 8)) = packet.Level;
*((uint*)(ptr + 12)) = packet.Experience;
}
return buffer;
}
}
}

[~Crystaline]

Update the weapon/spell proficiency using the packet type 1104 (MsgFlushExp). Try to look on other sources here for implementation.

[youssef911]

Actually I am not sure if this is the correct way or not but this server was originally made by Pro4Never and the way its currently structured for the packet handling is that 1025 (WeaponProficiencyPacket) & the skill packet is 1103 (ConquerSkill). and actually [1104] is not used at all. I might try to use it and see what gets affected. But anyway the main issue is now fixed because all proficiencies now reach 100% then level up compared to only reaching 10% or under due to the limit on the buffer size.