Compose problem in 5165

[ipwnudont]

Ok on the server im currently Staff on we are having a problem with Composing such as when you make a +12 item at the Wuxing oven and then log out and log back in there will be 4 exact duplicates in your inventory...any ideas at all?

[-Shunsui-]

I have no clue why its making Duplicates but check the code, Nor go to the Guides and Release section a Good working Wuxing over was released,

[ipwnudont]

Thanks ill suggest it to the Coder and +karma for you

[Arcо]

Originally Posted by ipwnudont

Thanks ill suggest it to the Coder and +karma for you

Go to o striides multi release thread, Iposted my fix for composition in there and it works 100%.

[~Yuki~]

Originally Posted by Hepatitis C

Go to o striides multi release thread, Iposted my fix for composition in there and it works 100%.

Wrong it didnt work actually coz u forgot a line, u said change to this:

PHP Code:

if (MainI.ID != 0 && MinorI.ID != 0 && MainI.Plus <= 11)
            {
                uint Progress = MainI.Progress;
                Progress += Database.StonePts[MinorI.Plus];

                GC.MyChar.RemoveItem(MainI);

                while (Progress >= Database.ComposePts[MainI.Plus] && MainI.Plus <= 11)
                {
                    Progress -= Database.ComposePts[MainI.Plus];
                    MainI.Plus++;
                }

                if (MainI.Plus == 12)
                    Progress = 0;
                MainI.Progress = (ushort)Progress;
                GC.MyChar.AddItem(MainI);
        }
    } 


instead of

PHP Code:

            if (MainI.ID != 0 && MinorI.ID != 0 && MainI.Plus <= 11)
            {
                uint Progress = MainI.Progress;
                Progress += Database.StonePts[MinorI.Plus];

                GC.MyChar.RemoveItem(MainI);

                while (Progress >= Database.ComposePts[MainI.Plus] && MainI.Plus <= 11)
                {
                    Progress -= Database.ComposePts[MainI.Plus];
                    MainI.Plus++;
                }
                if (MainI.Plus == 12)
{
                    Progress = 0;
                    MainI.Progress = (ushort)Progress;
}
                    GC.MyChar.AddItem(MainI);
                    GC.MyChar.RemoveItem(MinorI);// Here what u forgot!
            } 


[Arcо]

Originally Posted by ~Yuki~

Wrong it didnt work actually coz u forgot a line, u said change to this:

PHP Code:

if (MainI.ID != 0 && MinorI.ID != 0 && MainI.Plus <= 11)
            {
                uint Progress = MainI.Progress;
                Progress += Database.StonePts[MinorI.Plus];

                GC.MyChar.RemoveItem(MainI);

                while (Progress >= Database.ComposePts[MainI.Plus] && MainI.Plus <= 11)
                {
                    Progress -= Database.ComposePts[MainI.Plus];
                    MainI.Plus++;
                }

                if (MainI.Plus == 12)
                    Progress = 0;
                MainI.Progress = (ushort)Progress;
                GC.MyChar.AddItem(MainI);
        }
    } 


instead of

PHP Code:

            if (MainI.ID != 0 && MinorI.ID != 0 && MainI.Plus <= 11)
            {
                uint Progress = MainI.Progress;
                Progress += Database.StonePts[MinorI.Plus];

                GC.MyChar.RemoveItem(MainI);

                while (Progress >= Database.ComposePts[MainI.Plus] && MainI.Plus <= 11)
                {
                    Progress -= Database.ComposePts[MainI.Plus];
                    MainI.Plus++;
                }
                if (MainI.Plus == 12)
{
                    Progress = 0;
                    MainI.Progress = (ushort)Progress;
}
                    GC.MyChar.AddItem(MainI);
                    GC.MyChar.RemoveItem(MinorI);// Here what u forgot!
            } 


Um, no.
I've used that code ever since I started the 5165 and it worked perfectly.

[~Yuki~]

Mate if u dont add a line to remove the stone it will stay in inv.

[Arcо]

Originally Posted by ~Yuki~

Mate if u dont add a line to remove the stone it will stay in inv.

Well would you mind telling me why mine works perfectly without that line?

[Basser]

Originally Posted by Hepatitis C

Well would you mind telling me why mine works perfectly without that line?

Because you are Hepatitis. Your a disease, remember?
Diseases can skip 1 line in every void, bool and struct because they are special. =)

[Arcо]

Originally Posted by Hepatitis X

Because you are Hepatitis. Your a disease, remember?
Diseases can skip 1 line in every void, bool and struct because they are special. =)

Oh yeah, I forgot that I read that in the C# handbook!

[.Ryu]

Here you go this is stigs thread for fixed compose...


Goodluck

[ipwnudont]

**EDIT
Problem fixed thanks to everyone

#request to close thread please