is this bad? cps drop way

[marcbacor6666]

 if (killer.MapID == 1000)
                    {
                        killer.Money += 500;
                        killer.ConquerPoints += 90;
                        killer.Owner.Send(new Network.GamePackets.Message("You killed " + Name + " and earned 90 cps and 500 silver!", System.Drawing.Color.Red, 2005));
                    }

if (killer.MapID == 1002)
                    {
                        killer.Money += 600;
                        killer.ConquerPoints += 100;
                        killer.Owner.Send(new Network.GamePackets.Message("You killed " + Name + " and earned 100 cps and 600 silver!", System.Drawing.Color.Red, 2005));
                    }

and

soon

[abdoumatrix]

i prefer this

 Spoiler

PHP Code:

uint money, cps;
Switch (Killer.MapID)
{
case 1000:
{
money = 10;
cps = 100;
}
break;
case 1002:
{
money = 100;
cps = 1000; 
}
break;
}
killer.Money += money;
killer.ConquerPoints += cps;
killer.Owner.Send(new Network.GamePackets.Message("You killed " + Name + " and earned "+ cps +"cps and "+ money +"silver!", System.Drawing.Color.Red, 2005)); 


[killersub]

What are you trying to ask?

Seems to me like you're just giving money/CPs to the character after killing a monster in a specific map.

That looks about right but maybe you can make it better.

[Aceking]

If it was me, I would add a field to the map database and populate that field with the drop amount.

Then you would simply do something like:

Player.CP += Player.Map.CPDrop

Would save going through switches or a bunch of if statements

[marcbacor6666]

What are you trying to ask?

Seems to me like you're just giving money/CPs to the character after killing a monster in a specific map.

That looks about right but maybe you can make it better.

yup im asking if its bad if i make the drops like that. "will it affects the server performance" like stability, memoryusage, cpuusage , something like that."

[Super Aids]

Why do you hardcode it?
Store it in a table in your database and make it dynamic.

[pro4never]

As ^ said. Your system is pretty difficult to edit and not overly scalable.

In redux I just create a drop rule. It lets you add a line to database to control as many drops or gains as you want for a specific ID. Can be easily expanded to link up with quests as well!


EG:
On killing mob Id X there's Y percent chance to drop a(n) Z

It uses types so it supports ground items (drops), inventory items (quest items), inventory cp and inventory gold.

Take a look at that source if you want an example of how to handle it.

[marcbacor6666]

Thank you very much for the reply guys

[.Light]

Yeah isn't this how its coded by default in all the egypt sources. Super Aids is right, if I were you I would definitely make it changeable from the database. Should be pretty simple to code if you look at some of the sources released here.

On another note, if this source is just for you and you don't mind having to edit the code to change everything, keep it how it is.

If you're planing on releasing it, as sad as it is, most people won't know how to edit that stuff anyway so you'd have to either make a guide for everything or put it in the database (:

[marcbacor6666]

i will try to make some tutorials if im done on my server im currently making a quest base on SwordARtOnline movie. the 100 room bosses.

i did that cps implementation cuz i want the map have different cps drops depends on map level sample the twincity is mostly level 1 + map. so it have the lowest cps drop something like that.

i will try to look at the public sources that been sticked here thanks guys for helping