procedure dont work

[Beba Army]

 Spoiler

Lines :
_RefobjCommon :
1	57443	ITEM_MALL_LOTTERYX1	?????	xxx	SN_ITEM_MALL_LOTTERYX1	SN_ITEM_MALL_LOTTERYX1_TT_DESC	1	0	3	3	3	1	180000	3	0	1	1	1	255	0	1	0	0	1	0	0	0	0	0	0	0	-1	0	-1	0	-1	0	-1	0	-1	0	0	0	0	0	0	0	100	0	0	0	xxx	item\etc\drop_mall_scroll.bsr	item\etc\mall_return_scroll.ddj	xxx	xxx	23585	No Name

_RefObjItem :
57442	50	2	0	0	1	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	1000	????	1	??????                                                                                                                           	-1	RESURRECT	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	0	0	0


itemdata_45000.txt :
1	49084	ITEM_MALL_LOTTERYX1	?????	xxx	SN_ITEM_MALL_LOTTERYX1	SN_ITEM_MALL_LOTTERYX1_TT_DESC	1	0	3	3	3	1	180000	3	0	1	1	1	255	0	1	0	0	1	0	0	0	0	0	0	0	-1	0	-1	0	-1	0	-1	0	-1	0	0	0	0	0	0	0	100	0	0	0	xxx	item\etc\drop_mall_scroll.bsr	item\etc\mall_return_scroll.ddj	xxx	xxx	50	2	0	0	1	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	1000	????	1	??????                                                                                                                           	-1	RESURRECT	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	0	0	



textdata_object :

1	SN_ITEM_MALL_LOTTERYX1								Lottery Scroll
1	SN_ITEM_MALL_LOTTERYX1_TT_DESC								Use this scroll to get a random item .





------------------------------------------------------------------------------------------
Table :



USE [SRO_VT_SHARD]
GO

/****** Object:  Table [dbo].[_LotteryTABLE]    Script Date: 07/24/2017 19:54:32 ******/
SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

SET ANSI_PADDING ON
GO

CREATE TABLE [dbo].[_LotteryTABLE](
	[ID] [int] NULL,
	[CodeName128] [varchar](250) NULL,
) ON [PRIMARY]

GO

SET ANSI_PADDING OFF
GO
-------------------------------------------------------------------------------------------
Procedure :
SRO_VT_SHARDLOG [_ADDLOGITEM]




if (@ItemRefID = 57442 and [MENTION=1059401]operation[/MENTION] = 16)
	begin--Usage:--exec _ADD_ITEM_EXTERN 'CharName','ItemsCodeName',Count,OptLvl
	declare @cname1 varchar(64)
	select @cname = CharName16 from SRO_VT_SHARD.dbo._Char where CharID = @CharID
		declare [MENTION=5247166]sayi[/MENTION] int
		declare @adet int
		declare [MENTION=1166386]maxa[/MENTION] int
		declare [MENTION=331054]Mina[/MENTION] int
		select [MENTION=1166386]maxa[/MENTION] =  MAX(ID)  FROM SRO_VT_SHARD .dbo._LotteryTABLE
		select [MENTION=331054]Mina[/MENTION] =  Min(ID)  FROM SRO_VT_SHARD .dbo._LotteryTABLE
		declare @itemname varchar(64)
		etik:	
SELECT  [MENTION=5247166]sayi[/MENTION] =  (CONVERT(INT, RAND() *  [MENTION=1166386]maxa[/MENTION] [MENTION=331054]Mina[/MENTION]+1))+ [MENTION=331054]Mina[/MENTION]))
select @itemname = CodeName128 from SRO_VT_SHARD.dbo._LotteryTABLE where ID = [MENTION=5247166]sayi[/MENTION]
		select @itemname = CodeName128 from SRO_VT_SHARD.dbo._LotteryTABLE where ID = [MENTION=5247166]sayi[/MENTION]
		print [MENTION=5247166]sayi[/MENTION] 
		print @itemname
		if(PATINDEX('%ITEM%',@itemname)>0)
		begin	
		print 'not present' 
		end
		else begin
		print 'not present' 
		goto etik 
		end
		exec SRO_VT_SHARD.dbo._ADD_ITEM_EXTERN @cname,@itemname,1,0 
end

This dont work also:

 Spoiler

https://if @itemRefID =777949 and [MENTION=1059401]operation[/MENTION] = 41
begin
declare [MENTION=659242]rani[/MENTION]d int = (select top 1 id from SRO_VT_SHARD.._LotteryTABLE order by NEWID())
declare @itemname varchar(64)
select @itemname = CodeName128 from SRO_VT_SHARD.dbo._LotteryTABLE where ID = [MENTION=659242]rani[/MENTION]d
exec SRO_VT_SHARD.dbo._Additembyname @charname,itemname ,1,0
endl

 Spoiler

https://www.elitepvpers.com/forum/sro-pserver-guides-releases/3417910-release-improved-_add_item_extern-50x-100x-faster.html

[Judgelemental]

Why do you copy paste stuff expecting it to work without checking it beforehand?

[MENTION=1059401]


What's with all of the MENTIONS?

Your code is full of them. That's why it doesn't work...

[Beba Army]

Originally Posted by Judgelemental

Why do you copy paste stuff expecting it to work without checking it beforehand?

[MENTION=1059401]


What's with all of the MENTIONS?

Your code is full of them. That's why it doesn't work...

In my db it doesnt shows mention.

[Judgelemental]

The first procedure has some errors (displayed by the SQL) because I also use it and I had to manually fix it.

Read the errors and fix it or post the screenshot of them here.

[Beba Army]

Not work but thanks anyway

[Judgelemental]

Originally Posted by Beba Army

Not work but thanks anyway

Post the SQL error here.

I use the same query and if I could make it work why couldn't you?

Here's mine. And yes, you have to manually create the LotteryTABLE properly

SRO_VT_LOG -> Programmability -> Stored Procedures -> AddLogItem. Change RefItemID to suit your item (make sure it's like a return scroll and you have more than 2 inventory spaces).

Operation 16 = if you want the item to stack - warning - it's exploitable
Operation 41 is safer but you cannot stack the lottery.

 Spoiler

if @RefID = 41818 and @ = 16)
begin--Usage:--exec _ADD_ITEM_EXTERN 'CharName','ItemsCodeName',Count,OptLvl
declare @cname1 varchar(64)
select @cname1 = CharName16 from SRO_VT_SHARD.dbo._Char where CharID = @CharID
declare @ int
declare @adet int
declare @ int
declare @ int
select @ = MAX(ID) FROM SRO_VT_SHARD .dbo._LotteryTABLE
select @ = Min(ID) FROM SRO_VT_SHARD .dbo._LotteryTABLE
declare @name varchar(64)
etik:
SELECT @ = (CONVERT(INT, RAND() * @ @+1))+ @))
select @name = CodeName128 from SRO_VT_SHARD.dbo._LotteryTABLE where ID = @
select @name = CodeName128 from SRO_VT_SHARD.dbo._LotteryTABLE where ID = @
print @
print @name
if(PATINDEX('%ITEM%' @name)>0)
begin
print 'not present'
end
else begin
print 'not present'
goto etik
end
exec SRO_VT_SHARD.dbo._ADD_ITEM_EXTERN @cname1 @name,1,0
end

[Beba Army]

Originally Posted by Judgelemental

Post the SQL error here.

I use the same query and if I could make it work why couldn't you?

Here's mine. And yes, you have to manually create the LotteryTABLE properly

SRO_VT_LOG -> Programmability -> Stored Procedures -> AddLogItem. Change RefItemID to suit your item (make sure it's like a return scroll and you have more than 2 inventory spaces).

Operation 16 = if you want the item to stack - warning - it's exploitable
Operation 41 is safer but you cannot stack the lottery.

 Spoiler

if @RefID = 41818 and @ = 16)
begin--Usage:--exec _ADD_ITEM_EXTERN 'CharName','ItemsCodeName',Count,OptLvl
declare @cname1 varchar(64)
select @cname1 = CharName16 from SRO_VT_SHARD.dbo._Char where CharID = @CharID
declare @ int
declare @adet int
declare @ int
declare @ int
select @ = MAX(ID) FROM SRO_VT_SHARD .dbo._LotteryTABLE
select @ = Min(ID) FROM SRO_VT_SHARD .dbo._LotteryTABLE
declare @name varchar(64)
etik:
SELECT @ = (CONVERT(INT, RAND() * @ @+1))+ @))
select @name = CodeName128 from SRO_VT_SHARD.dbo._LotteryTABLE where ID = @
select @name = CodeName128 from SRO_VT_SHARD.dbo._LotteryTABLE where ID = @
print @
print @name
if(PATINDEX('%ITEM%' @name)>0)
begin
print 'not present'
end
else begin
print 'not present'
goto etik
end
exec SRO_VT_SHARD.dbo._ADD_ITEM_EXTERN @cname1 @name,1,0
end

Yes have all tables created but dont work, thanks anyway.