[Release] Item Comparison System in VSRO - Late Halloween Gift

[ownkhan]

Originally Posted by kanift

why don't u guys use a custom class ?

 Spoiler

class sro_wstring
{
private:
int unk0;

union
{
wchar_t* m_wchContentPtr;
wchar_t m_wchContentBuffer[8];
};

int m_iLength;
int m_iMaxLength;

public:
sro_wstring()
{
}

sro_wstring(wchar_t* _Ptr)
{
assign(_Ptr);
}

void assign(wchar_t* _Ptr)
{
m_iLength = wcslen(_Ptr);
m_iMaxLength = wcslen(_Ptr);

if (m_iMaxLength < 8)
{
wcscpy_s(m_wchContentBuffer, _Ptr);
}
else
{
m_wchContentPtr = _Ptr;
}
}

const wchar_t* c_wstr()
{
return m_iMaxLength < 8 ? m_wchContentBuffer : *reinterpret_cast<wchar_t**>(m_wchContentBuffer);
}
};

 Spoiler

nice troll ALP

[sarkoplata]

class wstring05 {
public:
	wstring05(const wchar_t* cstr)
	{
		allocator = nullptr;
		reserved_size = size = wcslen(cstr);
		if (size < 8)
			memcpy(buffer, cstr, (size + 1) * sizeof(wchar_t));
		else
			p_buffer = cstr;
	}

	const wchar_t* cchar()
	{
		if (reserved_size > sizeof(buffer))
		{
			return p_buffer;
		}
		else
		{
			return buffer;
		}
	}

private:

	void *allocator;
	union {
		wchar_t buffer[8];
		const wchar_t* p_buffer;
	};

	int size;
	int reserved_size;
};

and I'm using this.

credits: stackoverflow

[kanift]

Originally Posted by sarkoplata

class wstring05 {
public:
	wstring05(const wchar_t* cstr)
	{
		allocator = nullptr;
		reserved_size = size = wcslen(cstr);
		if (size < 8)
			memcpy(buffer, cstr, (size + 1) * sizeof(wchar_t));
		else
			p_buffer = cstr;
	}

	const wchar_t* cchar()
	{
		if (reserved_size > sizeof(buffer))
		{
			return p_buffer;
		}
		else
		{
			return buffer;
		}
	}

private:

	void *allocator;
	union {
		wchar_t buffer[8];
		const wchar_t* p_buffer;
	};

	int size;
	int reserved_size;
};

and I'm using this.

credits: stackoverflow

i think u didnt pay attention to source (c&p is evil) size < 8 @ ctor but reversed_size > 8 @ cchar ? good bye to cchar when 8len in ctor

[sarkoplata]

well, you're right. just using the constructor to make wstring05's and passing them to sro functions, didn't even use that cchar(). saving the day with c&p

[Mr.Awesome1337]

Works, thank you.

[silkroadntc]

Does anyone help me

[Rixy*]

after into dll in sro_clinet not found any damage on weapons ? @HB

[Laag#82]

Originally Posted by Rixy*

after into dll in sro_clinet not found any damage on weapons ? @HB

How It Works: Hold ALT and put your mouse on the item in your inventory/npc/exchange..etc to compare to your equipped one on the tooltip.

[Rixy*]

Originally Posted by khaleed2010

How It Works: Hold ALT and put your mouse on the item in your inventory/npc/exchange..etc to compare to your equipped one on the tooltip.

Thank working

[omar125]

Originally Posted by #HB

Hey there,

Happy Halloween everyone, I know its like a couple of days late, but you know...

About: Straight to the topic, if you haven't heard about this system before, this is an ISRO system, that helps you for example compare the stats of a weapon in your inventory to the already equipped weapon.

So, it should tell you whether the weapon in your inventory is better/worse than the weapon you're equipping, decreasing your time calculating with it your eyes, haha..

How It Works: Hold ALT and put your mouse on the item in your inventory/npc/exchange..etc to compare to your equipped one on the tooltip.

Code Snippets:

void CIFSlotWithHelp::AppendAdvancedInfo(CIFHelperBubbleWindow* window)
{
	reinterpret_cast<void(__thiscall*)(CIFSlotWithHelp*, CIFHelperBubbleWindow*)>(0x0066FD60)(this, window);

	/*0: EQUIP_SLOT_HELM
	1: EQUIP_SLOT_MAIL,
	2: EQUIP_SLOT_SHOULDERGUARD,
	3: EQUIP_SLOT_GAUNTLET,
	4: EQUIP_SLOT_PANTS,
	5: EQUIP_SLOT_BOOTS,
	6: EQUIP_SLOT_WEAPON,
	7: EQUIP_SLOT_SHIELD or ARROW,
	9: EQUIP_SLOT_EARRING,
	10: EQUIP_SLOT_NECKLACE,
	11: EQUIP_SLOT_L_RING,
	12: EQUIP_SLOT_R_RING,
	*/

	short ALTState = GetKeyState(VK_MENU);
	if (ALTState == -127 || ALTState == -128) // ALT is hold
	{
		wchar_t buffer[45];
		std::wstring mymsg(L"\n       <<Comparison>>");
		UINT msgcolor = 0xFFEFDAA4; //No Difference: FFFEFEFF | Better: FFFFD953 | Worse: FFFF4A4A
		window->WriteLine(mymsg, 0, msgcolor, 0, 3);
		CSOItem* myitem = this->_CSOItem;
		CSOItem* curritem;

		switch (myitem->GetObjectData()->TID)
		{
			//...
		}
	}

Note: Some calculations are incorrect or the text is miss-written, I was working quick back when I was making this project, so you may do a little touches on your own
Note: Addresses above are done on VSRO 1.88
Note: Structures above are for VC80 libs, back when strings were 28 bytes.
Note: Always compile on Release!

License: Leaving a tiny credit by the code won't hurt.

Special thanks to: florian0

When i Press ALT Got Crashed ! any help ??

[#HB]

Originally Posted by omar125

When i Press ALT Got Crashed ! any help ??

Follow notes.

[omar125]

Originally Posted by #HB

Follow notes.

im usuing VC80 and VSRO188
*im was merge it with dev kit*

[kanka5252]

How we can use with sro_devkit?

[Mr Yuni ™]

How work ?

[kanka5252]

he always change florian0 project and we cant use this release with devkit -.-"

Share all steps how we can do it? If you share we can teach @HB