problem with Change Name Scroll

[devdash]

hi Elitepvpers guys
i have Change Name Scroll in my server and its working perfectly but its block the old name ,i want to make the old name free to use after using the scroll instead of blocking it , i noticed that some servers have it already , so i wonder if someone can share with me ,what should i edit to make it work like that...

thanks in advance.

[NorseGodTyr]

Go to SRO_VT_SHARD
to Procedure _RenameCharNameByID
and Edit / Replace

Insert is add new line
Update is edit old line

Original

insert _CharNameList values(@NewName, @charid)

to

UPDATE _CharNameList set CharName16 = @NewName where CharID = @CharID

or try this

UPDATE _CharNameList values(@NewName, @charid)

[devdash]

Originally Posted by mialuisa

Go to SRO_VT_SHARD
to Procedure _RenameCharNameByID
and Edit / Replace

Insert is add new line
Update is edit old line

thanks for your answer dude, iam going to try now and i will be back with results

Originally Posted by mialuisa

Go to SRO_VT_SHARD
to Procedure _RenameCharNameByID
and Edit / Replace

Insert is add new line
Update is edit old line

UPDATE _CharNameList set CharName16 = @ where CharID = @D
this one can be excuted but when i change the name the char crash before its appear, and i back to rename it again,
and the second one
UPDATE _CharNameList values @, @d)
, can't be excuted this error keeps pop up
Msg 156, Level 15, State 1, Procedure _RenameCharNameByID, Line 29
Incorrect syntax near the keyword 'values'.

[NorseGodTyr]

Originally Posted by alydandy

thanks for your answer dude, iam going to try now and i will be back with results



UPDATE _CharNameList set CharName16 = @ where CharID = @D
this one can be excuted but when i change the name the char crash before its appear, and i back to rename it again,
and the second one
UPDATE _CharNameList values @, @d)
, can't be excuted this error keeps pop up
Msg 156, Level 15, State 1, Procedure _RenameCharNameByID, Line 29
Incorrect syntax near the keyword 'values'.

wait i will check on my test server and search a result

so done
Add this

USE [SRO_VT_SHARD]
GO
/****** Object: StoredProcedure [dbo].[_RenameCharNameByID] Script Date: 18.04.2018 09:36:35 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO

-----------------------------------------------------------------------------------------------------

ALTER procedure [dbo].[_RenameCharNameByID]
@CharID int,
@NewName varchar(64)
as
if (not exists (select charid from _char where charid = @charid))
return -1
set xact_abort on
begin transaction
if (exists (select charid from _charnamelist with (updlock) where charname16 = @NewName))
begin
rollback transaction
return -3
end
declare @old_name varchar(64)
select @old_name = charname16 from _char where charid = @charid
update _char set charname16 = @NewName where charid = @charid
if (@@error <> 0 or @@rowcount = 0)
begin
rollback transaction
return -4
end
Delete _CharNameList where CharID = @charid
insert _CharNameList values(@NewName, @charid)
UPDATE _Char set NickName16 = @NewName where CharID = @CharID
UPDATE _CharNickNameList set NickName16 = @NewName where CharID = @CharID
UPDATE _Char set CharName16 = @NewName where CharID = @CharID
update _Friend set friendcharname = @NewName where friendcharid = @charid
update _GuildMember set charname = @NewName where charid = @charid
update _Memo set fromcharname = @NewName where fromcharname = @old_name
update _TrainingCampMember set charname = @NewName where charid = @charid
declare @cos_id int
declare cos_cursor cursor fast_forward for
select id
from _charcos
where ownercharid = @CharID
open cos_cursor
fetch next from cos_cursor into @cos_id
while( @@fetch_status = 0 )
begin
update _Items set CreaterName = @NewName
where ID64 in
(select ItemID from _InvCOS where COSID = @cos_id and ItemID > 0)
and CreaterName = @old_Name
if (@@error <> 0 )
begin
close cos_cursor
deallocate cos_cursor
rollback transaction
return -5
end
fetch next from cos_cursor into @cos_id
end
close cos_cursor
deallocate cos_cursor
declare pc_inv_cursor cursor fast_forward for
select it.Data
from _Inventory as inv join _Items as it on inv.ItemID = it.ID64
where
(inv.CharID = @CharID and inv.Slot >= 13 and inv.ItemID > 0) and
(it.Data <> 0) and
(exists (select top 1 ID from _RefObjCommon where ID = it.RefItemID and TypeID1 = 3 and TypeID2 = 2))
open pc_inv_cursor
fetch next from pc_inv_cursor into @cos_id
while( @@fetch_status = 0 )
begin
update _Items set CreaterName = @NewName
where ID64 in
(select ItemID from _InvCOS where COSID = @cos_id and ItemID > 0)
and CreaterName = @old_Name
if (@@error <> 0 )
begin
close pc_inv_cursor
deallocate pc_inv_cursor
rollback transaction
return -6
end
fetch next from pc_inv_cursor into @cos_id
end
close pc_inv_cursor
deallocate pc_inv_cursor
if (CHARINDEX('@', @old_name, 0) > 0)
begin
select * from _Char
where CharID = ''
end
commit transaction
return 1

i have tested more time work fine
this make Job Name and Char name as same name
and overwrite/delete all Old Names

[devdash]

Originally Posted by mialuisa

wait i will check on my test server and search a result

so done
Add this


i have tested more time work fine
this make Job Name and Char name as same name
and overwrite/delete all Old Names

i will try it now, and i will be back with results

[devdash]

Originally Posted by mialuisa

wait i will check on my test server and search a result

so done
Add this


i have tested more time work fine
this make Job Name and Char name as same name
and overwrite/delete all Old Names

after i select the char, the loading screen showup and before the character showup i get crash
this is the dump file

[devdash]

perfect its working now, i have a question now, how can i add this scroll as a second scroll
wish means i want to have both scrolls on my server
how can i do that? what should i change ? to make both not effecting each other

solved, thanks mialuisa really dude <3
best wishes in your life

close please

[#HB]

It's easy to do it, but it looks like you're a beginner..
Just make another procedure..

[devdash]

Originally Posted by #HB

It's easy to do it, but it looks like you're a beginner..
Just make another procedure..

iam trying to do that but error keeps pop up





solved.
close please