Show notifications via dll

[sonzenbi]

i'm trying add to dll , but crash .
what wrong ?
thx for any help

	const DWORD Blue = 0x0077B580;
	const DWORD Blue2 = 0x008C9C30;
	const DWORD Blue3 = 0x00EEDE90;

	void Game::Blue(const wchar_t* msg)
	{
		void* _ecx = SroPP::detail::MemoryHack::RefPtr<void*>(0x110F80C);
		__asm
		{
			push msg;
			mov ecx, Blue3;
			call Blue2;
			mov ecx, _ecx;
			push eax;
			call Blue;
		}
	}

[Laag#82]

PHP Code:

void CGInterface::ShowPinkNotify(std::wstring* msg)
{
    reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x00777BF0)(this, msg);
}

void CGInterface::ShowBlueNotify(std::wstring* msg)
{
    reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B580)(this, msg);
}

void CGInterface::ShowGreenNotify(std::wstring* msg)
{
    reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B5B0)(this, msg);
} 


PHP Code:

    void ShowPinkNotify(std::wstring* msg);
    void ShowBlueNotify(std::wstring* msg);
    void ShowGreenNotify(std::wstring* msg); 


[Piskota]

Originally Posted by khaleed2010

PHP Code:

void CGInterface::ShowPinkNotify(std::wstring* msg)
{
    reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x00777BF0)(this, msg);
}

void CGInterface::ShowBlueNotify(std::wstring* msg)
{
    reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B580)(this, msg);
}

void CGInterface::ShowGreenNotify(std::wstring* msg)
{
    reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B5B0)(this, msg);
} 


PHP Code:

    void ShowPinkNotify(std::wstring* msg);
    void ShowBlueNotify(std::wstring* msg);
    void ShowGreenNotify(std::wstring* msg); 


@ebi you may find @ 's
interesting

[sonzenbi]

thanks for helping me, but i want to know something wrong with my code .

[florian0]

Originally Posted by sonzenbi

thanks for helping me, but i want to know something wrong with my code .

The code doesn't look wrong, just not pretty.

Blue = CGInterface::ShowMessage_Warning
Blue2 = CTextStringManager::GetString
Blue3 = g_CTextStringManager
_ecx = g_pCGInterface

push msg;
mov ecx, g_tsm;
call GetString;
mov ecx, g_interface;
push eax;
call ShowMessage_Warning;

1. How are you calling it? What string are you putting into it? GetString only works for these UIIT_BLAH_BLAH-translation-tokens.

2. Can you run it in a debugger and check where it crashes (address and stack)?

[sonzenbi]

Originally Posted by florian0

The code doesn't look wrong, just not pretty.

Blue = CGInterface::ShowMessage_Warning
Blue2 = CTextStringManager::GetString
Blue3 = g_CTextStringManager
_ecx = g_pCGInterface

push msg;
mov ecx, g_tsm;
call GetString;
mov ecx, g_interface;
push eax;
call ShowMessage_Warning;

1. How are you calling it? What string are you putting into it? GetString only works for these UIIT_BLAH_BLAH-translation-tokens.

2. Can you run it in a debugger and check where it crashes (address and stack)?

Sadly, I have no knowledge of C ++ maybe a little bit
The only thing I can do was try again and again
I sent the source code to you via private messenger, it would be better if you see it.
Thank you for spending the time helping me

[florian0]

GetString only works with these UIIT_BLAH_BLAH. You are passing a string that should be displayed to it. Thats not going to work.

const wchar_t* killmsg = Convert(" [ " + killname + " ] " + " §· KÕt LiÔu " + " [ " + Mobname + " ] ");
SroPP::Game::Blue((killmsg));

If the string given to GetString is not found in the translation database, an empty string is returned. But that shouldn't crash your client. No idea why it happens unless you open your client in x32dbg and check where it crashes.

Anyhow: ShowMessage_Warning expects a std::wstring in VC80's ABI format. You need to put your message into that structure and pass it to ShowMessage_Warning. Using GetString is not going work for you in this case.

[sonzenbi]

It seems, i'm having trouble with the basic knowledge
I will try to take advantage of your suggestions

[florian0]

Originally Posted by sonzenbi

It seems, i'm having trouble with the basic knowledge
I will try to take advantage of your suggestions

I made a guide for handling strings in Silkroad:

Maybe this helps you understanding strings.