[Euphoria Dev Team Release] Illegal Linking Detection

[nubness]

Hello everybody,

As we're all well aware of the fact that illegal linking is still possible, I come with a good solution which will help server admins in fighting this issue. It is not the best solution, yet, it is a good one, and it guarantees that the exploiter will get caught, and banned if the admin wants it.

First of all, you need a new table in the PS_GameLog database, which will store all the necessary information about all the illegal linking attempts that take place. The table can be easily created by running the following query:

USE PS_GameLog

CREATE TABLE Illegal_Lapis_Link_Log (
	
	RowID INT IDENTITY(1,1),
	UserUID INT NOT NULL,
	UserID VARCHAR(20) NOT NULL,
	CharID INT NOT NULL,
	CharName VARCHAR(20) NOT NULL,
	ItemUID BIGINT NOT NULL,
	ItemID INT NOT NULL,
	ItemName VARCHAR(50) NOT NULL,
	ItemLevel INT NOT NULL,
	LapisID INT NOT NULL,
	LapisName VARCHAR(50) NOT NULL,
	LapisLevel INT NOT NULL,
	LinkSucess BIT NOT NULL, 
	ActionTime DATETIME NOT NULL	
)

The next step is modifying usp_Insert_Action_Log_E to make it detect the illegal linking the very second it happens.

Simply add the following lines inside the PS_GameLog.dbo.usp_Insert_Action_Log_E stored procedure:

IF (@ActionType = 119)
BEGIN
	DECLARE @ItemLevel TINYINT = (SELECT Reqlevel FROM PS_GameDefs.dbo.Items WHERE ItemID = @Value2)
	DECLARE @LapisLevel TINYINT = (SELECT ReqInt FROM PS_GameDefs.dbo.Items WHERE ItemID = @Value3)
	IF (@ItemLevel < @LapisLevel)
	BEGIN
		INSERT INTO Illegal_Lapis_Link_Log VALUES (@UserUID, @UserID, @CharID, @CharName, @Value1, @Value2, @Text1, @ItemLevel, @Value3, @Text2, @LapisLevel, @Value7, @ActionTime)
		--UPDATE PS_UserData.dbo.Users_Master
		--SET Status = -5
		--WHERE UserUID = @UserUID
	END
END

You need to place this code between

IF(LEN(@dd) = 1)
BEGIN
	SET @dd = '0' + @dd
END

and

SET @Sql = N'
INSERT INTO PS_GameLog.dbo.ActionLog

As you see, I've commented 3 lines, which ban the account of the player who attempted illegal linking. Uncomment them if you want the player to get banned.

NOTE : This will detect the linking attempt regardless of whether it was successful or not.

Enjoy !

[[Admin]ßІί†ž]

Thanks for the fix man. This fixes the problem when players do this :

Test that exploit on your server , results may surprise you what players are doing :P

As ever, thanks for another nice release.

[Psycnosis]

very nice! would there be a way to auto delete the items if they trade them? cos that's really all they have to bypass this cos it bans the player that links it not the player that use the item.

this will automatically take care o 90% of this problem though

[nubness]

Yes, it's possible, edit it to look like this:

IF (@ActionType = 119)
BEGIN
	DECLARE @ItemLevel TINYINT = (SELECT Reqlevel FROM PS_GameDefs.dbo.Items WHERE ItemID = @Value2)
	DECLARE @LapisLevel TINYINT = (SELECT ReqInt FROM PS_GameDefs.dbo.Items WHERE ItemID = @Value3)
	IF (@ItemLevel < @LapisLevel)
	BEGIN
		INSERT INTO Illegal_Lapis_Link_Log VALUES (@UserUID, @UserID, @CharID, @CharName, @Value1, @Value2, @Text1, @ItemLevel, @Value3, @Text2, @LapisLevel, @Value7, @ActionTime)
		--UPDATE PS_UserData.dbo.Users_Master
		--SET Status = -5
		--WHERE UserUID = @UserUID
		DELETE FROM PS_GameData.dbo.CharItems WHERE ItemUID = @Value1
	END
END

[abrasive]

Nice! I feel like this may also be an appropriate time to automatically kick the user our of the game so they never have a change to trade it, or drop it on the ground or whatever.

[Psycnosis]

how would you do that Abrasive? cant kick a user with sql need to send a command to the console..

[abrasive]

Originally Posted by Psycnosis

how would you do that Abrasive? cant kick a user with sql need to send a command to the console..

You can do it like this (using nubness's last example):

IF (@ActionType = 119)
BEGIN
	DECLARE @ItemLevel TINYINT = (SELECT Reqlevel FROM PS_GameDefs.dbo.Items WHERE ItemID = @Value2)
	DECLARE @LapisLevel TINYINT = (SELECT ReqInt FROM PS_GameDefs.dbo.Items WHERE ItemID = @Value3)
	IF (@ItemLevel < @LapisLevel)
	BEGIN
		INSERT INTO Illegal_Lapis_Link_Log VALUES (@UserUID, @UserID, @CharID, @CharName, @Value1, @Value2, @Text1, @ItemLevel, @Value3, @Text2, @LapisLevel, @Value7, @ActionTime)
		--UPDATE PS_UserData.dbo.Users_Master
		--SET Status = -5
		--WHERE UserUID = @UserUID
		DELETE FROM PS_GameData.dbo.CharItems WHERE ItemUID = @Value1
		-- Force user out of the game by causing an SQL error.
		UPDATE Fail SET Fail = 1;
	END
END

[nubness]

We've already discussed this, Abrasive, causing an error in the session by executing some unreal SQL instructions is not a good option as it results in a rollback, which may affect some of the things that happened with that particular account.

[infinite59]

Originally Posted by [Admin]ßІί†ž

Thanks for the fix man. This fixes the problem when players do this :

Test that exploit on your server , results may surprise you what players are doing :P

As ever, thanks for another nice release.

That's right, but for ppl that use the so called "ep6 server files", there isen't any problems like this. Linking rate for "illegal lapis" is 0% when they try it.

[GM.Triest]

****... Blitz discovered how I got linked on Exile...



(jk)

[[ADM]SpyRow]

Originally Posted by Psycnosis

how would you do that Abrasive? cant kick a user with sql need to send a command to the console..

or also 1 thing
find the charname and setup his loginstatus to 0 he will get out from the game

[{Skrillex}]

Originally Posted by [ADM]SpyRow

or also 1 thing
find the charname and setup his loginstatus to 0 he will get out from the game

lol, this doesn´t work.

[nubness]

Originally Posted by [ADM]SpyRow

or also 1 thing
find the charname and setup his loginstatus to 0 he will get out from the game

I had a good chuckle over that one.

Again : The databases have no influence on the game course itself, it simply stores data, permanently.

[infinite59]

Originally Posted by nubness

We've already discussed this, Abrasive, causing an error in the session by executing some unreal SQL instructions is not a good option as it results in a rollback, which may affect some of the things that happened with that particular account.

This can cause rollback on the account, +/- 20 minutes rollback to be honnest but meh, if the player tryed to exploit the server he got punished, that's all.

[abrasive]

Originally Posted by [ADM]SpyRow

or also 1 thing
find the charname and setup his loginstatus to 0 he will get out from the game

This would be the equivalent of telling yourself the user is logged out, while they are still logged in.