Quote:
Originally Posted by smoka95
Im happy to see this tool finaly working, however in this release the bug which would cause the replaced skill to dissappear from the skill list alltogether. i will give the example that ive given the first time:
You want to replace skill A with skill B, after thats done Skill A is gone for good and you cannot work with it in any way
|
That is an unfortunate side effect of replacing skills for a particular job - especially when they are specific to that job (Like the priest's almighty). Where do you put the displaced skill?
Skills (and their levels) do not include the id of the job or race that can use it. The way the editor (and the Rohan client) know skills are related to a race or job is 100% driven via the job id in the skill tree entries. Each entry contains a job id, skill and a child skill along with a couple points numbers. That's all. The way the Editor and Rohan itself understands these skills is by using the job id in the skill tree and fetching the appropriate skills for it. The skills are the things you can do. the skill tree is the strings that tie them all together in a usable way.
I will need to think about what to do with the skills that are orphaned when you change them - especially between editing sessions (serializing). There will be a update later that has something in place for dealing with it.
------- edit rather than create a double post ----------
I've solved the issue of skills lost after editing a skill tree. Skills that are displaced when editing a skill tree are now placed in an "orphan" list. This list persists between editing sessions and are loaded into the race's skills whenever you enter the skill tree editor. The GitHub repository has been updated with this addition.
Credit for finding this goes to @
With this update I am going to leave it like this as it seems to have enough functionality to get you going. If there is something you want changed about it, feel free to have at it while I move on to other things.
Cheers!
