[OpenNos] Dupe/Crash Fix-Collection

[XV50]

Hello guys,
in this Thread i wanted to release some Crash/Dupe fixes.
It really bothers me that the community has grown that weak that each and every Server is getting attacked by any chance.

NOTE!
Please PM me on Discord, if you found a crash/dupe which should be fixed, and i will fix it asap and release it here.
Also if there's a fix or bug.

Discord: XV50#1233

[12.07.2021] Gold-Drop Dupe

 Spoiler

How can you trigger it?
When activating Auto-Loot, some Monsters have a Drop in the Drop Table, which adds Gold as Item to your Inventory. 
When dropping this Gold from your Inventory, and picking up again, you directly have the maximum amount of gold.

The Fix:
Search for Gold Drops in the Drop Table. If it has the ItemVNum 1046, it is what i was talking about. It should be one.

[x.Hunter.x]

Instead of deny a drop of a vnum you should just check the drop / get thing instead of that

[PenguinXD]

As well, in Raids there are of course Golddrops, wouldn't that be dumb? So for RaidInstances you should deactivate it.

You could as well check the Golddrop when it's an unusual value? For example 1kkk as Drop.

That should be a better solution

[XV50]

Originally Posted by PenguinXD

As well, in Raids there are of course Golddrops, wouldn't that be dumb? So for RaidInstances you should deactivate it.

You could as well check the Golddrop when it's an unusual value? For example 1kkk as Drop.

That should be a better solution

I made a small accident because i was tired, will fix it later on. Its just another if for the players inventory

[PenguinXD]

Originally Posted by XV50

I made a small accident because i was tired, will fix it later on. Its just another if for the players inventory

I did it very quickly



go to "GameObject -> Character.cs"

"_handleItemDrop "

  if (drop.Amount > 1000000000 && drop.ItemVNum == 1046)
                    {
                        Session.SendPacket(UserInterfaceHelper.GenerateInfo($"Abuse"));
                        return;
                    }

and ur gucci

[XV50]

Originally Posted by PenguinXD

I did it very quickly



go to "GameObject -> Character.cs"

"_handleItemDrop "

  if (drop.Amount > 1000000000 && drop.ItemVNum == 1046)
                    {
                        Session.SendPacket(UserInterfaceHelper.GenerateInfo($"Abuse"));
                        return;
                    }

and ur gucci

Thank you very much, BUT, that's just not right. It happens when the character drops it. HandleItemDrop is the Monster drop. I was right with the DropPacket, i just forgot an if.
You can block the Drop completely, or stop the character from dropping it and forcing him to destroy it

PS: the Character gets the Gold as item into his inventory because of the drop. It's not an abuse to get it when Autoloot is active, it's not even an abuse to drop it. It's just 1 Monster who can drop Gold as Item directly into the inventory, and when dropping this Gold from the inventory you get instant Max. Gold. So the Drop Amount in that case cant be more than 9999

[ZroIsHere]

Originally Posted by XV50

Hello guys,
in this Thread i wanted to release some Crash/Dupe fixes.
It really bothers me that the community has grown that weak that each and every Server is getting attacked by any chance.

NOTE!
Please PM me on Discord, if you found a crash/dupe which should be fixed, and i will fix it asap and release it here.
Also if there's a fix or bug.

Discord: XV50#1233

[12.07.2021] Gold-Drop Dupe

 Spoiler

How can you trigger it?
When activating Auto-Loot, some Monsters have a Drop in the Drop Table, which adds Gold as Item to your Inventory. 
When dropping this Gold from your Inventory, and picking up again, you directly have the maximum amount of gold.

The Fix:
Search for Gold Drops in the Drop Table. If it has the ItemVNum 1046, it is what i was talking about. It should be one.

Put the warehouse (u have a list in character.cs that say all the items that u have, when u spamming in the warehouse deposit and withdraw packets, and this do that the item are duplicated)

[Zanouu]

What the hell i can read here,

The " Auto-loot " is handled with GiftAdd so just add a simple check here

//

You can do like Official ( 1 Gold coins = 90k gold received )
Or just block it

[XV50]

Originally Posted by Zanouu

What the hell i can read here,

The " Auto-loot " is handled with GiftAdd so just add a simple check here

//

You can do like Official ( 1 Gold coins = 90k gold received )
Or just block it

Thanks Sherlock, that's what i explained

[October's Very Own]

Originally Posted by XV50

Thanks Sherlock, that's what i explained

No you did not.