Updated GWA2

cortexio · 05/28/2020, 12:08

I created some patternScans, maybe this will help.

Code:

SetValue('SalvageFunction', '0x' & Hex(GetScannedAddress('ScanSalvageFunction', -10), 8))
SetValue('SalvageGlobal', '0x' & Hex(MemoryRead(GetScannedAddress('ScanSalvageGlobal', 1) - 0x4), 8))

Code:

_('ScanSalvageFunction:')
AddPattern('33C58945FC8B45088945F08B450C8945F48B45108945F88D45EC506A10C745EC7E')
_('ScanSalvageGlobal:')
AddPattern('8B5104538945F48B4108568945E88B410C578945EC8B4110528955E48945F0')

Be sure to delete the old lines SetValue(... and _('Scan... for SalvageFunction & SalvageGlobal

If it still doesnt work, let me know. Maybe i changed something, but forgot about it.

Proof:

NiliyaFlamme · 05/28/2020, 14:23

my game still crash i have change the lines soo idk xD
maybe u can upload your fixed gwa2
i got this gwa2 maybe i have some wrong

cortexio · 05/28/2020, 14:39

I noticed the forum is putting random spaces in the code that i posted and i cant edit them out >_<
In your GWA2, there's a "ScanSalvageGloba l" instead of "ScanSalvageGlobal"

NiliyaFlamme · 05/28/2020, 14:46

i have change to ScanSalvageGlobal but still crash

maybe u can upload your fixed gwa2

NiliyaFlamme · 05/28/2020, 16:19

sorry but it still crash idk why xD

maril15 · 05/28/2020, 16:34

Quote:

Originally Posted by cortexio

Code:

_('ScanSalvageFunction:')
AddPattern('558BEC83EC14A154B1870033C58945FC8B45088945F08B450C8945F48B45108945F88D45EC506A10C745EC7E')
_('ScanSalvageGlobal:')
AddPattern('8B5104538945F48B4108568945E88B410C578945EC8B4110528955E48945F0')

I tried to investigate the problem encountered by Niliya and it seems that I'm able to find back the ScanSalvageGlobal pattern as a unique occurence in the Hex of the game but i'm unable to find any occurence of your ScanSalvageFunction pattern. So i'm guessing that this last pattern is wrong.

cortexio · 05/28/2020, 18:04

Quote:

Originally Posted by maril15

I tried to investigate the problem encountered by Niliya and it seems that I'm able to find back the ScanSalvageGlobal pattern as a unique occurence in the Hex of the game but i'm unable to find any occurence of your ScanSalvageFunction pattern. So i'm guessing that this last pattern is wrong.

You are correct. There was an address in the pattern, so it only worked on my PC obviously >_<

Sorry for that, here's the correct pattern that should work everywhere.

Code:

_('ScanSalvageFunction:')
AddPattern('33C58945FC8B45088945F08B450C8945F48B45108945F88D45EC506A10C745EC7E')

Code:

SetValue('SalvageFunction', '0x' & Hex(GetScannedAddress('ScanSalvageFunction', -10), 8))

ss1100 · 05/28/2020, 18:57

What are you using to test, if not with a bot? One of the issues I've had is reallllly slow QA because i have to setup a toon in a position to test things in order to do so. Is there an easier/faster way to test?

NiliyaFlamme · 05/28/2020, 19:25

now gw close if i want start salv no err or so xD

list comprehension · 05/28/2020, 20:18

Quote:
Originally Posted by cortexio
You are correct. There was an address in the pattern, so it only worked on my PC obviously >_<

Sorry for that, here's the correct pattern that should work everywhere.
Code:
_('ScanSalvageFunction:')
AddPattern('33C58945FC8B45088945F08B450C8945F48B45108945F88D45EC506A10C745EC7E')
Code:
SetValue('SalvageFunction', '0x' & Hex(GetScannedAddress('ScanSalvageFunction', -10), 8))

I haven't checked the pattern or functionality but a pattern that long is prone to break with an update. I recommend finding a much smaller pattern even if it takes a larger offset to avoid patches breaking it so easily.

corey54321 · 05/28/2020, 21:24

I got this script to work so far still need to figure out how to get it to recognize the merchant and chest to buy kits and use storage functions

buy the basic 25 use salvage kits and it will salvage until it runs out of kits until the npc issues can be fixed will salvage whites and like trophy items like dark remains and stuff

cortexio · 05/28/2020, 22:30

Fix for UseHeroSkill

Code:

	_('CommandUseHeroSkill:')
	_('mov ecx,dword[eax+8]')
	_('push ecx')
	_('mov ecx,dword[eax+c]')
	_('push ecx')
	_('mov ecx,dword[eax+4]')
	_('push ecx')
	_('call UseHeroSkillFunction')
	_('add esp,C')
	_('ljmp CommandReturn')

Code:

SetValue('UseHeroSkillFunction', '0x' & Hex(GetScannedAddress('ScanUseHeroSkillFunction', -0x59), 8))

Code:

_('ScanUseHeroSkillFunction:')
AddPattern('BA02000000B954080000')

NiliyaFlamme · 05/28/2020, 23:35

Quote:

Originally Posted by corey54321

I got this script to work so far still need to figure out how to get it to recognize the merchant and chest to buy kits and use storage functions

buy the basic 25 use salvage kits and it will salvage until it runs out of kits until the npc issues can be fixed will salvage whites and like trophy items like dark remains and stuff

now all my bot´s salv ty for the work

NiliyaFlamme · 05/28/2020, 23:42

if u find new pattern for ScanTraderHook it will make me happy ( need it for buy ectos etc)

corey54321 · 05/29/2020, 00:25

I think the GetAgentByName() function is broken that seems to be what is going on to make it work in any town.

I got it to work in eye of the north will salvage and buy kits and withdraw gold from chest if needed.

You can change lines

Code:

24 ZoneMap(642) ; to the town you want 
128 	GoNearestNPCToCoords(-2748.00, 1019.00) ; to the merchant in the same town of your choice