Disable GM Private Shop

[Peww.]

How to disable GMs from opening private shop?

[QuietSmoke]

Originally Posted by Peww.

How to disable GMs from opening private shop?

If you're talking about vendors, then:

WndVendor.cpp, in function CWndVendor::OnChildNotify

Below:

			if(prj.IsInvalidName(strVendor)
#ifdef __RULE_0615
			   || prj.IsAllowedLetter(strVendor, TRUE) == FALSE
#endif
			   )
			{
				g_WndMng.OpenMessageBox(_T(prj.GetText(TID_DIAG_0020)));
				return TRUE;
			}

Add:

			if(!g_pPlayer->IsAuthorization(AUTH_GENERAL))
			{
				g_WndMng.OpenMessageBox("The administrator is forbidden to open a private shop.");
				return TRUE;
			}

[ZeroTwo02]

lol no. Don't make a CLIENT side verification for that...

In the function "CDPSrvr::OnPVendorOpen"

after

	CUser* pUser	= g_UserMng.GetUser( dpidCache, dpidUser );
	if( IsValidObj( pUser ) )
	{

add

if ( pUser->m_dwAuthorization > AUTH_HELPER )
	return;

[Drabur]

Originally Posted by QuietSmoke

If you're talking about vendors, then:

WndVendor.cpp, in function CWndVendor::OnChildNotify

Below:

			if(prj.IsInvalidName(strVendor)
#ifdef __RULE_0615
			   || prj.IsAllowedLetter(strVendor, TRUE) == FALSE
#endif
			   )
			{
				g_WndMng.OpenMessageBox(_T(prj.GetText(TID_DIAG_0020)));
				return TRUE;
			}

Add:

			if(!g_pPlayer->IsAuthorization(AUTH_GENERAL))
			{
				g_WndMng.OpenMessageBox("The administrator is forbidden to open a private shop.");
				return TRUE;
			}

wow you talk about quality of code in another thread and then something?

[QuietSmoke]

Originally Posted by Drabur

wow you talk about quality of code in another thread and then something?

What do u mean?

If you mean checking on the client side, this will not give any advantages to ordinary players, and if you fix the change of rights through CE, then there will be no problems

[Drabur]

Originally Posted by QuietSmoke

What do u mean?

If you mean checking on the client side, this will not give any advantages to ordinary players, and if you correct the change of rights through CE, then there will be no problems

ordinary players? this is a prevention for pushing gms
it is very possible that they will try bypass it

[QuietSmoke]

Originally Posted by Drabur

ordinary players? this is a prevention for pushing gms
it is very possible that they will try bypass it

If you could put 1 cycle to check the player’s credentials, then this is impossible to get around

[cookie69]

@ they are right, never trust the client xd
Always do the check in client side and in server side otherwise it is easy to bypass that client side check.

[QuietSmoke]

Originally Posted by cookie69

@ they are right, never trust the client xd
Always do the check in client side and in server side otherwise it is easy to bypass that client side check.

I know that they are right and do not deny it
I understand that I was mistaken
But in any case, for example, it will work for me in the client, because the protection is good

[Avalion]

Originally Posted by QuietSmoke

If you could put 1 cycle to check the player’s credentials, then this is impossible to get around

Eh, still can be bypassed?

[QuietSmoke]

Originally Posted by Avalion

Eh, still can be bypassed?

The cycle is yes.
But not full protection for prohibiting changes to the Auth variable

[cookie69]

Originally Posted by QuietSmoke

The cycle is yes.
But not full protection for prohibiting changes to the Auth variable

No, never trust the client! Don't even try to find arguments.

[QuietSmoke]

Originally Posted by cookie69

No, never trust the client! Don't even try to find arguments.

I know about that, but thanks for the reminder