[Help] Penya buy bug

aoyamananami · 05/01/2020, 15:45

I encounter a penya buy bug, i vend on privateshop and set the price to 1b , and i use another/dual account to buy it and my vendor receive 2b. Does anyone have this fix please help.

FIorist · 05/01/2020, 23:43

Quote:

Originally Posted by aoyamananami

I encounter a penya buy bug, i vend on privateshop and set the price to 1b , and i use another/dual account to buy it and my vendor receive 2b. Does anyone have this fix please help.

I'm not sure, but you may have the AddGold string duplicated somewhere at MoverItem.cpp

Try checking this file and finding an extra line in it:
MoverItem.cpp

Code:

m_pOwner->AddGold(pItemBase->m_nCost * nNum);

aoyamananami · 05/01/2020, 23:51

Quote:
Originally Posted by Zzz..
I'm not sure, but you may have the AddGold string duplicated somewhere at MoverItem.cpp

Try checking this file and finding an extra line in it:
MoverItem.cpp
Code:
m_pOwner->AddGold(pItemBase->m_nCost * nNum);

Ill try this,for now ive just disabled the price on penya, by editing the max exceed of selling price from 2.1b to 1penya so theh cant sell item using penya then they obligate to sell item using other currency.

Edit
Like what youve said, ive seen the duplicated, thank you very much, i didnt even see that duplicate. Now it will never x2 if they buy it . Thanks again

Ecrypter · 05/02/2020, 00:12

Quote:

Originally Posted by aoyamananami

I encounter a penya buy bug, i vend on privateshop and set the price to 1b , and i use another/dual account to buy it and my vendor receive 2b. Does anyone have this fix please help.

i've encounter this before but its fix. this is the issue of player own shop right? .

aoyamananami · 05/02/2020, 01:15

Quote:

Originally Posted by Ecrypter

i've encounter this before but its fix. this is the issue of player own shop right? .

Yses, known as privateshop.

Ecrypter · 05/02/2020, 16:28

Quote:

Originally Posted by aoyamananami

Yses, known as privateshop.

Go to your MoverItem.cpp in _common folder

find :

PHP Code:


			
#ifdef __WORLDSERVER

#include "user.h"

extern    CUserMng            g_UserMng;

#endif    // WORLDSERVER

Change to this

PHP Code:


			
#ifdef __WORLDSERVER

#include "user.h"

#include "DPDatabaseClient.h"

extern    CUserMng            g_UserMng;

extern  CDPDatabaseClient   g_dpDBClient;

#endif    // WORLDSERVER

leave this part

PHP Code:


			
            cBuyItem.m_nItemNum = nNextPrice;

            if( !m_pOwner->CreateItem( &cBuyItem ) )

                g_dpDBClient.SendQueryPostMail( m_pOwner->m_idPlayer, NULL, cBuyItem, NULL, "Shop Item", "Your items." );

look this:

PHP Code:


			
    pBuyer->AddGold( -( pItemBase->m_nCost * nNum ) );

    m_pOwner->AddGold( pItemBase->m_nCost * nNum );

Change to this:

PHP Code:


			
//    pBuyer->AddGold( -( pItemBase->m_nCost * nNum ) );

//    m_pOwner->AddGold( pItemBase->m_nCost * nNum );

aoyamananami · 05/02/2020, 20:01

Quote:

Originally Posted by Ecrypter

Go to your MoverItem.cpp in _common folder

find :

PHP Code:

#ifdef __WORLDSERVER #include "user.h" extern    CUserMng            g_UserMng; #endif    // WORLDSERVER

Change to this

PHP Code:

#ifdef __WORLDSERVER #include "user.h" #include "DPDatabaseClient.h" extern    CUserMng            g_UserMng; extern  CDPDatabaseClient   g_dpDBClient; #endif    // WORLDSERVER

leave this part

PHP Code:

            cBuyItem.m_nItemNum = nNextPrice;             if( !m_pOwner->CreateItem( &cBuyItem ) )                 g_dpDBClient.SendQueryPostMail( m_pOwner->m_idPlayer, NULL, cBuyItem, NULL, "Shop Item", "Your items." );

look this:

PHP Code:

    pBuyer->AddGold( -( pItemBase->m_nCost * nNum ) );     m_pOwner->AddGold( pItemBase->m_nCost * nNum );

Change to this:

PHP Code:

//    pBuyer->AddGold( -( pItemBase->m_nCost * nNum ) ); //    m_pOwner->AddGold( pItemBase->m_nCost * nNum );

Like what i said above i already fixed it