[Release] Free FFXIV Fishing bot. Works with 2.5.1

[LuckOnCooldown]

Originally Posted by xphacter

I havent had a chance to look through your code yet, however I am getting the unable to parse hotbars issue again, even without cross hotbars.

Maybe have an option, if unable to parse hotbars, make it default to work like the old program, and 1 2 3 4

Same for you. And yes, I'm probably going to be adding a configurable key section if this continues to be a problem.

Please keep in mind though, that I did say in the original post that I'm sure there are edge cases that I've missed, due to not having several different machines and characters to test it on. I also said this is pre alpha code.

I promise, if you just bear with me, I will get all of these things worked out!

[onupees]

i did , and got the same unable to prase hotbars !
[9:49:48] Bot Started!
[9:49:49] Bot stopped!
let me know how to gather more info about the problem

[LuckOnCooldown]

Originally Posted by Kynian

[4:44:03] Casting fishing line!
[4:44:03] Expected status 'Casting' or 'Fishing', but got: 'Not Fishing'
[4:44:03] Bot stopped

That's when i try to use it. I press the start button and the "2" key on my hotbar flashes. My "2" key is set to Hook, so it never casts.

So I tried to put my Cast command on my 2 and pressed start, and it worked. Until something actually got hooked. The bot then attempted to use my "2" key again and the fish got away.

Before i was having the "Unable to parse hotbars" problem. I restarted the game and that seemed to solve it. I have no idea how to solve this "using same key command" problem though, and I'm no programmer.

If it helps at all, I play on steam, and my game isnt installed on C at all, it's on a completely different partition, F:\

Help me out please.

Can you give me a screenshot of your hotbars? Or describe them in detail? Something like
Hotbar 1: Cast [1] Hook [2] Mooch [3] ...

For all your hotbars, where the number in between the [] is the hotkey assigned to that action.

Also, IIRC, steam often modifies the games they sell, and it may just not work at all on steam. It doesn't matter where it's installed though.

Ok, anybody still having issues with parsing hotbars, please post screenshots of your hotbars and hotbar settings for me.

I will attempt to duplicate your exact setup and see if I can reproduce the issues.

Thanks!

[Kynian]

*update*

I did the following and it's now working *ALMOST* perfectly.

I went to the place i wanted to fish, switched class to fisher, logged out.
Logged back in, opened fishing bot, clicked start and it worked.

I stayed around looking at it to see if everything would work. After around 15 casts i got an HQ fish, but the bot did not mooch. How do I get it to work?

I'm trying to catch a double mooch fish here.

My hotbars are as follow:

Bar 1 - Cast[1], Hook[2], Cast Light [3], Quit[4], (empty space), Stealth[R]

Bar 2 - Bait[Shift+1], Mooch[Shift+2], Release[Shift+3]

[onupees]

it worked for me now
got another problem
Expected status 'Casting' or 'Fishing', but got: 'Not Fishing'
i am Fishing at Skull Valley
Using '' Halcyon Rod Supra ''
and using '' Crab Ball '' as bait

[Bulletheart]

Hi,

when i will start the bot, i become these message:

"Unable to find one ore more offsets!"

What´s wrong?? I can´t finde the Problem.....

[LuckOnCooldown]

Originally Posted by Kynian

*update*

I did the following and it's now working *ALMOST* perfectly.

I went to the place i wanted to fish, switched class to fisher, logged out.
Logged back in, opened fishing bot, clicked start and it worked.

I stayed around looking at it to see if everything would work. After around 15 casts i got an HQ fish, but the bot did not mooch. How do I get it to work?

I'm trying to catch a double mooch fish here.

My hotbars are as follow:

Bar 1 - Cast[1], Hook[2], Cast Light [3], Quit[4], (empty space), Stealth[R]

Bar 2 - Bait[Shift+1], Mooch[Shift+2], Release[Shift+3]

So, two things, was the FFXIV window focused, meaning, was it in the foreground, or was the bot window focused? You have Mooch on a key with a modifier. For that to work, the game window MUST be the active window.

Secondly, are you sure the HQ fish you caught is part of a mooch chain? They aren't all moochable.

Originally Posted by onupees

it worked for me now
got another problem
Expected status 'Casting' or 'Fishing', but got: 'Not Fishing'
i am Fishing at Skull Valley
Using '' Halcyon Rod Supra ''
and using '' Crab Ball '' as bait

Did the bot actually cast then give you that message? If so, I probably just need to up the delay before I check for a successful cast.

Originally Posted by Bulletheart

Hi,

when i will start the bot, i become these message:

"Unable to find one ore more offsets!"

What´s wrong?? I can´t finde the Problem.....

Are you using the english game client? No offense, but you don't sound like English is your first language, and it currently only works with the english client.

[LuckOnCooldown]

Onupees, try this build. I upped that delay I was talking about. I'm pretty sure that's all that was going on with yours.

[onupees]

Originally Posted by LuckOnCooldown

Onupees, try this build. I upped that delay I was talking about. I'm pretty sure that's all that was going on with yours.

Now it work perfectly , i will try the mooch soon i will let you know my feed back , btw you are amazing

[tomhanks123]

Okay, something really strange happened, so i tried using your new version and this happened.
I wasn't able to parse the hotbars, tried the fix before where I logout and log back in. Was then able to parse the hotbars but got the below results.

[1:04:22] Bot Started!
[1:04:22] Casting fishing line!
[1:04:42] You got a bite!
[1:04:48] You caught a Gysahl Greens!
[1:04:49] Bot stopped!

Obviously, that's incorrect, it didn't try to hook anything either. Also, strange enough, I had to change the cast hook and mooch key to 2,3,4 instead of the original 1,2,3 to even get it to cast else it would get the message "Expected status 'Casting' or 'Fishing', but got: 'Not Fishing'" similar to a few others above. So I figured maybe it might be the new version, tried an older version I had of your program and same thing so I thought maybe if I complete restart the client it will work (ffxiv)

Yup, that fixed it. Everything fishes and works fine So I guess sometimes, only a complete restart will get it working. Very strange. Maybe some things just move a bit over time as you leave your client on for awhile. i'll test out the timer soon, give you feedback on whether it's working .

Mooching is working fine for me btw.

Update: Timer also works :3

Some more feedback on the unable to parse hotbar issue. It seems it doesn't happen from map changing, I tried changing classes, using some skills, killing a few mobs, and I come back and fishing is still ok. I tried, turning off program killing a few mobs, turning on program, switching back to fisher, still works fine. I tried changing maps, reopening program and still works fine.

Now, I have a suspicion that it will stop working if I enter an instance (dungeon,trials etc). Will update you on it once I try it.

Update 2: Okay, so it is the instances I think, so I went in an instance, when I came out I still had program open, tried it and I was able to cast ( forgot to check if it still hooked though). HOWEVER, i closed it and reopened again and then I got the unable to parse hotbar error. So it seems going into instances screws up something. I presume at this point, if I logged out and logged back in without closing the client, I could get the unable to parse message to disappear but would have the resultant problem I stated at the start of this post.

[LuckOnCooldown]

Originally Posted by tomhanks123

Okay, something really strange happened, so i tried using your new version and this happened.
I wasn't able to parse the hotbars, tried the fix before where I logout and log back in. Was then able to parse the hotbars but got the below results.

[1:04:22] Bot Started!
[1:04:22] Casting fishing line!
[1:04:42] You got a bite!
[1:04:48] You caught a Gysahl Greens!
[1:04:49] Bot stopped!

Obviously, that's incorrect, it didn't try to hook anything either. Also, strange enough, I had to change the cast hook and mooch key to 2,3,4 instead of the original 1,2,3 to even get it to cast else it would get the message "Expected status 'Casting' or 'Fishing', but got: 'Not Fishing'" similar to a few others above. So I figured maybe it might be the new version, tried an older version I had of your program and same thing so I thought maybe if I complete restart the client it will work (ffxiv)

Yup, that fixed it. Everything fishes and works fine So I guess sometimes, only a complete restart will get it working. Very strange. Maybe some things just move a bit over time as you leave your client on for awhile. i'll test out the timer soon, give you feedback on whether it's working .

Mooching is working fine for me btw.

Update: Timer also works :3

Some more feedback on the unable to parse hotbar issue. It seems it doesn't happen from map changing, I tried changing classes, using some skills, killing a few mobs, and I come back and fishing is still ok. I tried, turning off program killing a few mobs, turning on program, switching back to fisher, still works fine. I tried changing maps, reopening program and still works fine.

Now, I have a suspicion that it will stop working if I enter an instance (dungeon,trials etc). Will update you on it once I try it.

Update 2: Okay, so it is the instances I think, so I went in an instance, when I came out I still had program open, tried it and I was able to cast ( forgot to check if it still hooked though). HOWEVER, i closed it and reopened again and then I got the unable to parse hotbar error. So it seems going into instances screws up something. I presume at this point, if I logged out and logged back in without closing the client, I could get the unable to parse message to disappear but would have the resultant problem I stated at the start of this post.

There's a lot of good info man! Thanks! I'll check it out and see if I reproduce the issue that way. As far as the Gysahl greens thing, I know what that is. The spot that I'm reading the fish name from will have an item name on occasion. Especially if you mouse over things in your inventory while you're fishing. I'm looking for another way to get fish name to to keep that from happening, but really, I think the only reliable way to get it is going to be from the chat log, and I had major problems with that. Maybe I'll go back to it at some point. As it stands now, it's not that big of a deal.

Just so everyone knows, the reason why I'm resistant to using static buttons instead of parsing the hotbars is, there are only 3 ways to reliably tell if I can mooch:

1) Check to see if the mooch button is enabled (this is what I'm doing now)
2) Keep a database of all possible fish that can be mooched from, including their position in a mooch chain. This is a maintenance nightmare, and not worth doing.
3) Parse the chatlog information.

#1 requires me to parse the hotbar information. And if I'm doing that, I might as well grab the keybind while I'm there. There's just no point in doing anything else.

I simply am NOT doing #2. That information can possibly change every update. The reason why I'm using signature scanning to start with is so that the bot is resilient to updates.

I wouldn't be totally against #3, but I spent several hours working on figuring out the chat log, and couldn't get it to work, so I decided to go with the hotbar route.

So, you see, it's not as simple as just deciding to use 1, 2, 3, and 4, or even adding an option to use those keys. If I do that, I break mooching.

With your help, I'm confident that I can figure out the hotbar parsing issues, and I appreciate all the feedback you guys have given me so far.

Thanks!

[tomhanks123]

Originally Posted by LuckOnCooldown

There's a lot of good info man! Thanks! I'll check it out and see if I reproduce the issue that way. As far as the Gysahl greens thing, I know what that is. The spot that I'm reading the fish name from will have an item name on occasion. Especially if you mouse over things in your inventory while you're fishing. I'm looking for another way to get fish name to to keep that from happening, but really, I think the only reliable way to get it is going to be from the chat log, and I had major problems with that. Maybe I'll go back to it at some point. As it stands now, it's not that big of a deal.

Just so everyone knows, the reason why I'm resistant to using static buttons instead of parsing the hotbars is, there are only 3 ways to reliably tell if I can mooch:

1) Check to see if the mooch button is enabled (this is what I'm doing now)
2) Keep a database of all possible fish that can be mooched from, including their position in a mooch chain. This is a maintenance nightmare, and not worth doing.
3) Parse the chatlog information.

#1 requires me to parse the hotbar information. And if I'm doing that, I might as well grab the keybind while I'm there. There's just no point in doing anything else.

I simply am NOT doing #2. That information can possibly change every update. The reason why I'm using signature scanning to start with is so that the bot is resilient to updates.

I wouldn't be totally against #3, but I spent several hours working on figuring out the chat log, and couldn't get it to work, so I decided to go with the hotbar route.

So, you see, it's not as simple as just deciding to use 1, 2, 3, and 4, or even adding an option to use those keys. If I do that, I break mooching.

With your help, I'm confident that I can figure out the hotbar parsing issues, and I appreciate all the feedback you guys have given me so far.

Thanks!

Glad my info can help improved your program. As far as the hotbars go, I think everyone is comfortable with whatever option you think is best. I can tell you however that another bot I have tried used a much more primitive and direct approach to the mooching. Basically, they will always hit the mooch button regardless if the fish is moochable, if it's not moochable, then it will automatically cast. (so after a hook, it will hit mooch and then immediately hit cast so if there is a mooch it will mooch, if there is nothing to mooch it will cast as normal).

An even earlier approach to this was by the previous author of the ffxiv fishing bot where we made a macro where mooch always came before cast. That way only two buttons needed to be pressed (mooch/cast macro and hook).

Regardless, I think your method is definitely working fine and argubly the more correct way to do it (if there was one lol) and at this point, it seems like there is just a few things needed to be ironed out.

After a bit more testing, I found that once you've had a fresh start of your client (ffxiv) and you turn on your fishing bot and never close it again, you should not encounter the unable to parse hotbar issue even after you've entered an instance. if you close the ffxiv fishing bot, then you will have to restart your ffxiv client.

Update: Found a new error, still fishing Gigant clams at Costa Sol, when a fish gets away, I get this error message:

[5:29:54] You got a bite!
[5:29:59] Index was outside the bounds of the array.
[5:29:59] Bot stopped!

Doesn't seem to happen with every fish that gets away though (which is weird) Maybe ignore this error for now. I'll give more info once I reproduce it more consistently.

Also, I think the option to turn off mooching doesn't work at the moment?

[LuckOnCooldown]

Originally Posted by tomhanks123

Glad my info can help improved your program. As far as the hotbars go, I think everyone is comfortable with whatever option you think is best. I can tell you however that another bot I have tried used a much more primitive and direct approach to the mooching. Basically, they will always hit the mooch button regardless if the fish is moochable, if it's not moochable, then it will automatically cast. (so after a hook, it will hit mooch and then immediately hit cast so if there is a mooch it will mooch, if there is nothing to mooch it will cast as normal).

An even earlier approach to this was by the previous author of the ffxiv fishing bot where we made a macro where mooch always came before cast. That way only two buttons needed to be pressed (mooch/cast macro and hook).

Regardless, I think your method is definitely working fine and argubly the more correct way to do it (if there was one lol) and at this point, it seems like there is just a few things needed to be ironed out.

After a bit more testing, I found that once you've had a fresh start of your client (ffxiv) and you turn on your fishing bot and never close it again, you should not encounter the unable to parse hotbar issue even after you've entered an instance. if you close the ffxiv fishing bot, then you will have to restart your ffxiv client.

Update: Found a new error, still fishing Gigant clams at Costa Sol, when a fish gets away, I get this error message:

[5:29:54] You got a bite!
[5:29:59] Index was outside the bounds of the array.
[5:29:59] Bot stopped!

Doesn't seem to happen with every fish that gets away though (which is weird) Maybe ignore this error for now. I'll give more info once I reproduce it more consistently.

Also, I think the option to turn off mooching doesn't work at the moment?

Seems weird, but it isn't. There are 6 different numbers that represent fishing, 7 different numbers that represent reeling. I'm pretty sure this issue is from some old code that I intended to remove, but didn't purge completely. I'll have a look, thanks!

Edit: Btw, you're right about the option to turn off mooching. I refactored some code around that section and broke it. It's fixed now, and will be included in the next update. I'm still trying to get my own hotbars to break.

Edit: I found the source of the Index out of bounds error above. There was a bug where in certain cases I didn't detect a lost fish properly, and it tried to read the fish name, which of course wasn't there, which resulted in me reading random junk from memory. It's fixed now, and will be in the next release.

[tomhanks123]

Originally Posted by LuckOnCooldown

Seems weird, but it isn't. There are 6 different numbers that represent fishing, 7 different numbers that represent reeling. I'm pretty sure this issue is from some old code that I intended to remove, but didn't purge completely. I'll have a look, thanks!

Edit: Btw, you're right about the option to turn off mooching. I refactored some code around that section and broke it. It's fixed now, and will be included in the next update. I'm still trying to get my own hotbars to break.

Edit: I found the source of the Index out of bounds error above. There was a bug where in certain cases I didn't detect a lost fish properly, and it tried to read the fish name, which of course wasn't there, which resulted in me reading random junk from memory. It's fixed now, and will be in the next release.

That's great to hear

I've started fishing on another computer but something strange was happening on there. It usually works fine but after awhile after a few successful attempts, I would encounter this error:

[11:25:35] Casting fishing line!
[11:25:36] Expected status 'Casting' or 'Fishing', but got: 'Fishing Stance'
[11:25:36] Bot stopped!

This error did not hook the fish before bot stopped. Is it something to do with the delay still being too short as I read before or hint to another issue?

Clicking start again starts it up again but then after a few more it runs into this error again. Restarting the client and ffxiv bot program does seem to significant reduce this from happening.

[jelio]

Wow, thanks for your great efforts so far. I'm happy you've used sig scanning and avoided writing to the game. Also, reading the hotbar data to get hotkeys is a nice touch.

I've got a few suggestions for features and a possible cause of a current bug. I haven't used the current version very much yet, so forgive me if some assumptions are wrong.


1. Multi client support.

I'm almost always running two characters at the same time, and I don't think the bot is built to handle this situation right now. It seems like an easy feature to add - add a drop down box with the list of running FFXIV process IDs to select, then behave as before. If I want to fish with two clients, I can just open one for each, then check that the process IDs are different.

If you don't know, you can log into two characters with one account by using a character on an NA server and another on a JP server.


2. Add more verbose log messages.

Especially during the early development stage, this could help with the debugging and double checking of animation states. It would also help us decide which tugs we should ignore - the current version doesn't give us this information.

A verbose log could include the following feedback of current state. Most of these are just to double check that all of the conditions are accounted for, and to know exactly under which conditions an unexpected event occurred, but the tug types will always be useful, and Reeling HQ/type is neat.

Quitting (Sitting)
Rod out / waiting (Sitting)
Casting (Sitting)
Tug (Light, Medium, Heavy) (Sitting)
Reeling (Light, Medium, Heavy?, Big Fish?) (High Quality) (Sitting)
Reeling failure (Sitting)
Releasing (Sitting)

Keeping track of these might also be useful for figuring out which delays to use for each animation type (some sitting animations are longer, for example).


3. Include tug type in the catch log.

This would be an easier way than the status log for us to keep track of which tugs we can't ignore when catching certain fish.


4. Double check all addresses after returning to the character select screen and logging into a different character.

Relogging a new character will currently cause the "Unable to parse hotbars" issue for me every time. This was also a problem in many versions of Nexus Light trackers. They didn't check for the new addresses after logging another character in.


5. Play the error sound and stop the bot when receiving chat message type 0x0050.

You may know that each log in the chat line has a type-byte associated with it, which lets you know whether it's a party line, tell received, tell sent, alliance chat, various different combat log types, system message, etc. Line type 0x0050 is a tell received from a GM. This would require you to develop the chat reading functionality, however. Perhaps you could use the FFXIV-APP source for reference.


6. Automatically start the bot when casting in-game.

I don't actually know if this bot does this or not, but it's the only way to start the Pyskador bot and it's a user friendly alternative to pushing the button on a separate window.


Finally, a minor suggestion which doesn't deserve its own number. I'd prefer it if the UI used native Windows elements. The custom skin is a bit tacky and buggy. The log scroll bar and status log itself flickers and disappears at times. I would have the window look something like a compacted uTorrent, and use the font it uses which is a bit more legible, and perhaps Courier New for the status log (or not). You could tuck away more options like automatically using Cast Light in a menu bar or under tabs as needed. Just some minor personal taste feedback. Kind regards.