[Release]Fixed Delete Character

[ryuchetval]

Ok. As title says here's a fixed delete character (I used the one that didn't allow you to remake the character and made it so that you can make another character) (5165)

go to Database.cs and search for

        public static void Dispose()

above / under that void put this

 public static void DeleteCharacter(string Charname, string AccName)
        {
            if (File.Exists(@"C:\OldCODB\Users\Characters\" + Charname + ".chr"))
                File.Delete(@"C:\OldCODB\Users\Characters\" + Charname + ".chr");
            if (File.Exists(@"C:\OldCODB\Users\" + AccName + ".usr"))
            {
                FileStream FS = new FileStream(@"C:\OldCODB\Users\" + AccName + ".usr", FileMode.Open);
                BinaryReader BR = new BinaryReader(FS);
                string RealPassword = Encoding.ASCII.GetString(BR.ReadBytes(BR.ReadByte()));
                string status = Encoding.ASCII.GetString(BR.ReadBytes(BR.ReadByte()));
                BR.Close();
                FS.Close();
                File.Delete(@"C:\OldCODB\Users\" + AccName + ".usr");
                FS = new FileStream(@"C:\OldCODB\Users\" + AccName + ".usr", FileMode.CreateNew);
                BinaryWriter BW = new BinaryWriter(FS);
                BW.Write(RealPassword);
                BW.Write(status);
                BW.Close();
                FS.Close();
            }
            
        }

go to PacketHandler.cs and search for

                                    case 99:

under / above that put this :

                                    case 95: //Delete Character
                                        {
                                            GC.Disconnect();
                                            Database.DeleteCharacter(GC.MyChar.Name, GC.AuthInfo.Account);
                                            break;
                                        }

+Thanks to me

[_Vodka]

Nice, but I guess this should have been posted in the release section (:

so #reported to request move

[12tails]

you forgot to make it read the Pasword data.... but nice ^^

[ryuchetval]

Originally Posted by 12tails

you forgot to make it read the Pasword data.... but nice ^^

what do you mean?
it reads it....and you can't delete the character if your not logged in

[pro4never]

Originally Posted by ryuchetval

what do you mean?
it reads it....and you can't delete the character if your not logged in

he means warehouse password: Aka what you have to enter when deleting the character.

[ryuchetval]

yes well that idk about that...i'm still a begginer at coding


EDIT: here is a possible solution (didn't test)

go to NPCDialog.cs and searc for

static string ReadString(byte[] Data)

make it

        public static string ReadString(byte[] Data)

then at packethandler.cs at case 95 put this

                                            string pass = PacketHandling.NPCDialog.ReadString(Data);
                                            if (pass == GC.MyChar.WHPassword)
                                            {
                                                GC.Disconnect();
                                                Database.DeleteCharacter(GC.MyChar.Name, GC.AuthInfo.Account);
                                            }
                                            else
                                                GC.LocalMessage(2005, "Wrong password!");

I didn't test it so idk if it works

[_DreadNought_]

uh why are u removing the account? It's a delete character

[ryuchetval]

couldn't make it replace the character with "" (as the client crashed) so i removed the acc and remade it

[_Vodka]

just disconnect, then delete file.

[ryuchetval]

if you just delete the character file then you wouldn't be able to login
the info in the account files is pass, status, character and character file is missing
by writing into the account file pass, status, "" it crashed the client idk why...as in the authenticate place if the character is "" it would take you to make a new character....but it crashes the client

[_Vodka]

I meant.

1. find wich char to delete + get info
2. disconnect
3. delete char + account file
4. create new acc

[copz1337]

I released something similar to this but this one is more advanced I guess because it disconnects the character lol.

[Arcо]

Originally Posted by copz1337

I released something similar to this but this one is more advanced I guess because it disconnects the character lol.

Yours didn't work
It deleted the character file, but inside the account file, the character still existed.

[copz1337]

Originally Posted by Аrco

Yours didn't work
It deleted the character file, but inside the account file, the character still existed.

And that is why I had also had an ACCOUNT cmd. So lol?

[ryuchetval]

this is useful for a public server not a server where you play by yourself and can make easily an account for you...