CoolEffect 5165 (impulse)

[U2_Caparzo]

emmm yes, this a noob release i know, but i'm starting to "work" in this source and i want to share somethings including when they are easy to do, so maybe u can help me to improve the code and improve my skills at coding

look for this in entity.cs

public Enums.ConquerAction Action

under the set statment (i dk how to call it :c)

HandleCoolEffect((Enums.ConquerAction)SpawnPacket[63]);

then add this where u want in entity.cs

        void HandleCoolEffect(Enums.ConquerAction action)
        {
            bool FullSuper = true;
            if (action != Enums.ConquerAction.Cool || Owner.Equipment.TryGetItem(3) == null)
                return;
            else
            {
                uint ID = Owner.Equipment.TryGetItem(3).ID;
                if (IsSuper(ID))
                {
                    Network.GamePackets.StringPacket stringPacket = new Network.GamePackets.StringPacket(true);
                    stringPacket.UID = this.UID;
                    stringPacket.Type = Network.GamePackets.StringPacket.Effect;
                    for (byte i = 1; i < 8; i++)
                    {
                        if (i == 7)
                            continue;
                        if (this.Owner.Equipment.TryGetItem(i) != null)
                        {
                            if (!IsSuper(this.Owner.Equipment.TryGetItem(i).ID))
                            {
                                FullSuper = false;
                                break;
                            }
                        }
                        else
                        {
                            FullSuper = false;
                            break;
                        }
                    }
                    switch (this.Class / 10 * 10)
                    {
                        case 10:
                            {
                                stringPacket.Texts.Add(FullSuper ? "warrior" : "warrior-s");
                                break;
                            }
                        case 20:
                            {
                                stringPacket.Texts.Add(FullSuper ? "fighter" : "fighter-s");
                                break;
                            }
                        case 45:
                            {
                                stringPacket.Texts.Add(FullSuper ? "archer" : "archer-s");
                                break;
                            }
                        case 50:
                            {
                                return;
                            }
                        case 130:
                        case 140:
                            {
                                stringPacket.Texts.Add(FullSuper ? "taoist" : "taoist-s");
                                break;
                            }
                    }
                    Owner.Send(stringPacket);
                }
            }
        }
        bool IsSuper(uint ID)
        {
            return (ID - 9) % 10 == 0;
        }

thanks for read

[Spirited]

This might help you in your switch statement:
this.Class / 10 * 10.

Also, instead of this:

if (FullSuper)
    stringPacket.Texts.Add("fighter");
else
    stringPacket.Texts.Add("fighter-s");

You could just do this:
stringPacket.Texts.Add(FullSuper ? "fighter" : "fighter-s");

[nTL3fTy]

You could also do it the proper way:

[U2_Caparzo]

Originally Posted by Fаng

This might help you in your switch statement:
this.Class / 10 * 10.

srry but i don't understand why
#EDIT ohhh i see, lol, 130-139 / 10 = 13 ^^ forgot that too :s

Originally Posted by Fаng

Also, instead of this:

if (FullSuper)
    stringPacket.Texts.Add("fighter");
else
    stringPacket.Texts.Add("fighter-s");

You could just do this:
stringPacket.Texts.Add(FullSuper ? "fighter" : "fighter-s");

totally forgot about that, thanks

Originally Posted by nTL3fTy

You could also do it the proper way:

i'll try, thanks too

#EDIT
updated.

[I don't have a username]

                    for (byte i = 1; i < 8; i++)
                    {
                        if (i == 7)
                            continue;

Can you see your mistake?

i < 8, that means your for loop will go up to when i is equal to 7
You're telling your loop to continue when i gets to 7, however there is nothing looped after that.

Just do:

                    for (byte i = 1; i < 7; i++)
                    {

[U2_Caparzo]

Originally Posted by I don't have a username

                    for (byte i = 1; i < 8; i++)
                    {
                        if (i == 7)
                            continue;

Can you see your mistake?

i < 8, that means your for loop will go up to when i is equal to 7
You're telling your loop to continue when i gets to 7, however there is nothing looped after that.

Just do:

                    for (byte i = 1; i < 7; i++)
                    {

Inventory = 0,
Head = 1,
Necklace = 2,
Armor = 3,
RightWeapon = 4,
LeftWeapon = 5,
Ring = 6,
Bottle = 7,
Boots = 8,

the mistake was that the number in the loop should be 9 :s