[Help]Check map of chars

[ryuchetval]

Hello....I would need some help in finding if there's any character on a map id like: (this is for LOTF 5165)

bool CharOnMap(MapId)
{
Character C;
C = Game.World.H_Chars[MapId]
if (C!=null)
return true;
else return false;
}

But I don't think this works so I want to know how I find out if the map contains at least 1 character...
Thanks

[_DreadNought_]

I'd do this.

public static bool CharsOnMap(int MapID)
{
foreach(GameClient Client in ConnectedClients.Values)
if (Client.Entity.MapID == MapID) { return true; } }
return false;
}

I didnt really understand what you wanted to do.

so just do if (CharsOnMap(MAPID)) or whatever and it'l work.

This just sees if there are ANY characters on the map specified.

[ryuchetval]

oh great thanks

[Basser]

Originally Posted by _DreadNought_

I'd do this.

public static bool CharsOnMap(int MapID)
{
foreach(GameClient Client in ConnectedClients.Values)
if (Client.Entity.MapID == MapID) { return true; } }
return false;
}

I didnt really understand what you wanted to do.

so just do if (CharsOnMap(MAPID)) or whatever and it'l work.

This just sees if there are ANY characters on the map specified.

I'll teach you Linq sometime. =)

[.Ocularis]

Oh how I love not even looking at loft anymore.

[ryuchetval]

yeah that's a good decision...

[Korvacs]

        public bool MapIsEmpty(int MapID)
        {
            GameClient Target = ConnectedClients.Values.Find((GameClient Client) => { return Client.Entity.MapID == MapID; });

            if (Target == null)
                return true;

            return false;
        }

Something like this would be best.

[ChingChong23]

or depending how your server is structured

public boolean playersOnMap(int mapID) {
return World.getMap(mapID).size() > 0;
}

[Syst3m_W1z4rd]

public bool AnyPlayersInMap(ushort MapID)//Since mapids are ushort
{
    int i = 0;
    foreach (Game.Character C in World.H_Chars.Values) {
        if (C.Loc.Map == MapID)
            i++; }

    if (i > 0)
        return true;

    return false;
}

public int PlayersInMap(ushort MapID)//Since mapids are ushort
{
    int i = 0;
    foreach (Game.Character C in World.H_Chars.Values) {
        if (C.Loc.Map == MapID)
            i++; }

    return i;
}

[_Emme_]

Originally Posted by 1337 H4X0R

public bool AnyPlayersInMap(ushort MapID)//Since mapids are ushort
{
    int i = 0;
    foreach (Game.Character C in World.H_Chars.Values) {
        if (C.Loc.Map == MapID)
            i++; }

    if (i > 0)
        return true;

    return false;
}

I'm not saying your method is good or not, but if you're doing it that way simply do:

public bool MapHasPlayers(ushort Map)
{
foreach(GameClient client in Kernel.GameClients)
 if(client.Entity.MapID == Map)
  return true;

return false
}

Might just stick in that I recommend a public dictonary for all spawned objects on the server, with that you could simply call something like this:

public bool MapHasPlayers(Maps map)
{
return (Kernel.Objects[map].Lenght > 0);
}

[ChingChong23]

Length - Wikipedia, the free encyclopedia