Arrow proficiency?

[Wolfy.]

I just noticed, when i attack with bow and arrow, it gives prof on the bow but gives prof too on some unknown proficiency? -Any idea how to see that prof id so i can make it not to give prof on that or any other solution? -Here is pic:

[InsomniacPro]

I would check your method that handles awarding proficiency experience. You're probably doing a check for a left hand weapon, as you would a trojan, then adding prof exp to that weapontype. Just make sure you do a check for trojan only if you are doing lefthand prof exp.

[Wolfy.]

Oh, good idea. I will try and post what i come up with. Thanks.

[Aceking]

Don't forget warrior's shield.

[Wolfy.]

I will do a:

if (Job == 45)
{
// Do nothing.
}
else
{
// Add prof. etc...
}

For the left hand.

[Spirited]

Bows have proficiency too, do they not? I would process weapon proficiency by the item group id. The player may be a reborn using a bow, or an archer using another weapon type, so the job check would be invalid.

[Aceking]

I agree with the above, it needs to have a validity check against the item group (static id / 10000?).

[Wolfy.]

Fak im stuck, i don't know what kind of check to add here:

        public void AddProfExp(ushort Wep, uint Amount)
        {
            if (Profs.Contains(Wep))
            {
                Prof P = (Prof)Profs[Wep];
                if (P.Lvl < 20)
                {
                    Profs.Remove(Wep);
                    Amount *= World.ProfExpRate;
                    P.Exp += Amount;
                    if (P.Exp >= Database.ProfExp[P.Lvl])
                    {
                        P.Lvl++;
                        P.Exp = 0;
                        MyClient.LocalMessage(2000, "Your proficiency level has increased.");
                    }
                    Profs.Add(Wep, P);
                    MyClient.AddSend(Packets.Prof(P));
                }
            }

[Aceking]

Originally Posted by Wolfy.

Fak im stuck, i don't know what kind of check to add here:

        public void AddProfExp(ushort Wep, uint Amount)
        {
            if (Profs.Contains(Wep))
            {
                Prof P = (Prof)Profs[Wep];
                if (P.Lvl < 20)
                {
                    Profs.Remove(Wep);
                    Amount *= World.ProfExpRate;
                    P.Exp += Amount;
                    if (P.Exp >= Database.ProfExp[P.Lvl])
                    {
                        P.Lvl++;
                        P.Exp = 0;
                        MyClient.LocalMessage(2000, "Your proficiency level has increased.");
                    }
                    Profs.Add(Wep, P);
                    MyClient.AddSend(Packets.Prof(P));
                }
            }

I would add a static list containing all the valid prof's based off their item group (first 3 digits).
I suppose you could also put it into a database table, but I see no need to spend the resources checking that table constantly considering those prof's should never change.

So it would be static id / 1000 (I have access to source now xD)
Then simply check if it is valid, then proceed.

And judging from your code below, it won't add a prof if they don't already have it?

[InsomniacPro]

Are you using NCS? In 2014?

[CptSky]

Originally Posted by Aceking

I would add a static list containing all the valid prof's based off their item group (first 3 digits). [...]

Read-only dynamic list created when loading items would be better

[Wolfy.]

@Aceking, CptSky: Thanks gonna try and see what i come up with.
@InsomniacPro: Yeah.

[InsomniacPro]

Originally Posted by Wolfy.

@InsomniacPro: Yeah.

Why? Dear ***, why?

[Wolfy.]

Don't ask plz, secret project very wow.

[InsomniacPro]

Originally Posted by Wolfy.

Don't ask plz, secret project very wow.

Don't take this the wrong way, but if you're using NCS, there's no wow involved.