[Suggestion] Reborn System (Blessed Items)

[littlechris95]

Hello guys! This is my code (Eternity NPC) to give random bless on items that have no bless. Is functioning perfectly, but I wonder if this has the best code, suggestions?

My Code:

 Spoiler

Dictionary<int, int> positions = new Dictionary<int,int>();
                                                                        for (uint pos = 0; pos <= 18; pos++)
                                                                        {

                                                                            if (pos != 12)
                                                                            {
                                                                                if (!client.Equipment.Free(pos))
                                                                                {
                                                                                    var item = client.Equipment.TryGetItem(pos);

                                                                                    if (item != null && item.Bless == 0)
                                                                                    {
                                                                                        positions.Add((int)item.Position, (int)item.Position);
                                                                                    }
                                                                                }
                                                                            }
                                                                        }
                                                                        if (positions.Count > 0)
                                                                        {
                                                                            int rand = Kernel.RandFromGivingNums(positions.Values.ToArray());
                                                                            var item = client.Equipment.TryGetItem((uint)positions[rand]);
                                                                            item.Bless = 1;
                                                                            item.Mode = Kijo_Online_V3.Game.Enums.ItemMode.Update;
                                                                            item.Send(client);
                                                                            Database.ConquerItemTable.UpdateBless(item);
                                                                            client.Send(new Message(String.Format("Your {0} was blessed with -1 damage.", Kernel.GetItemInfo(item.ID).Name), Color.Red, Message.Talk));
                                                                        }
                                                                        else
                                                                        {
                                                                            client.Send(new Message("You lose blessing because you have all items blessed.", Color.Red, Message.Talk));
                                                                        }

[abdoumatrix]

 Spoiler

List<uint> Objects = new List<uint>();
foreach (var item in client.Equipment.Objects)
if (item.Bless == 0)
Objects.Add(item.UID);
var itex = Objects[(int)Kernel.Random.Next(Objects.Count) - 1];
client.Equipment.Objects[itex].Bless = 7;
break;

[U2_Caparzo]

LINQ may be useful, something like hero.InventoryPool.Any((item) => item.Bless == 0)