Classic[4267] Warehouse items

[Mr_PoP]

the Warehouse items is not showing correctly here is the packet structure :-

    public class WarehousePacket : TQPacket
    {
        int offset = 16;
        public WarehousePacket(int count)
            : base(PacketType.Warehouse, (ushort)(16 + (count * 20)))
        {
            // WriteByte(9, 10);
            WriteUInt32(12, (uint)count);
        }

        public uint NPCId
        {
            get
            {
                return ReadUInt32(4);
            }
            set
            {
                WriteUInt32(4, value);
            }
        }

        public void AppendItem(uint uid, uint type, byte sock1, byte sock2, byte plus, byte bless, byte enchant, byte color)
        {
            WriteUInt32(offset, uid); offset += 4;
            WriteUInt32(offset, type); offset += 5;
            WriteByte(offset, sock1); offset++;
            WriteByte(offset, sock2); offset += 3;
            WriteByte(offset, plus); offset++;
            WriteByte(offset, bless); offset++;
            offset += 1;
        }
}

and am showing it like this ->

        void SendWarehouseItems(uint warehousId)
        {
            IWarehouse ware = hero.Warehouses[warehousId];
            WarehousePacket pack = new WarehousePacket(ware.Count);
            pack.NPCId = warehousId;
            foreach (IItem pitem in ware.Items)
            {
                pack.AppendItem(pitem.Id, pitem.TypeId, pitem.FirstSocket, pitem.SecondSocket, pitem.Composition, pitem.Bless, 0, 0);
                
            }
            Send(pack);
        }

problem is items seems like mixed up , I can't see what am doing wrong here!

[Mr_PoP]

Originally Posted by Y u k i

what do you mean with mixed up?

it's Icons becomes one , so like if I put Arrow,club,sword , they look like arrow,arrow,arrow lol

[Mr_PoP]

Originally Posted by Y u k i

pitem.Id, pitem.TypeId probably a stupid question but are you sure one of those is acctually the UID?

pitem.Id = UID
pitem.TypeId = SataticId(itemtype)

[Korvacs]

I have no idea where you got that structure from but, its definitely not correct.

[Mr_PoP]

Originally Posted by Korvacs

I have no idea where you got that structure from but, its definitely not correct.

       WriteUInt32(offset, uid);
            WriteUInt32(offset + 4, type);
            WriteByte(offset + 9, sock1);
            WriteByte(offset + 10, sock2);
            WriteByte(offset + 13, plus);
            offset += 16;

I did follow your structure and same issue!

[Korvacs]

Are you still allocating 20 bytes per item instead of 16 in the Length?

[Mr_PoP]

Originally Posted by Korvacs

Are you still allocating 20 bytes per item instead of 16 in the Length?

nope

public WarehousePacket(int count)
            : base(PacketType.Warehouse, (ushort)(16 + (count * 16)))
        {
            WriteUInt32(12, (uint)count);
        }

[Korvacs]

Is your Itemtype the 4267 version? Or is it a more modern one, basing this off the fact that this is obviously a conversion or a hack/slashed together source.

[Mr_PoP]

Originally Posted by Korvacs

Is your Itemtype the 4267 version? Or is it a more modern one, basing this off the fact that this is obviously a conversion or a hack/slashed together source.

well the source is 4283 , but all the packets seems same as 4267 , not sure tho! maybe this causing this issue !

[Korvacs]

If your packet structure is exactly how it is on the wiki then it must be an issue somewhere else, I use that structure in the 4267 source I'm working on. Its definitely the correct structure.

I would change the itemtypes over.

[Mr_PoP]

Originally Posted by Korvacs

If your packet structure is exactly how it is on the wiki then it must be an issue somewhere else, I use that structure in the 4267 source I'm working on. Its definitely the correct structure.

I would change the itemtypes over.

the itemtypes is exactly the same as 4267, they just introduced a new UI , all the packets seems the same as 4267!

[Korvacs]

Well, then you know that its something else, socket system perhaps, who knows. This is the problem with conversions.

[Mr_PoP]

Originally Posted by Korvacs

Well, then you know that its something else, socket system perhaps, who knows. This is the problem with conversions.

in that version there was no damage/enchant yeah?

[Korvacs]

Correct.

[Mr_PoP]

Originally Posted by Korvacs

Correct.

Ight here is the right structure for 4283... if you wanna update your wiki

packet length = 16 + ( count * 20 )
appending items start on offset = 16;

UId->(offset,uint) 
ItemType->(offset + 4 , uint)
Ident(not sure)->(offset + 1 , byte)
Socket1->(offset + 1 , byte)
Socket2->(offset + 1 , byte)
UnKown->(offset + 1, byte)
Effect(not sure)->(offset + 1 , byte)
Compostion->(offset + 1 , byte)
Damage->(offset + 1 , byte)
UnKown2->(offset + 1 , byte)
Enchant->(offset + 1 , byte)
UnKnownBytes->(offset + 3 , byte)

if I figured what those unkown bytes for, will tell you.