Troubles with pure skills

[derpingson]

Hello, i've been trying to add pure skills to my Archer Master npc,
CODE 1

 Spoiler

PHP Code:

/* this one gives the skill only to pure archers, but doesn't have (you already know this skill*/
 case 40:
                                {
                                    if (client.Entity.Class == 45 && client.Entity.FirstRebornClass == 45 && client.Entity.SecondRebornClass == 45)
                                    {

                                        client.AddSpell(LearnableSpell(10313));
                                        dialog.Text("Congratulations! you have learned StarArrow.");
                                        dialog.Option("Thank you.", 255);
                                        dialog.Send();
                                    }
                                    else
                                    {
                                        dialog.Text("You are not allowed, I think your not promoted yet or your not pure Archer.");
                                        dialog.Option("Thank you.", 255);
                                        dialog.Send();
                                    }
                                    break;
                                } 


CODE 2:

 Spoiler

PHP Code:

/*this one gives the spell to all archers even if i put that only pure archers are allowed*/
case 40:
                                {
                                    if (client.Entity.Class == 45 && client.Entity.FirstRebornClass == 45 && client.Entity.SecondRebornClass == 45)
                                    {
                                        if (!client.AddSpell(LearnableSpell(10313)))
                                        {
                                            dialog.Text("You already know this skill.");
                                            dialog.Option("Thank you master.", 255);
                                            dialog.Send();
                                            break;
                                        }
                                        dialog.Text("Congratulations! you have learned StarArrow.");
                                        dialog.Option("Thank you.", 255);
                                        dialog.Send();
                                    }
                                    else
                                    {
                                        dialog.Text("You are not allowed, I think your not promoted yet or your not pure Archer.");
                                        dialog.Option("Thank you.", 255);
                                        dialog.Send();
                                    }
                                    break;
                                } 


the difference between the 2 codes is

PHP Code:

if (!client.AddSpell(LearnableSpell(10313))) 


can you please help me? i'm confused

[pro4never]

Not sure how the addspell method works in your source but there's a bit of poor logic involved here. Lets map it out.


You have 3 possible conditions


#1: You already know the skill.
#2: You qualify for the skill.
#3: You do not qualify for the skill.


Condition one is the simplest to check for. We just need to know if we already know the skill.

Condition two is a touch more difficult because we have to run a number of comparisons (current class, previous class, etc). Still pretty simple.



So... we end up with logic that flows something like...

if(user.KnowsSkill(skillID))
{	
	//Tell user they already know skill
}
else
{
	if(is pure archer)
	{
		//Learn the skill
	}
	else
	{
		//Tell them they don't qualify
	}
}

[-Sensei-]

Chang the checker to..

If(client.entity.reborn >= 2)
{
dial;og here.
}



Dont use this,, this only checks for reborn ^^.. I missunderstood something :>..

[go for it]

Originally Posted by -Sensei-

Chang the checker to..

If(client.entity.reborn >= 2)
{
dial;og here.
}

If(client.entity.reborn >= 2)
{
dialog here.
}

that check if the account is second reborn

if (client.Entity.Class == 45 && client.Entity.FirstRebornClass == 45 && client.Entity.SecondRebornClass == 45) 
                                    { 
dialog;
                                    }

but this check if the account is archer and was pure archer


back on topic
what confuse you is

                                        if (!client.AddSpell(LearnableSpell(10313))) 
                                        { 
                                            dialog.Text("You already know this skill."); 
                                            dialog.Option("Thank you master.", 255); 
                                            dialog.Send(); 
                                            break; 
                                        }

native trinity base doesn't have learnablespell method but AddSpell is a bool which add the spell if it failed return false
so your code will work pretty much the same if you removed learnablespell method

                                        if (!client.AddSpell(10313)) 
                                        { 
                                            dialog.Text("You already know this skill."); 
                                            dialog.Option("Thank you master.", 255); 
                                            dialog.Send(); 
                                            break; 
                                        }

but anyway you don't even need this check or this dialog , just treat him as he don't have the spell all the time , but if it false : the user won't get any notification

[derpingson]

the "you already know this skill isn't important" so i made this

PHP Code:

 case 30:
                                {

                                    if (client.Entity.Reborn >= 2 && client.Entity.SecondRebornClass >= 22 && client.Entity.SecondRebornClass <= 25 && client.Entity.Class >= 22 && client.Entity.Class <= 25 && client.Entity.FirstRebornClass >= 22 && client.Entity.FirstRebornClass <= 25)
                                        {
                                            Interfaces.ISkill spell = new Conquer_Online_Server.Network.GamePackets.Spell(true);
                                            spell.ID = 10311;
                                            client.AddSpell(spell);
                                            dialog.Text("Congratulations! you have learned Perseverance.");
                                            dialog.Option("Thank you.", 255);
                                            dialog.Send();
                                        }
                                        else
                                        {
                                            dialog.Text("You are not allowed, I think you're not promoted yet or you're not pure Warrior.");
                                            dialog.Option("Thank you.", 255);
                                            dialog.Send();
                                        }                
                                    break;
                                } 


but it still gives the skill to any 2rb warrior, WTH i'm doing wrong!!!!

[go for it]

about

                                    if (client.Entity.Reborn >= 2 && client.Entity.SecondRebornClass >= 22 && client.Entity.SecondRebornClass <= 25 && client.Entity.Class >= 22 && client.Entity.Class <= 25 && client.Entity.FirstRebornClass >= 22 && client.Entity.FirstRebornClass <= 25)

no warrior can reborn until first , second reb class is 25 , so you got useless check over there
replace it with

if (client.Entity.Class > 21 && client.Entity.Class < 26 && client.Entity.FirstRebornClass == 25 && client.Entity.SecondRebornClass == 25)

add break point on this check and run , open the database , figure out what's wrong , but this should work fine

[pro4never]

Why does no one use enumerated jobs? There's a reason TQ numbered them the way they did.


JobType = job / 10
JobLebel = job % 10


You can now enumerate them if you wish or create helper method (isWarrior, isArcher, etc)

There's no need for such... extensive (and expensive) logical checks)

[derpingson]

i was a bit curious about how other sources are handling this, so i got a 5672 one and i found something i couldn't understand

dialogs.Text("You have learned the XP Skills.");
dialogs.Option("Thank you master.", 0xff);
dialogs.Send();
client.AddSpell(LearnableSpell(0x456));
client.AddSpell(LearnableSpell(0x3f7));

why are the IDs like this "0x3f7"? i mean all the source is based on these numbers & letters

if someone knows what are these, i'm dying to know lol

[go for it]

this "numbers and letters" are hex
i see it pointless to use hex in such cases
you can simply convert that values to dec from windows calculator (view ~> programmer) , or you can google it or use calculator
anyway here is the formula
Hexadecimal - Wikipedia, the free encyclopedia



that piece of code you provide is not complete

dialogs.Text("You have learned the XP Skills.");
dialogs.Option("Thank you master.", 0xff);
dialogs.Send();
[B]the 3 above sending npc dialog to the client with one option of 255 which do nothing
[/B]client.AddSpell(LearnableSpell(0x456));
client.AddSpell(LearnableSpell(0x3f7));
[B]this add spell to the client , and most likely learnablespell is a method with checks for each skill but im not sure cuz i duno what source you working at[/B]

[derpingson]

thank you very much

it was useful to me,

thank you all