Weird code

[miketheking]

well would some1 tell me why this code gives me an error saying that not all code patterns returns a value while i think all of them do

public static Game.Location getfreemobcoord(ushort X, ushort Y, ushort Spread)
        {
            Game.Location loc = new Game.Location();
            loc.X = (ushort)Program.Rnd.Next(X, X + Spread);
            loc.Y = (ushort)Program.Rnd.Next(Y, Y + Spread);
            foreach (Game.NPC npc in Game.World.H_NPCs.Values)
            {
                if (npc.Loc.Equals(loc))
                {
                    return getfreemobcoord(X, Y, Spread);
                }
                else
                {
                    foreach (Game.Mob mon in Game.World.H_Mobs.Values)
                    {
                        if (mon.Loc.Equals(loc))
                        {
                            return getfreemobcoord(X, Y, Spread);
                        }
                        else
                        {
                            return loc;
                        }
                    }
                }
            }
        }

[_DreadNought_]

Originally Posted by miketheking

well would some1 tell me why this code gives me an error saying that not all code patterns returns a value while i think all of them do

public static Game.Location getfreemobcoord(ushort X, ushort Y, ushort Spread)
        {
            Game.Location loc = new Game.Location();
            loc.X = (ushort)Program.Rnd.Next(X, X + Spread);
            loc.Y = (ushort)Program.Rnd.Next(Y, Y + Spread);
            foreach (Game.NPC npc in Game.World.H_NPCs.Values)
            {
                if (npc.Loc.Equals(loc))
                {
                    return getfreemobcoord(X, Y, Spread);
                }
                else
                {
                    foreach (Game.Mob mon in Game.World.H_Mobs.Values)
                    {
                        if (mon.Loc.Equals(loc))
                        {
                            return getfreemobcoord(X, Y, Spread);
                        }
                        else
                        {
                            return loc;
                        }
                    }
                }
                [B]return null;//or 0?[/B]
            }
        }

.

[_tao4229_]

Wrong, its saying that if that collection World.H_NPC.Values or whatever is empty, the foreach wont execute once and therefore the method will end without returning anything.

[-Shunsui-]

by the way this that you are doing is poor, i recommend using Kinshi's TinyMap server for your source, it helps as well with this you are doing

[_DreadNought_]

Originally Posted by _tao4229_

Wrong, its saying that if that collection World.H_NPC.Values or whatever is empty, the foreach wont execute once and therefore the method will end without returning anything.

So yea my code would fix that. You are correct tho.

Should note my code I put in is mis-placed, move it to somewhere after the foreach loop.

[BaussHacker]

Originally Posted by _DreadNought_

.

Why would you return it at first? Then it would loop one time and return. It should be outside the foreach loop.

[_DreadNought_]

Was a mistake since I did it in this tiny quick reply thingy. Look at the post above yours