[HELP] Problem with BigInteger class

[12tails]

Heya!

DON'T POST STUPID ANSWERS! I REALLY WANT HELP!

For handle the new effects into client its a value with 128bits now...
so like a friend (pro4ever) said, i builded the BigInteger class with some search help heh

and now i'm getting a problem while trying to set it to a bitarray... so i would ask some help with it...

Let's check the codes.

The BitInteger class start with a string value like:

BigInteger Test = new BigInteger(Update.Flags.Cyclone.ToString(), 16);

"What is the 16?" is the max bitarray length..

so to build the bitarray i'm doing this:

    public byte[] BuildBytes()
    {
        int Bits = Count();

        int Bytes = Bits >> 3;
        if ((Bits & 0x7) != 0)
            Bytes++;

        byte[] result = new byte[Bytes];

        int pos = 0;
        uint tempVal, val = data[dataLength - 1];

        if ((tempVal = (val >> 24 & 0xFF)) != 0)
            result[pos++] = (byte)tempVal;
        if ((tempVal = (val >> 16 & 0xFF)) != 0)
            result[pos++] = (byte)tempVal;
        if ((tempVal = (val >> 8 & 0xFF)) != 0)
            result[pos++] = (byte)tempVal;
        if ((tempVal = (val & 0xFF)) != 0)
            result[pos++] = (byte)tempVal;

        for (int i = dataLength - 2; i >= 0; i--, pos += 4)
        {
            val = data[i];
            result[pos + 3] = (byte)(val & 0xFF);
            val >>= 8;
            result[pos + 2] = (byte)(val & 0xFF);
            val >>= 8;
            result[pos + 1] = (byte)(val & 0xFF);
            val >>= 8;
            result[pos] = (byte)(val & 0xFF);
        }

        return result;
    }

well them, you ask:"But what's the problem??"

i'm sending the cyclone status effect as a string , and when i try to set it to bit array, i'm getting the wrong value..... its returning 14303186 as Cyclone Flag....

Thanks in advance!

[-impulse-]

Originally Posted by 12tails

Heya!
i'm sending the cyclone status effect as a string , and when i try to set it to bit array, i'm getting the wrong value..... its returning 14303186 as Cyclone Flag....

Thanks in advance!

public class BigInteger
    {
        //For 16 bytes long only.
        private ulong first8bytes, second8bytes;
        public BigInteger()
        {
            first8bytes = 0;
            second8bytes = 0;
        }
        public void Clear()
        {
            first8bytes = 0;
            second8bytes = 0;
        }
        public void AddBitValue(int offset)
        {
            if (offset > 62)
                second8bytes |= (ulong)((ulong)1 << (offset - 63));
            else
                first8bytes |= (ulong)((ulong)1 << offset);
        }
        public void RemoveBitValue(int offset)
        {
            if (offset > 62)
            {
                second8bytes &= ~(ulong)((ulong)1 << (offset - 63));
            }
            else
            {
                first8bytes &= ~(ulong)((ulong)1 << offset);
            }
        }
        public bool ContainsBitValue(int offset)
        {
            if (offset > 62)
            {
                ulong aux = second8bytes;
                aux &= ~(ulong)((ulong)1 << (offset - 63));
                return !(aux == second8bytes);
            }
            else
            {
                ulong aux = first8bytes;
                aux &= ~(ulong)((ulong)1 << offset);
                return !(aux == first8bytes);
            }
        }
        public void Write(byte[] Buffer, int offset)
        {
            unsafe
            {
                fixed (byte* buffer = Buffer)
                {
                    *((UInt64*)(buffer + offset)) = first8bytes;
                    *((UInt64*)(buffer + offset + 8)) = second8bytes;
                }
            }
        }
    }

Try this class. It should work just fine.

[pro4never]

Easiest/more efficient method is just splitting the status value into 2 different ulong values.

According to saint using biginteger is far less efficient and messy to try to actually use in this way.

[12tails]

@pro4ever
thanks for advice
@impulse
thanks for the help... ^^

[-impulse-]

For a bigger bitarray.

public class BigInteger
    {
        byte[] array;
        public BigInteger(int size)
        {
            array = new byte[size];
        }
        public void Clear()
        {
            array = new byte[array.Length];
        }
        private int calculateArrayOffset(ref int offset)
        {
            int Offset = offset / 8;
            offset %= 8;
            return Offset;
        }
        public void AddBitValue(int offset)
        {
            int Offset = calculateArrayOffset(ref offset);
            if (Offset >= array.Length)
                return;
            array[Offset] |= (byte)(1 << offset);
        }
        public void RemoveBitValue(int offset)
        {
            int Offset = calculateArrayOffset(ref offset);
            if (Offset >= array.Length)
                return;
            array[Offset] = (byte)(array[Offset] & (byte)(~(1 << offset)));
        }
        public bool ContainsBitValue(int offset)
        {
            int Offset = calculateArrayOffset(ref offset);
            if (Offset >= array.Length)
                return false;

            byte aux = array[Offset];
            aux = (byte)(aux & (byte)(~(1 << offset)));
            return !(aux == array[Offset]);
        }
        public void Write(byte[] Buffer, int offset)
        {
            for (int i = offset; i < offset + array.Length; i++)
            {
                Buffer[i] = array[i - offset];
            }
        }
        public void Write(byte[] Buffer, int offset, int size)
        {
            for (int i = offset; i < offset + size; i++)
            {
                Buffer[i] = array[i - offset];
            }
        }
    }