Quote:
Originally Posted by frooby1994
very nice bot so far, but i have problems picking up items, the bot just doesnt do that. if i select "pick up" it saves that as "storing it". if i press "store it" it saves it under "sell it", and if i select "sell it" it saves it as "pick up". still, even if it shows, that it should pick it up, it just doesnt do that. and the pet pick up doesnt do anything either :/
|
I found in the code that the setting is saved properly, but loaded back in the form in the wrong order.
Whether the character actually picks up anything is a different problem - this is more of a UI / config problem.
@SDClowen hope you don't mind, but I debugged it, and found the problem.
Repro:
- select any item, only set Pickup to True
- Save settings
- reload form (apply/search) to see same item
- Sell will be True, Pickup will be False
Solution:
In here:
Code:
Main.cs
private async Task PopulateSellListAsync(List<RefObjItem> items)
This part of the code:
Code:
ShoppingManager.SellFilter.Invoke(item.CodeName).ToString(),
ShoppingManager.StoreFilter.Invoke(item.CodeName).ToString(),
PickupManager.PickupFilter.Invoke(item.CodeName).ToString()
This should be:
Code:
PickupManager.PickupFilter.Invoke(item.CodeName).ToString(),
ShoppingManager.SellFilter.Invoke(item.CodeName).ToString(),
ShoppingManager.StoreFilter.Invoke(item.CodeName).ToString()
Other issue:
MaxiGuard verification fails when using automatic login. This is caused because the login attempt is sent too early to the server.
I was able to fix this by making the delay longer (5000ms instead of 1000ms), but your original Task.Delay() in DelayedLoginTry() did not work for me with the ContinueWith for some reason. I ended up changing async voids to async Tasks (which is better practice, I recommend it), and use await Task.Delay(5000), and call the next method with await, after 5 second passes, and that worked fine.
Other minor issue:
Hiding lower level skills actually hides some high level skills for bow. E.g. Anti Devil Bow - Strike (which is 4th) is considered "lower" than Anti Devil Bow - Steel (which is 3rd). There might be others, I just found this one.
