[Release] China Permanent buff

White Ros3 · 03/27/2020, 02:45

Hello, beloved community!

No need to talk about sh1ty codes released before let's get into the issue.

Well,
The best way to create permanent is by making new lines for the old buffs with some modifications like this

old line _RefSkill

Code:

1	93	240	SKILL_CH_COLD_GANGGI_A_01	?:????	SKILL_CH_COLD_GANGGI_A	0	1	2	0	99999999	1000	1000	1000	2000	0	0	0	2	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	273	0	8	0	0	0	0	0	0	0	0	0	6	0	0	0	255	255	0	72	0	0	0	1	0	1	0	skill\china\cold_ganggi_a.ddj	SN_SKILL_CH_COLD_GANGGI_A	xxx	SN_SKILL_CH_COLD_GANGGI_A_TT_DESC	SN_SKILL_CH_COLD_GANGGI_A_STUDY	0	0	3	1685418593	335294	1684366960	2	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0

new line _RefSkill

Code:

1	37000	2400	SKILL_CH_NEW_COLD_GANGGI_A_01	?:????	SKILL_CH_NEW_COLD_GANGGI_A	0	1	1	0	0	0	0	0	1000	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	1	0	0	0	0	0	0	0	0	0	0	0	0	3	0	0	255	255	0	0	0	0	0	255	255	255	255	skill\china\cold_ganggi_a.ddj	SN_SKILL_CH_COLD_GANGGI_A	xxx	SN_SKILL_CH_COLD_GANGGI_A_TT_DESC	SN_SKILL_CH_COLD_GANGGI_A_STUDY	0	0	3	1667396966	1851946342	1685418593	-1875767296	1684366960	2	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0

i hope you get the idea

System depends on Skill Up

skillmanage

Code:

USE [SRO_VT_SHARD]
GO
/****** Object:  StoredProcedure [dbo].[_skill_manage]    Script Date: 3/27/2020 10:37:30 PM ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER OFF
GO
ALTER    procedure [dbo].[_skill_manage]
	@job 		int,
	@charid		int,
	@param1	int,
	@param2	int
as
	if( @job = 0)		-- 스킬 배우기
	begin
	  
	    if( @param1 != 0)
		begin
			delete _CharSkill where CharID = @charid and  SkillId = @param1
		end
		insert _CharSkill values( @charid, @param2, 1)
		IF (@param2 in (select oldID From RI3O_VT_SYSTEMS.dbo.PermenantBuff))
		Begin
		DECLARE @GroupID smallint = (Select GroupID From RI3O_VT_SYSTEMS.dbo.PermenantBuff Where OldID=@param2)
		DECLARE @OldSkill int = (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
		DECLARE @NewID int = (Select SkillID From RI3O_VT_SYSTEMS.dbo.PermenantBuff Where OldID=@param2)
		IF (@OldSkill is null)
		Begin
		DECLARE @Serial bigint = (SELECT Max (Serial64) + 1  FROM SRO_VT_SHARD.dbo._TimedJob with (nolock))
		INSERT INTO SRO_VT_SHARD.dbo._TimedJob with (rowlock) (CharID, Category, JobID, TimeToKeep, Data1, Data2, Data3, Data4, Data5, Data6, Data7, Data8, Serial64) VALUES (@CharID, 0, @NewID, 1875767296, 0, 0, 0, 0, 0, 0, 0, 0, @Serial)
		END
		ELSE 
		Begin
		Update SRO_VT_SHARD.dbo._TimedJob with (rowlock) Set JobID=@NewID Where JobID=@OldSkill And CharID=@CharID
		END
		END
	end
	else if( @job = 1)		-- 마스터리 강화
	begin
		update _CharSkillMastery set Level = @param2 where CharID = @charid and MasteryID = @param1
	end
	else if( @job = 2)		-- 스킬 회수
	begin
		delete _CharSkill where CharID = @charid and SkillId = @param1
		delete from SRO_VT_SHARD.dbo._TimedJob where JobID in (Select SkillID From RI3O_VT_SYSTEMS.dbo.PermenantBuff) And CharID=@charid
		if( @param2 != 0)
		begin
			insert _CharSkill values( @charid, @param2, 1)
		end
	end
	else if( @job = 3)		-- 마스터리 회수
	begin
		update _CharSkillMastery set [Level] = @param2 where CharID = @charid and MasteryID = @param1
	end

premenantbuff table

Code:

USE [RI3O_VT_SYSTEMS]
GO

/****** Object:  Table [dbo].[PermenantBuff]    Script Date: 3/27/2020 3:09:18 AM ******/
SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

CREATE TABLE [dbo].[PermenantBuff](
	[OldID] [smallint] NULL,
	[SkillID] [int] NULL,
	[GroupID] [smallint] NULL,
	[SkillCode] [varchar](64) NULL
) ON [PRIMARY]
GO

premenantbuff table lines

Code:

93	37000	2400	SKILL_CH_NEW_COLD_GANGGI_A_01
1125	37001	2400	SKILL_CH_NEW_COLD_GANGGI_A_02
1126	37002	2400	SKILL_CH_NEW_COLD_GANGGI_A_03
1127	37003	2400	SKILL_CH_NEW_COLD_GANGGI_A_04
1128	37004	2400	SKILL_CH_NEW_COLD_GANGGI_A_05
1129	37005	2400	SKILL_CH_NEW_COLD_GANGGI_A_06
1130	37006	2400	SKILL_CH_NEW_COLD_GANGGI_A_07
1131	37007	2400	SKILL_CH_NEW_COLD_GANGGI_A_08
1132	37008	2400	SKILL_CH_NEW_COLD_GANGGI_A_09
94	37009	2400	SKILL_CH_NEW_COLD_GANGGI_B_01
1133	37010	2400	SKILL_CH_NEW_COLD_GANGGI_B_02
1134	37011	2400	SKILL_CH_NEW_COLD_GANGGI_B_03
1135	37012	2400	SKILL_CH_NEW_COLD_GANGGI_B_04
1136	37013	2400	SKILL_CH_NEW_COLD_GANGGI_B_05
1137	37014	2400	SKILL_CH_NEW_COLD_GANGGI_B_06
1138	37015	2400	SKILL_CH_NEW_COLD_GANGGI_B_07
1139	37016	2400	SKILL_CH_NEW_COLD_GANGGI_B_08
1140	37017	2400	SKILL_CH_NEW_COLD_GANGGI_B_09
95	37018	2400	SKILL_CH_NEW_COLD_GANGGI_C_01
1141	37019	2400	SKILL_CH_NEW_COLD_GANGGI_C_02
1142	37020	2400	SKILL_CH_NEW_COLD_GANGGI_C_03
1143	37021	2400	SKILL_CH_NEW_COLD_GANGGI_C_04
1144	37022	2400	SKILL_CH_NEW_COLD_GANGGI_C_05
1145	37023	2400	SKILL_CH_NEW_COLD_GANGGI_C_06
1146	37024	2400	SKILL_CH_NEW_COLD_GANGGI_C_07
1147	37025	2400	SKILL_CH_NEW_COLD_GANGGI_C_08
1148	37026	2400	SKILL_CH_NEW_COLD_GANGGI_C_09
3365	37027	2400	SKILL_CH_NEW_COLD_GANGGI_D_01
3366	37028	2400	SKILL_CH_NEW_COLD_GANGGI_D_02
3367	37029	2400	SKILL_CH_NEW_COLD_GANGGI_D_03
3368	37030	2400	SKILL_CH_NEW_COLD_GANGGI_D_04
3369	37031	2400	SKILL_CH_NEW_COLD_GANGGI_D_05
3370	37032	2400	SKILL_CH_NEW_COLD_GANGGI_D_06
3371	37033	2400	SKILL_CH_NEW_COLD_GANGGI_D_07
3372	37034	2400	SKILL_CH_NEW_COLD_GANGGI_D_08
3373	37035	2400	SKILL_CH_NEW_COLD_GANGGI_D_09
3374	37036	2400	SKILL_CH_NEW_COLD_GANGGI_D_10
3375	37037	2400	SKILL_CH_NEW_COLD_GANGGI_D_11
3376	37038	2400	SKILL_CH_NEW_COLD_GANGGI_D_12
3377	37039	2400	SKILL_CH_NEW_COLD_GANGGI_D_13
3378	37040	2400	SKILL_CH_NEW_COLD_GANGGI_D_14
3379	37041	2400	SKILL_CH_NEW_COLD_GANGGI_D_15
7976	37042	2400	SKILL_CH_NEW_COLD_GANGGI_E_01
7977	37043	2400	SKILL_CH_NEW_COLD_GANGGI_E_02
7978	37044	2400	SKILL_CH_NEW_COLD_GANGGI_E_03
7979	37045	2400	SKILL_CH_NEW_COLD_GANGGI_E_04
7980	37046	2400	SKILL_CH_NEW_COLD_GANGGI_E_05
7981	37047	2400	SKILL_CH_NEW_COLD_GANGGI_E_06
7982	37048	2400	SKILL_CH_NEW_COLD_GANGGI_E_07
7983	37049	2400	SKILL_CH_NEW_COLD_GANGGI_E_08
7984	37050	2400	SKILL_CH_NEW_COLD_GANGGI_E_09
7985	37051	2400	SKILL_CH_NEW_COLD_GANGGI_E_10
133	37052	2401	SKILL_CH_NEW_FIRE_GANGGI_A_01
1415	37053	2401	SKILL_CH_NEW_FIRE_GANGGI_A_02
1416	37054	2401	SKILL_CH_NEW_FIRE_GANGGI_A_03
1417	37055	2401	SKILL_CH_NEW_FIRE_GANGGI_A_04
1418	37056	2401	SKILL_CH_NEW_FIRE_GANGGI_A_05
1419	37057	2401	SKILL_CH_NEW_FIRE_GANGGI_A_06
1420	37058	2401	SKILL_CH_NEW_FIRE_GANGGI_A_07
1421	37059	2401	SKILL_CH_NEW_FIRE_GANGGI_A_08
1422	37060	2401	SKILL_CH_NEW_FIRE_GANGGI_A_09
134	37061	2401	SKILL_CH_NEW_FIRE_GANGGI_B_01
1423	37062	2401	SKILL_CH_NEW_FIRE_GANGGI_B_02
1424	37063	2401	SKILL_CH_NEW_FIRE_GANGGI_B_03
1425	37064	2401	SKILL_CH_NEW_FIRE_GANGGI_B_04
1426	37065	2401	SKILL_CH_NEW_FIRE_GANGGI_B_05
1427	37066	2401	SKILL_CH_NEW_FIRE_GANGGI_B_06
1428	37067	2401	SKILL_CH_NEW_FIRE_GANGGI_B_07
1429	37068	2401	SKILL_CH_NEW_FIRE_GANGGI_B_08
8135	37153	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_E_03
119	37186	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_A_01
1333	37187	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_A_02
1334	37188	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_A_03
1335	37189	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_A_04
1336	37190	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_A_05
1337	37191	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_A_06
120	37192	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_B_01
1338	37193	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_B_02
1339	37194	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_B_03
1340	37195	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_B_04
1341	37196	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_B_05
1342	37197	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_B_06
3410	37198	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_C_01
3411	37199	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_C_02
3412	37200	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_C_03
3413	37201	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_C_04
3414	37202	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_C_05
3415	37203	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_C_06
8175	37204	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_01
8176	37205	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_02
8177	37206	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_03
8178	37207	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_04
8179	37208	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_05
8180	37209	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_06
8181	37210	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_07
8182	37211	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_08
8183	37212	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_D_09
8184	37213	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_E_01
8185	37214	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_E_02
8186	37215	2406	SKILL_CH_NEW_LIGHTNING_JIPJUNG_E_03
1430	37069	2401	SKILL_CH_NEW_FIRE_GANGGI_B_09
135	37070	2401	SKILL_CH_NEW_FIRE_GANGGI_C_01
1431	37071	2401	SKILL_CH_NEW_FIRE_GANGGI_C_02
1432	37072	2401	SKILL_CH_NEW_FIRE_GANGGI_C_03
1433	37073	2401	SKILL_CH_NEW_FIRE_GANGGI_C_04
1434	37074	2401	SKILL_CH_NEW_FIRE_GANGGI_C_05
1435	37075	2401	SKILL_CH_NEW_FIRE_GANGGI_C_06
1436	37076	2401	SKILL_CH_NEW_FIRE_GANGGI_C_07
1437	37077	2401	SKILL_CH_NEW_FIRE_GANGGI_C_08
1438	37078	2401	SKILL_CH_NEW_FIRE_GANGGI_C_09
8224	37079	2401	SKILL_CH_NEW_FIRE_GANGGI_D_01
8225	37080	2401	SKILL_CH_NEW_FIRE_GANGGI_D_02
8226	37081	2401	SKILL_CH_NEW_FIRE_GANGGI_D_03
8227	37082	2401	SKILL_CH_NEW_FIRE_GANGGI_D_04
8228	37083	2401	SKILL_CH_NEW_FIRE_GANGGI_D_05
8229	37084	2401	SKILL_CH_NEW_FIRE_GANGGI_D_06
8230	37085	2401	SKILL_CH_NEW_FIRE_GANGGI_D_07
8231	37086	2401	SKILL_CH_NEW_FIRE_GANGGI_D_08
8232	37087	2401	SKILL_CH_NEW_FIRE_GANGGI_D_09
8233	37088	2401	SKILL_CH_NEW_FIRE_GANGGI_D_10
8234	37089	2401	SKILL_CH_NEW_FIRE_GANGGI_D_11
8235	37090	2401	SKILL_CH_NEW_FIRE_GANGGI_D_12
8236	37091	2401	SKILL_CH_NEW_FIRE_GANGGI_D_13
8237	37092	2401	SKILL_CH_NEW_FIRE_GANGGI_D_14
8238	37093	2401	SKILL_CH_NEW_FIRE_GANGGI_D_15
8239	37094	2401	SKILL_CH_NEW_FIRE_GANGGI_E_01
8240	37095	2401	SKILL_CH_NEW_FIRE_GANGGI_E_02
8241	37096	2401	SKILL_CH_NEW_FIRE_GANGGI_E_03
8242	37097	2401	SKILL_CH_NEW_FIRE_GANGGI_E_04
8243	37098	2401	SKILL_CH_NEW_FIRE_GANGGI_E_05
8244	37099	2401	SKILL_CH_NEW_FIRE_GANGGI_E_06
130	37100	2402	SKILL_CH_NEW_FIRE_GONGUP_A_01
1409	37101	2402	SKILL_CH_NEW_FIRE_GONGUP_A_02
1410	37102	2402	SKILL_CH_NEW_FIRE_GONGUP_A_03
131	37103	2402	SKILL_CH_NEW_FIRE_GONGUP_B_01
1411	37104	2402	SKILL_CH_NEW_FIRE_GONGUP_B_02
1412	37105	2402	SKILL_CH_NEW_FIRE_GONGUP_B_03
132	37106	2402	SKILL_CH_NEW_FIRE_GONGUP_C_01
1413	37107	2402	SKILL_CH_NEW_FIRE_GONGUP_C_02
1414	37108	2402	SKILL_CH_NEW_FIRE_GONGUP_C_03
8218	37109	2402	SKILL_CH_NEW_FIRE_GONGUP_D_01
8219	37110	2402	SKILL_CH_NEW_FIRE_GONGUP_D_02
8220	37111	2402	SKILL_CH_NEW_FIRE_GONGUP_D_03
8221	37112	2402	SKILL_CH_NEW_FIRE_GONGUP_E_01
8222	37113	2402	SKILL_CH_NEW_FIRE_GONGUP_E_02
8223	37114	2402	SKILL_CH_NEW_FIRE_GONGUP_E_03
127	37115	2403	SKILL_CH_NEW_FIRE_SHIELD_A_01
1394	37116	2403	SKILL_CH_NEW_FIRE_SHIELD_A_02
1395	37117	2403	SKILL_CH_NEW_FIRE_SHIELD_A_03
1396	37118	2403	SKILL_CH_NEW_FIRE_SHIELD_A_04
1397	37119	2403	SKILL_CH_NEW_FIRE_SHIELD_A_05
1398	37120	2403	SKILL_CH_NEW_FIRE_SHIELD_A_06
128	37121	2403	SKILL_CH_NEW_FIRE_SHIELD_B_01
1399	37122	2403	SKILL_CH_NEW_FIRE_SHIELD_B_02
1400	37123	2403	SKILL_CH_NEW_FIRE_SHIELD_B_03
1401	37124	2403	SKILL_CH_NEW_FIRE_SHIELD_B_04
1402	37125	2403	SKILL_CH_NEW_FIRE_SHIELD_B_05
1403	37126	2403	SKILL_CH_NEW_FIRE_SHIELD_B_06
129	37127	2403	SKILL_CH_NEW_FIRE_SHIELD_C_01
1404	37128	2403	SKILL_CH_NEW_FIRE_SHIELD_C_02
1405	37129	2403	SKILL_CH_NEW_FIRE_SHIELD_C_03
1406	37130	2403	SKILL_CH_NEW_FIRE_SHIELD_C_04
1407	37131	2403	SKILL_CH_NEW_FIRE_SHIELD_C_05
1408	37132	2403	SKILL_CH_NEW_FIRE_SHIELD_C_06
3431	37133	2403	SKILL_CH_NEW_FIRE_SHIELD_D_01
3432	37134	2403	SKILL_CH_NEW_FIRE_SHIELD_D_02
3433	37135	2403	SKILL_CH_NEW_FIRE_SHIELD_D_03
3434	37136	2403	SKILL_CH_NEW_FIRE_SHIELD_D_04
3435	37137	2403	SKILL_CH_NEW_FIRE_SHIELD_D_05
3436	37138	2403	SKILL_CH_NEW_FIRE_SHIELD_D_06
110	37139	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_A_01
1270	37140	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_A_02
1271	37141	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_A_03
111	37142	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_B_01
1272	37143	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_B_02
1273	37144	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_B_03
112	37145	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_C_01
1274	37146	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_C_02
1275	37147	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_C_03
3407	37148	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_D_01
3408	37149	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_D_02
3409	37150	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_D_03
8133	37151	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_E_01
8134	37152	2404	SKILL_CH_NEW_LIGHTNING_GWANTONG_E_02

Note : lines for cap 120 or less

Greetings, everyone <3

VORTEX* · 03/27/2020, 02:48

Strong as always my boy

White Ros3 · 03/27/2020, 02:48

Quote:

Originally Posted by Zerox*

Strong as always my boy

luv u

*Deadly · 03/27/2020, 08:28

keep it up buddy

White Ros3 · 03/27/2020, 08:32

Quote:

Originally Posted by *Deadly

keep it up buddy

it's just the beginning

JoleChow* · 03/27/2020, 18:56

Thanks for sharing

White Ros3 · 03/27/2020, 19:19

Quote:

Originally Posted by JoleChow*

Thanks for sharing

de nada

~~VeRo!~~ · 03/27/2020, 20:08

Those lines

Code:

IF NOT EXISTS (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
Begin
INSERT INTO SRO_VT_SHARD.dbo._TimedJob with (rowlock) (CharID, Category, JobID, TimeToKeep, Data1, Data2, Data3, Data4, Data5, Data6, Data7, Data8, Serial64) VALUES (@CharID, 0, @NewID, 1875767296, 0, 0, 0, 0, 0, 0, 0, 0, @Serial)
END
ELSE IF EXISTS (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
Begin
DECLARE @OldSkill int = (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
Update SRO_VT_SHARD.dbo._TimedJob with (rowlock) Set JobID=@NewID Where JobID=@OldSkill And CharID=@CharID
END

Could be:

Code:

DECLARE @OldSkill int = (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)

IF @OldSkill IS NOT NULL
INSERT INTO SRO_VT_SHARD.dbo._TimedJob with (rowlock) (CharID, Category, JobID, TimeToKeep, Data1, Data2, Data3, Data4, Data5, Data6, Data7, Data8, Serial64) VALUES (@CharID, 0, @NewID, 1875767296, 0, 0, 0, 0, 0, 0, 0, 0, @Serial)

ELSE Update SRO_VT_SHARD.dbo._TimedJob with (rowlock) Set JobID=@NewID Where JobID=@OldSkill And CharID=@CharID

For a way better performance.
also i suggest editing Old Skills instead, that will make _RefSkill table with less rows, for a better performance on executing skill_manage.

ceavk2 · 03/27/2020, 20:15

u cant make video tutorial ?

White Ros3 · 03/27/2020, 20:27

Quote:

Originally Posted by yossf666666

Those lines

Code:

IF NOT EXISTS (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
Begin
INSERT INTO SRO_VT_SHARD.dbo._TimedJob with (rowlock) (CharID, Category, JobID, TimeToKeep, Data1, Data2, Data3, Data4, Data5, Data6, Data7, Data8, Serial64) VALUES (@CharID, 0, @NewID, 1875767296, 0, 0, 0, 0, 0, 0, 0, 0, @Serial)
END
ELSE IF EXISTS (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
Begin
DECLARE @OldSkill int = (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
Update SRO_VT_SHARD.dbo._TimedJob with (rowlock) Set JobID=@NewID Where JobID=@OldSkill And CharID=@CharID
END

Could be:

Code:

DECLARE @OldSkill int = (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)

IF @OldSkill IS NOT NULL
INSERT INTO SRO_VT_SHARD.dbo._TimedJob with (rowlock) (CharID, Category, JobID, TimeToKeep, Data1, Data2, Data3, Data4, Data5, Data6, Data7, Data8, Serial64) VALUES (@CharID, 0, @NewID, 1875767296, 0, 0, 0, 0, 0, 0, 0, 0, @Serial)

ELSE Update SRO_VT_SHARD.dbo._TimedJob with (rowlock) Set JobID=@NewID Where JobID=@OldSkill And CharID=@CharID

For a way better performance.
also i suggest editing Old Skills instead, that will make _RefSkill table with less rows, for a better performance on executing skill_manage.

this won't insert the skill for that first time it must be null to insert
two checks same codes where the better perf you talking about ?
oh you mean begin & end ? lol
why should i declare variable in case i don't need it lol again
less lines of _refskill for a better performance on executing skill_manage. ? wwhat ?

Quote:

Originally Posted by ceavk2

u cant make video tutorial ?

sorry i can't just copy|past lines and execute queries

~~VeRo!~~ · 03/27/2020, 20:53

Quote:

Originally Posted by White Ros3

two checks same codes where the better perf you talking about ?
oh you mean begin & end ? lol
why should i declare variable in case i don't need it lol again

both codes do the same job, but hell yeah, you enter the table 2 times

Code:

IF NOT EXISTS (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)

Entering timed job and permanent buffs first time

Code:

ELSE IF EXISTS (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)

second time

Code:

DECLARE @OldSkill int = (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)

third time and still talking about both do the same job? lmao

Quote:

Originally Posted by White Ros3

less lines of _refskill for a better performance on executing skill_manage. ? wwhat ?

meant GS*

Also that should be a while loop, not executing those in each skill increase!

Beba Army · 05/26/2020, 22:55

Quote:
Originally Posted by yossf666666
both codes do the same job, but hell yeah, you enter the table 2 times
Code:
IF NOT EXISTS (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
Entering timed job and permanent buffs first time
Code:
ELSE IF EXISTS (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
second time
Code:
DECLARE @OldSkill int = (Select Top 1 JobID From SRO_VT_SHARD.dbo._TimedJob T with (nolock) Inner Join RI3O_VT_SYSTEMS.dbo.PermenantBuff P on T.JobID=P.SkillID Where T.CharID=@CharID And P.GroupID=@GroupID)
third time and still talking about both do the same job? lmao

meant GS*

Also that should be a while loop, not executing those in each skill increase!

So his query could bug or damage something?

~~VeRo!~~ · 05/27/2020, 16:19

Quote:

Originally Posted by Beba Army

So his query could bug or damage something?

It won't bug anything buddy, but managing to execute this on every skill upgrade/downgrade is not fine.. Way lot CPU usage for nothing
Also you cannot add lightning speed buff as permanent buff using this code, that will be buggy. as i see he couldn't add it in the topic.

Beba Army · 05/27/2020, 17:36

Quote:

Originally Posted by yossf666666

It won't bug anything buddy, but managing to execute this on every skill upgrade/downgrade is not fine.. Way lot CPU usage for nothing
Also you cannot add lightning speed buff as permanent buff using this code, that will be buggy. as i see he couldn't add it in the topic.

So finally what is the correct query, that u posted above?

~~VeRo!~~ · 05/27/2020, 17:56

Quote:

Originally Posted by Beba Army

So finally what is the correct query, that u posted above?

Nope, not even a good way to create this system, but easier and better to use the old skill codes and external code that gets executed on login/logout only, not every skill upgrade/downgrade.