[WIP] Get SRO Source Code - by re-writing it

[florian0]

Originally Posted by Hercules*

there is other way just set the imgui off on
options.cmake

option(CONFIG_IMGUI "Enable ImGui" OFF)
if (CONFIG_IMGUI)
    add_definitions(-DCONFIG_IMGUI)
endif()

remember to rebuild the src

While it is totally a valid solution, I would not recommend using the "default values" as a configuration file.
Having a configuration file would be cool for a future update. Not sure if it is worth it, yet. I'm also unsure how an acceptable implementation could look xD.

I just hope nobody tries to change the flags in the Visual Studio project ... that would be awful.

Originally Posted by mudik

Ich muss mich bei dir entschuldigen, hab da einen sehr dummen fehler gemacht und CONFIG_IMGUI "Enable ImGui" ON nicht off gemacht da ich dachte es wären die in game GUI´s...

LUL. Happens to the best. At least you learned something .

[XxGhostSpiriTxX]

I get this error in the SBOT bot, I want to clarify that WITHOUT BOT the client opens nomal, with the mbot it opens normal, but when I try to open the client with SBOT I get this error



and the dll is fine, I'm using it to add the discord icon and facebook and everything works fine for me, the only error is that I can't run the game with SBOT

and the error happens after adding the dll (DevKit_DLL) if I use another Sro_client.exe without injecting the DevKit_DLL dll, the SBOT works, I would like to understand where the error can be, because it is very rare, because if I run the client with the DevKit_DLL .dll the client without bot it opens me normal if I run it with the mbot it opens me normal but with sbot no

[florian0]

Originally Posted by esteve458

I get this error in the SBOT bot, I want to clarify that WITHOUT BOT the client opens nomal, with the mbot it opens normal, but when I try to open the client with SBOT I get this error

I just played around a little and figured out that it works when you select "Run in XTrap comatibility mode". Definitely not the solution I was looking for, but a workaround for now. Needs more investigation.

Edit: It's the WinMain-hook that causes the issue
I'll find a workaround for this.

[XxGhostSpiriTxX]

Originally Posted by florian0

I just played around a little and figured out that it works when you select "Run in XTrap comatibility mode". Definitely not the solution I was looking for, but a workaround for now. Needs more investigation.

Edit: It's the WinMain-hook that causes the issue
I'll find a workaround for this.

ok thank you very much @ for responding quickly, from what I see no one had noticed that mistake

[florian0]

It's fixed @

Merge request is currently pending:

[XxGhostSpiriTxX]

Originally Posted by florian0

It's fixed @

Merge request is currently pending:

thank you very much @ what is the next step now, compile everything again?

I downloaded the whole new file from (git clone --recurse-submodules ) I re-compiled everything and still get the sbot error

Ready Fix @

now everything works fine Thanks @ the only error the sbot comes out is ([17:09:54] BUG FOUND: Parsing error! For bug analysis, please send the files: storage.dat and charpacket.dat (in botfolder ) to and include bot version number and server you're playing on) but still the bot works and does all its work

[florian0]

Originally Posted by esteve458

the only error the sbot comes out is ([17:09:54] BUG FOUND: Parsing error! For bug analysis, please send the files: storage.dat and charpacket.dat (in botfolder ) to and include bot version number and server you're playing on) but still the bot works and does all its work

Hm. Can't reproduce this error right now. Maybe not a DevKit issue :/. But at least the other error is resolved

[Laag#82]

Originally Posted by esteve458

thank you very much @ what is the next step now, compile everything again?

I downloaded the whole new file from (git clone --recurse-submodules ) I re-compiled everything and still get the sbot error

Ready Fix @

now everything works fine Thanks @ the only error the sbot comes out is ([17:09:54] BUG FOUND: Parsing error! For bug analysis, please send the files: storage.dat and charpacket.dat (in botfolder ) to and include bot version number and server you're playing on) but still the bot works and does all its work

Originally Posted by florian0

Hm. Can't reproduce this error right now. Maybe not a DevKit issue :/. But at least the other error is resolved

Hello florian0,



[Fix]

PHP Code:

void InstallRuntimeClasses();

struct A {
    void InitGameAssets() {
        InstallRuntimeClasses();
        reinterpret_cast<void(__thiscall *)(A *)>(0x00849110)(this);
    }
}; 


PHP Code:

void InstallRuntimeClasses() {
    // Replace Create & Delete for existing classes
    // Note: We can't just inject existing objects like we would do with new objects.
    //       Joymax uses == on GFX_RUNTIME_CLASS(), so we would end up breaking this comparison

    for (std::vector<const CGfxRuntimeClass *>::const_iterator it = register_objects.begin();
        it != register_objects.end(); ++it) {
        reinterpret_cast<void(__thiscall *)(const CGfxRuntimeClass *, const char *, void *, void *,
            const CGfxRuntimeClass *, size_t, int)>(0x00B9C9C0)(*it,
            (*it)->m_lpszClassName,
                (*it)->m_pfnCreateObject,
                (*it)->m_pfnDeleteObject,
                (*it)->m_pBaseClass,
                (*it)->m_nObjectSize,
                0);
    }


    for (std::vector<overrideFnPtr>::const_iterator it = override_objects.begin(); it != override_objects.end(); ++it) {
        (*it)();
    }

} 


[Error]

PHP Code:

replaceOffset(0x00B49AE4, (int)&_FakeWinMain); 


PHP Code:

return reinterpret_cast<int (APIENTRY*)(HINSTANCE, HINSTANCE, LPTSTR, int)>(0x008328C0)(hInstance, hPrevInstance, lpCmdLine, nCmdShow); 


[Total Fix]

Copy



Paste in Util.cpp and rebuild

Fixed 100% after check

Good luck to everyone

Special thanks to: florian0

[XxGhostSpiriTxX]

Originally Posted by khaleed2010

Hello florian0,



[Fix]

PHP Code:

void InstallRuntimeClasses();

struct A {
    void InitGameAssets() {
        InstallRuntimeClasses();
        reinterpret_cast<void(__thiscall *)(A *)>(0x00849110)(this);
    }
}; 


PHP Code:

void InstallRuntimeClasses() {
    // Replace Create & Delete for existing classes
    // Note: We can't just inject existing objects like we would do with new objects.
    //       Joymax uses == on GFX_RUNTIME_CLASS(), so we would end up breaking this comparison

    for (std::vector<const CGfxRuntimeClass *>::const_iterator it = register_objects.begin();
        it != register_objects.end(); ++it) {
        reinterpret_cast<void(__thiscall *)(const CGfxRuntimeClass *, const char *, void *, void *,
            const CGfxRuntimeClass *, size_t, int)>(0x00B9C9C0)(*it,
            (*it)->m_lpszClassName,
                (*it)->m_pfnCreateObject,
                (*it)->m_pfnDeleteObject,
                (*it)->m_pBaseClass,
                (*it)->m_nObjectSize,
                0);
    }


    for (std::vector<overrideFnPtr>::const_iterator it = override_objects.begin(); it != override_objects.end(); ++it) {
        (*it)();
    }

} 


[Error]

PHP Code:

replaceOffset(0x00B49AE4, (int)&_FakeWinMain); 


PHP Code:

return reinterpret_cast<int (APIENTRY*)(HINSTANCE, HINSTANCE, LPTSTR, int)>(0x008328C0)(hInstance, hPrevInstance, lpCmdLine, nCmdShow); 


[Total Fix]

Copy



Paste in Util.cpp and rebuild

Fixed 100% after check

Good luck to everyone

Special thanks to: florian0

Good morning @ thank you very much, a question is there any way to create an effect to the icon? than the icon Titile?

[Laag#82]

Originally Posted by esteve458

Good morning @ thank you very much, a question is there any way to create an effect to the icon? than the icon Titile?

An example of this

[XxGhostSpiriTxX]

Originally Posted by khaleed2010

An example of this

example

[Laag#82]

Originally Posted by esteve458

example

PHP Code:

TB_Func_13("icon\\etc\\facebook_0.ddj", 0, 0);
sub_634470("icon\\etc\\facebook_1.ddj");
sub_634470("icon\\etc\\facebook_2.ddj"); 


[thaidu0ngpr0]

Originally Posted by khaleed2010

Hello florian0,



[Fix]

PHP Code:

void InstallRuntimeClasses();

struct A {
    void InitGameAssets() {
        InstallRuntimeClasses();
        reinterpret_cast<void(__thiscall *)(A *)>(0x00849110)(this);
    }
}; 


PHP Code:

void InstallRuntimeClasses() {
    // Replace Create & Delete for existing classes
    // Note: We can't just inject existing objects like we would do with new objects.
    //       Joymax uses == on GFX_RUNTIME_CLASS(), so we would end up breaking this comparison

    for (std::vector<const CGfxRuntimeClass *>::const_iterator it = register_objects.begin();
        it != register_objects.end(); ++it) {
        reinterpret_cast<void(__thiscall *)(const CGfxRuntimeClass *, const char *, void *, void *,
            const CGfxRuntimeClass *, size_t, int)>(0x00B9C9C0)(*it,
            (*it)->m_lpszClassName,
                (*it)->m_pfnCreateObject,
                (*it)->m_pfnDeleteObject,
                (*it)->m_pBaseClass,
                (*it)->m_nObjectSize,
                0);
    }


    for (std::vector<overrideFnPtr>::const_iterator it = override_objects.begin(); it != override_objects.end(); ++it) {
        (*it)();
    }

} 


[Error]

PHP Code:

replaceOffset(0x00B49AE4, (int)&_FakeWinMain); 


PHP Code:

return reinterpret_cast<int (APIENTRY*)(HINSTANCE, HINSTANCE, LPTSTR, int)>(0x008328C0)(hInstance, hPrevInstance, lpCmdLine, nCmdShow); 


[Total Fix]

Copy



Paste in Util.cpp and rebuild

Fixed 100% after check

Good luck to everyone

Special thanks to: florian0

Can you sell your project to me, I need to buy it
my discord Thaidu0ngpr0#3327

[florian0]

Originally Posted by thaidu0ngpr0

Can you sell your project to me, I need to buy it
my discord Thaidu0ngpr0#3327

This thread is not a marketplace . Write a PM.

[thaidu0ngpr0]

Originally Posted by florian0

This thread is not a marketplace . Write a PM.

If you have a good heart, create a guide, handling packets using sro_dev, to help newbies like us do it.
Thank you for sharing