[Release] shStudio 0.7.5

sominus · 07/09/2015, 04:51

Found similar problem here. Trying to edit NpcSkills, result in some fields with empty or wrong values. I'm using (clean) SDatas from OS 5.4 USA Client, in SStudio (7.5.5) format is set to EP5.

Fields which I found with 'changed' values (not the values I put there before pressing the OK button), in NPCSkills.SData :

Target(s) [this one doesn't save my changes]

Apply Range
Keep Time (this one always reset to zero, and its previous value goes to Apply Range)

The other fields seem to save the correct value.

When editing Skills.SData:
Family: (non editable)
Description: (non editable) (and when saving, previous description resets to empty string)

[Alcatraz] · 07/09/2015, 10:57

Quote:

When editing Skills.SData:
Family: (non editable)
Description: (non editable) (and when saving, previous description resets to empty string)

the descriptions for the skills are located in the skills.desc.ini file in the folder where the sh studios file is and they are listed by number and once the description is added to the ini file it will no longer clear when saving it it only clears when there is no data found in the ini for that skill

Hyuga997 · 07/10/2015, 05:56

Quote:

Originally Posted by sominus

Fields which I found with 'changed' values (not the values I put there before pressing the OK button), in NPCSkills.SData :

Target(s) [this one doesn't save my changes]

Apply Range
Keep Time (this one always reset to zero, and its previous value goes to Apply Range)

The other fields seem to save the correct value.

When editing Skills.SData:
Family: (non editable)
Description: (non editable) (and when saving, previous description resets to empty string)

Same thing occurs to me when I tried editing the NpcSkill.Sdata though I did get around it.

I re-named the NpcSkill.sdata to Skill.sdata.
Opened it in Shstudio 0.7.5.5 added a clean field (add skill name and type of skill, saved it.)
I re-named the Skill.sdata back to NpcSkill.sdata.
Open NpcSkill.sdata and add element, and other details.
Re-name the file back to Skill.sdata (Will require to open another window of shstudio 0.7.5.5, if you've been opening these files through workspace)
Then make your final definitions of the skill.
Once finished, you can edit the description of the skill through the old shstudio (0.7.1 or so). Then re-name it back to NpcSkill.sdata and you should be finished. (You can double check by opening it in the new shstudio, just don't save anything or it'll make unwanted changes).

sominus · 07/12/2015, 01:54

Can you confirm that Apply Range and Keep Time are NOT 'inverted'?

Hyuga997 · 07/12/2015, 08:07

From what I experience in the raw skills of the NpcSkill.sdata being saved through the newest version of shstudio, it is shown that the Apply Range and Keep Time values are indeed inverted upon saving a specified skill. However as I said earlier, I have found a loop-hole so to speak, that allows me to acquire all the definitions I need by renaming the file to Skill.sdata and then opening it through shstudio (which opens a different window than NpcSkill.sdata). Using these definitions given through the Skill window, you are able to
1. Create a monster skill
2. Choose the skill type, fill in definitions of the skill and other things that you want the skill to do.

After editing, open the Skill.sdata with an older version of shstudio (0.7.1) in order to edit the description of the skill.
Then finish up by re-naming the Skill.sdata back into it's original name, NpcSkill.sdata.

To double-check if everything is okay, you can open the NpcSkill.sdata with the newer version of shstudio, go to Raw skills, and it'll show you the values in each column, as you find the skill you edited, it should give you the corresponding values that you had put in the file when it was named Skill.sdata.
Note* If you saved the skill in NpcSkill.sdata in the new shstudio, your Apply Range and Keep Time values will invert once again. So be sure not to press "Okay" when you view the skill.

SpaceCase521 · 07/16/2015, 19:21

Love the new tool but miss some of the old features.
like being able to fast edit some of the sdata files. now instead of going down a column I have to open a box to every item when all I really want to do is hit the enter key and work my way down the column
I'll show you what I mean

in this pic I have to open the item to edit the edur

in this pic I can fast edit the Endur of this item and the next but clicking the enter key

is there anyway to make the new tool have some (but not all) the features of the old tool? if not I can still use the old one as I love how I can quickly edit a lot of items.

AroraBleu · 07/18/2015, 06:04

Quote:

Originally Posted by [Alcatraz]

the descriptions for the skills are located in the skills.desc.ini file in the folder where the sh studios file is and they are listed by number and once the description is added to the ini file it will no longer clear when saving it it only clears when there is no data found in the ini for that skill

The skill descriptions will clear if the Toon Skill or Noos Skill levels are 0, which by default alot of them are. Using python and converting the .sdata to a CSV and changing all the levels to a 1 or higher solved the descriptions being cleared when i opened them with SH and then saved them.

I digress is a pain in the ***, and would be nice if it was fixed.

[Alcatraz] · 07/18/2015, 08:34

but youll need the python skill script that works with 9 skills if your using ep5 skills if you use the ep4.5 skill python script it wont work with ep5 it will only do the first 3 skills when rebuilding the csv files back into sdata files

[ADM]Lightning · 07/26/2015, 02:04

There is always that... Yeah forgot about the python CSV only going to 3 skill levels. So the solution to set all the skills to atleast level one will only work for 4.5 servers.

[Alcatraz] · 07/26/2015, 08:26

to make the python skills script work you have to edit this file Skill.py that's in your src folder in the python locations it should look something like this in notepad ++

Spoiler

and all you want to do is change the two 3s to 9s and it will look like this

Spoiler

then save your work and you done it should now work correctly if im not mistaken its been a bit sense I edited mine but that think that's the only step

note: you only want to do this if your using the skills +3 fix from lph release

[ADM]Lightning · 07/27/2015, 03:44

Your inner geek is showing Alca...

Pave99 · 07/27/2015, 11:17

Quote:

Originally Posted by [Alcatraz]

to make the python skills script work you have to edit this file Skill.py that's in your src folder in the python locations it should look something like this in notepad ++

Spoiler

'''
This file is part of Shay_data_edit.

Shay_data_edit is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

Shay_data_edit is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with Shay_data_edit. If not, see <http://www.gnu.org/licenses/>.

Copyright ZeroSignal 2009, 2010
'''

from Utils import *

skill_types = [
['SkillName', 'string'],
['SkillDesc', 'string'],
['SkillLevel', 'tinyint'],
['SkillID', 'short'],
['SkillAnim', 'tinyint'],
['SkillIcon', 'int'],
['ReqLevel', 'short'],
['Country', 'tinyint'],

['AttackFighter', 'tinyint'],
['DefenseFighter', 'tinyint'],
['Patrolrogue', 'tinyint'],
['Shootrogue', 'tinyint'],
['AttackMage', 'tinyint'],
['DefenseMage', 'tinyint'],

['Grow', 'tinyint'],
['SkillPoint', 'tinyint'],
['TypeShow', 'tinyint'],
['TypeAttack', 'tinyint'],
['TypeEffect', 'tinyint'],
['TypeDetail', 'short'],

['NeedWeapon1', 'tinyint'],
['NeedWeapon2', 'tinyint'],
['NeedWeapon3', 'tinyint'],
['NeedWeapon4', 'tinyint'],
['NeedWeapon5', 'tinyint'],
['NeedWeapon6', 'tinyint'],
['NeedWeapon7', 'tinyint'],
['NeedWeapon8', 'tinyint'],
['NeedWeapon9', 'tinyint'],
['NeedWeapon10', 'tinyint'],
['NeedWeapon11', 'tinyint'],
['NeedWeapon12', 'tinyint'],
['NeedWeapon13', 'tinyint'],
['NeedWeapon14', 'tinyint'],
['NeedWeapon15', 'tinyint'],

['Shield', 'tinyint'],
['SP', 'short'],
['MP', 'short'],
['ReadyTime', 'tinyint'],
['ResetTime', 'short'],
['AttackRange', 'tinyint'],
['StateType', 'tinyint'],
['AttrType', 'tinyint'],
['Disable', 'short'],
['PrevSkillID', 'short'],
['SuccessType', 'tinyint'],
['SuccessValue', 'tinyint'],
['TargetType', 'tinyint'],
['ApplyRange', 'tinyint'],
['MultiAttack', 'tinyint'],
['KeepTime', 'short'],
['Weapon1', 'tinyint'],
['Weapon2', 'tinyint'],
['Weaponvalue', 'tinyint'],
['Bag', 'tinyint'],
['Arrow', 'short'],

['DamageType', 'tinyint'],
['DamageHP', 'short'],
['DamageSP', 'short'],
['DamageMP', 'short'],
['TimeDamageType', 'tinyint'],
['TimeDamageHP', 'short'],
['TimeDamageSP', 'short'],
['TimeDamageMP', 'short'],
['AddDamageHP', 'short'],
['AddDamageSP', 'short'],
['AddDamageMP', 'short'],

['AbilityType1', 'tinyint'],
['AbilityValue1', 'short'],
['AbilityType2', 'tinyint'],
['AbilityValue2', 'short'],
['AbilityType3', 'tinyint'],
['AbilityValue3', 'short'],

['HealHP', 'short'],
['HealSP', 'short'],
['HealMP', 'short'],
['TimeHealHP', 'short'],
['TimeHealSP', 'short'],
['TimeHealMP', 'short'],

['DefenseType', 'tinyint'],
['DefenseValue', 'tinyint'],
['LimitHP', 'tinyint'],
['FixRange', 'tinyint'],
['ChangeType', 'short'],
['ChangeLevel', 'short'],
]

def MainSkill(outFmt):
if (outFmt.export_complete):
return CombineSkill("Skill")
if (outFmt.csv_import or outFmt.csv_complete):
return ExtractSkill("Skill", outFmt)

def MainNPCSkill(outFmt):
if (outFmt.export_complete):
return CombineSkill("NpcSkill")
if (outFmt.csv_import or outFmt.csv_complete):
return ExtractSkill("NpcSkill", outFmt)

def CombineSkill(type):
csvIn = work_dir + type + ".complete.csv"
try:
csvf = csv.DictReader(open(csvIn))
except IOError:
sys.exit(MsgFileReadError % csvIn)

foutName = work_dir + type + ".SData"
try:
fout = open(foutName, mode='wb')
except IOError:
sys.exit(MsgFileWriteError % foutName)

recs = []
for row in csvf:
recs.append(row)
print "skill_rows: " + str(len(recs))

# Write Total.
record_total = struct.pack('I', (len(recs) / 3))
fout.write(record_total)

for i in recs:
pack_fields(fout, skill_types, i)
return True

def ExtractSkill(type, outFmt):
# Open SData File.
skillSData = feed_dir + type + ".SData"
try:
input = open(skillSData, mode='rb')
except IOError:
sys.exit(MsgFileReadError % skillSData)

header = get_data_headers(skill_types)

if (outFmt.csv_import):
filename = work_dir + type + ".import.csv"
header.pop(1) # Remove SkillDesc
header.pop(3) # Remove SkillAnim
header.pop(3) # Remove SkillIcon

if (outFmt.csv_complete):
filename = work_dir + type + ".complete.csv"

print("Creating " + filename)
# Open File for output.
try:
fout = open(filename, mode='wb')
except IOError:
sys.exit(MsgFileWriteError % filename)

fout_csv = csv.writer(fout)
fout_csv.writerow(header)
fout_csv = csv.DictWriter(fout, header)

record_total = unpack_field(input, 'int')

i = 0
j = 0
while True:
rec = unpack_fields(input, skill_types, {})

if (rec["SkillLevel"] == 1):
i += 1
j = 0
j += 1

if (outFmt.csv_import):
rec["SkillID"] = i

cs_rec = copyKeys(rec, header)
fout_csv.writerow(cs_rec)
if (i == record_total and j == 3):
break
return True

and all you want to do is change the 3s to 9s and it will look like this

Spoiler

'''
This file is part of Shay_data_edit.

Shay_data_edit is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

Shay_data_edit is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with Shay_data_edit. If not, see <http://www.gnu.org/licenses/>.

Copyright ZeroSignal 2009, 2010
'''

from Utils import *

skill_types = [
['SkillName', 'string'],
['SkillDesc', 'string'],
['SkillLevel', 'tinyint'],
['SkillID', 'short'],
['SkillAnim', 'tinyint'],
['SkillIcon', 'int'],
['ReqLevel', 'short'],
['Country', 'tinyint'],

['AttackFighter', 'tinyint'],
['DefenseFighter', 'tinyint'],
['Patrolrogue', 'tinyint'],
['Shootrogue', 'tinyint'],
['AttackMage', 'tinyint'],
['DefenseMage', 'tinyint'],

['Grow', 'tinyint'],
['SkillPoint', 'tinyint'],
['TypeShow', 'tinyint'],
['TypeAttack', 'tinyint'],
['TypeEffect', 'tinyint'],
['TypeDetail', 'short'],

['NeedWeapon1', 'tinyint'],
['NeedWeapon2', 'tinyint'],
['NeedWeapon3', 'tinyint'],
['NeedWeapon4', 'tinyint'],
['NeedWeapon5', 'tinyint'],
['NeedWeapon6', 'tinyint'],
['NeedWeapon7', 'tinyint'],
['NeedWeapon8', 'tinyint'],
['NeedWeapon9', 'tinyint'],
['NeedWeapon10', 'tinyint'],
['NeedWeapon11', 'tinyint'],
['NeedWeapon12', 'tinyint'],
['NeedWeapon13', 'tinyint'],
['NeedWeapon14', 'tinyint'],
['NeedWeapon15', 'tinyint'],

['Shield', 'tinyint'],
['SP', 'short'],
['MP', 'short'],
['ReadyTime', 'tinyint'],
['ResetTime', 'short'],
['AttackRange', 'tinyint'],
['StateType', 'tinyint'],
['AttrType', 'tinyint'],
['Disable', 'short'],
['PrevSkillID', 'short'],
['SuccessType', 'tinyint'],
['SuccessValue', 'tinyint'],
['TargetType', 'tinyint'],
['ApplyRange', 'tinyint'],
['MultiAttack', 'tinyint'],
['KeepTime', 'short'],
['Weapon1', 'tinyint'],
['Weapon2', 'tinyint'],
['Weaponvalue', 'tinyint'],
['Bag', 'tinyint'],
['Arrow', 'short'],

['DamageType', 'tinyint'],
['DamageHP', 'short'],
['DamageSP', 'short'],
['DamageMP', 'short'],
['TimeDamageType', 'tinyint'],
['TimeDamageHP', 'short'],
['TimeDamageSP', 'short'],
['TimeDamageMP', 'short'],
['AddDamageHP', 'short'],
['AddDamageSP', 'short'],
['AddDamageMP', 'short'],

['AbilityType1', 'tinyint'],
['AbilityValue1', 'short'],
['AbilityType2', 'tinyint'],
['AbilityValue2', 'short'],
['AbilityType3', 'tinyint'],
['AbilityValue3', 'short'],

['HealHP', 'short'],
['HealSP', 'short'],
['HealMP', 'short'],
['TimeHealHP', 'short'],
['TimeHealSP', 'short'],
['TimeHealMP', 'short'],

['DefenseType', 'tinyint'],
['DefenseValue', 'tinyint'],
['LimitHP', 'tinyint'],
['FixRange', 'tinyint'],
['ChangeType', 'short'],
['ChangeLevel', 'short'],
]

def MainSkill(outFmt):
if (outFmt.export_complete):
return CombineSkill("Skill")
if (outFmt.csv_import or outFmt.csv_complete):
return ExtractSkill("Skill", outFmt)

def MainNPCSkill(outFmt):
if (outFmt.export_complete):
return CombineSkill("NpcSkill")
if (outFmt.csv_import or outFmt.csv_complete):
return ExtractSkill("NpcSkill", outFmt)

def CombineSkill(type):
csvIn = work_dir + type + ".complete.csv"
try:
csvf = csv.DictReader(open(csvIn))
except IOError:
sys.exit(MsgFileReadError % csvIn)

foutName = work_dir + type + ".SData"
try:
fout = open(foutName, mode='wb')
except IOError:
sys.exit(MsgFileWriteError % foutName)

recs = []
for row in csvf:
recs.append(row)
print "skill_rows: " + str(len(recs))

# Write Total.
record_total = struct.pack('I', (len(recs) / 9))
fout.write(record_total)

for i in recs:
pack_fields(fout, skill_types, i)
return True

def ExtractSkill(type, outFmt):
# Open SData File.
skillSData = feed_dir + type + ".SData"
try:
input = open(skillSData, mode='rb')
except IOError:
sys.exit(MsgFileReadError % skillSData)

header = get_data_headers(skill_types)

if (outFmt.csv_import):
filename = work_dir + type + ".import.csv"
header.pop(1) # Remove SkillDesc
header.pop(3) # Remove SkillAnim
header.pop(3) # Remove SkillIcon

if (outFmt.csv_complete):
filename = work_dir + type + ".complete.csv"

print("Creating " + filename)
# Open File for output.
try:
fout = open(filename, mode='wb')
except IOError:
sys.exit(MsgFileWriteError % filename)

fout_csv = csv.writer(fout)
fout_csv.writerow(header)
fout_csv = csv.DictWriter(fout, header)

record_total = unpack_field(input, 'int')

i = 0
j = 0
while True:
rec = unpack_fields(input, skill_types, {})

if (rec["SkillLevel"] == 1):
i += 1
j = 0
j += 1

if (outFmt.csv_import):
rec["SkillID"] = i

cs_rec = copyKeys(rec, header)
fout_csv.writerow(cs_rec)
if (i == record_total and j == 9):
break
return True

then save your work and you done it should now work correctly if im not mistaken its been a bit sense I edited mine but that think that's the only step

note: you only want to do this if your using the skills +3 fix from lph release

Doesn't work for me. I get this error

Code:

 Traceback (most recent call last):
  File "src\SData.py", line 25, in <module>
    from Skill import *
  File "C:\00\shaiya\Tools\shay_data_edit_0-1c\src\Skill.py", line 120
    if (outFmt.export_complete):
     ^
IndentationError: expected an indented block

[Alcatraz] · 07/28/2015, 21:40

is the link to the one im using.

try that one and let me know if its working for you or not it should be working because im about to do skill for ep5 with skills up to 9 levels.

Pave99 · 07/28/2015, 22:42

Quote:

Originally Posted by [Alcatraz]

is the link to the one im using.

try that one and let me know if its working for you or not it should be working because im about to do skill for ep5 with skills up to 9 levels.

Yessss. It works. Thank you very much

treica · 08/01/2015, 19:25

For what type of db is this made?

I use the EP5 DB but i can't seem to get it to work propertly (v0.7.5.5).

I have connected all server + database.

It doesn't want to update my Item.SData it shows me that saves but i make the patch and everything stays the same.

Monster.SData the same issue but while i try to run the SQL file generated from sdata

Code:

Msg 213, Level 16, State 1, Line 1
Column name or number of supplied values does not match table definition.

It looks like i require more columns in my database..
Did anybody else has similar issues in ep5 db?

Thanks,
Dani