[RELEASE] Name Change Fix by Shaiya Dev Group

[ProfNerwosol]

Here's a fix for Name Change Scroll. Again it's the nasty collation that was causing the trouble.

 Spoiler

USE [PS_GameData]
GO

ALTER TABLE Chars ALTER COLUMN [UserID] [varchar](12) COLLATE Chinese_PRC_Stroke_CI_AS NOT NULL
ALTER TABLE Chars ALTER COLUMN [OldCharName] [varchar](30) COLLATE Chinese_PRC_Stroke_CI_AS NULL
GO

DROP INDEX IX_Chars_CharName ON PS_GameData.dbo.Chars
GO

ALTER TABLE Chars ALTER COLUMN [CharName] [varchar](30) COLLATE Chinese_PRC_Stroke_CI_AS NOT NULL
GO

USE [PS_GameData]
GO
/****** Object: Index [IX_Chars_CharName] Script Date: 03/28/2010 10:17:12 ******/
CREATE NONCLUSTERED INDEX [IX_Chars_CharName] ON [dbo].[Chars]
(
[CharName] ASC
)WITH (PAD_INDEX = OFF, SORT_IN_TEMPDB = OFF, DROP_EXISTING = OFF, IGNORE_DUP_KEY = OFF, ONLINE = OFF) ON [PRIMARY]
GO

set ANSI_NULLS ON
set QUOTED_IDENTIFIER OFF
GO

I also found one line in a procedure that was uncommented which probably was causing trouble.

 Spoiler

ALTER   Proc [dbo].[usp_Save_Char_Name_E]

@ServerID tinyint,
@CharID int,
@OldCharName nvarchar(30),
@NewCharName nvarchar(30)

AS

SET NOCOUNT ON
--SET XACT_ABORT ON

--DECLARE @NameCnt int
--DECLARE @Ret int

SET @OldCharName = LTRIM(RTRIM(@OldCharName))
SET @NewCharName = LTRIM(RTRIM(@NewCharName))

--SET @Ret = 0

IF EXISTS ( SELECT CharID FROM Chars WHERE CharName=@NewCharName AND Del=0)
BEGIN
	RETURN -2
END

--BEGIN TRANSACTION

UPDATE Chars SET CharName=@NewCharName,RenameCnt=RenameCnt-1,OldCharName=@OldCharName WHERE CharID=@CharID AND Del=0
IF @@ERROR <> 0
BEGIN
	GOTO ERROR_ROLLBACK
END

UPDATE Guilds SET MasterName=@NewCharName WHERE MasterCharID=@CharID
--IF @@ERROR <> 0
--BEGIN
--	GOTO ERROR_ROLLBACK
--END
UPDATE FriendChars SET FriendName=@NewCharName WHERE FriendID=@CharID
--IF @@ERROR <> 0
--BEGIN
--	GOTO ERROR_ROLLBACK
--END
UPDATE BanChars SET BanName=@NewCharName WHERE BanID=@CharID
--IF @@ERROR <> 0
--BEGIN
--	GOTO ERROR_ROLLBACK
--END
INSERT INTO CharRenameLog( ServerID, CharID, CharName) VALUES(@ServerID, @CharID, @NewCharName )
--UPDATE PS_USERDB01.PS_UserData.dbo.CreatedChars SET CharName=@NewCharName WHERE ServerID=@ServerID AND CharID=@CharID
--IF @@ERROR <> 0
--BEGIN
--	GOTO ERROR_ROLLBACK
--END

--COMMIT TRANSACTION
RETURN 1


ERROR_ROLLBACK:
--ROLLBACK TRANSACTION
RETURN -2



SET NOCOUNT OFF

BY ... SHAIYA DEVELOPMENT Group

[Shaiya Xtreme]

Thanks so much for this release

[Jaden151]

I am trying to get this to work but I am not 100% sure where to insert this code. Anyone able to clarify that for me?

[auferhousethe]

you can insert this code into SQL Query Analyzer ^_^!

[ProfNerwosol]

Originally Posted by Jaden151

I am trying to get this to work but I am not 100% sure where to insert this code. Anyone able to clarify that for me?

I don't provide any support for the fix. You must have mistaken this forum with Microsoft Technical help or something.

[ShaiyaForever14]

I tried it and it hadn't worked ... Still name in use and still had to go to character screen . Pasted the code in a query and executed , also saved but nothing .

[[Dev]Cataclysm]

I am having a slight issue with the Name Change still. It will tell me the name is in use, but after a full complete relog, the new name appears >.>

My only concern with this is if someone tries to name change, and the name is really in use then they have wasted a Name change scroll (If they payed for it)

[mfrowen]

Thank you very much

[JohnHeatz]

There is a "Thanks" button, by pressing it you are "saying" thanks, there is no need to press it and make a post saying it.

[mfrowen]

Lol. Ok, I was only being polite :/

[akeness]

hi all, i entered those query and was successful. but the problem still exists. using the rename scroll from im, relogs and enters the new name still gives name already in use.

restarted the database and game services. still the same.
client and database used was episode 4.5

looking for an answer and thanks in advance.

Mark.