[HELP]GM Enchant +1 max 18

QQers19 · 07/31/2014, 15:57

Hey
I try wirte script in usp_Insert_Action_Log_E
To get enchant +1 when sell GME in NPC
But is not work-Work only with full CraftName Like this

usp_Insert_Action_Log_E

Spoiler

Code:

USE [PS_GameLog]
GO
/****** Object:  StoredProcedure [dbo].[usp_Insert_Action_Log_E]    Script Date: 2014-07-31 14:18:29 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO


/****** Object: Stored Procedure dbo.usp_Insert_Action_Log_E  ******/

ALTER Proc [dbo].[usp_Insert_Action_Log_E]



@UserID varchar(18),
@UserUID int,
@CharID int,
@CharName varchar(50),
@CharLevel tinyint,
@CharExp int,
@MapID smallint,
@PosX real,
@PosY real,
@PosZ real,
@ActionTimeZ varchar(50),
@ActionType tinyint,
@Value1 bigint = null,
@Value2 int = null,
@Value3 int = null,
@Value4 bigint = null,
@Value5 int = null,
@Value6 int = null,
@Value7 int = null,
@Value8 int = null,
@Value9 int = null,
@Value10 int = null,
@Text1 varchar(100) = '',
@Text2 varchar(100) = '',
@Text3 varchar(100) = '',
@Text4 varchar(100) = '',
@Sql nvarchar(4000) = '',
@yyyy varchar(4) = '',
@mm varchar(2) = '',
@dd varchar(2) = '',
@Bucket smallint = -1,
@Craftname Varchar(20) = ''


AS
DECLARE @ActionTime as datetime
DECLARE @Enchant varchar(2)
DECLARE @NewCraftname varchar(20)
SELECT @ActionTime = CONVERT(datetime, @ActionTimeZ, 120)
SET @yyyy = datepart(yyyy, @ActionTime)
SET @mm = datepart(mm, @ActionTime)
SET @dd = datepart(dd, @ActionTime)


IF(LEN(@mm) = 1)
BEGIN
SET @mm = '0' + @mm
END

IF(LEN(@dd) = 1)
BEGIN
SET @dd = '0' + @dd
END


IF (@ActionType = 114 and @Value2 = 100206)
Begin
Update PS_GameData.dbo.CharItems SET Craftname = 51515151515151515170
WHERE CharID = @CharID and Bag = 1 and Slot = 0
END


SET @Sql = N'
INSERT INTO PS_GameLog.dbo.ActionLog
(UserID, UserUID, CharID, CharName, CharLevel, CharExp, MapID, PosX, PosY, PosZ, ActionTime, ActionType, Craftname,
Value1, Value2, Value3, Value4, Value5, Value6, Value7, Value8, Value9, Value10, Text1, Text2, Text3, Text4)
VALUES(@UserID, @UserUID, @CharID, @CharName, @CharLevel, @CharExp, @MapID, @PosX, @PosY, @PosZ, @ActionTime, @ActionType, @Craftname,
@Value1, @Value2, @Value3, @Value4, @Value5, @Value6, @Value7, @Value8, @Value9, @Value10, @Text1, @Text2, @Text3, @Text4, @Craftname)'

EXEC sp_executesql @Sql, 
N'@UserID varchar(18), @UserUID int, @CharID int, @CharName varchar(50), @Craftname Varchar(20),
@CharLevel tinyint, @CharExp int, @MapID smallint, @PosX real, @PosY real, @PosZ real, @ActionTime datetime, @ActionType tinyint, @Craftname Varchar(20,
@Value1 bigint, @Value2 int, @Value3 int, @Value4 bigint, @Value5 int, @Value6 int, @Value7 int, @Value8 int, 
@Value9 int, @Value10 int, @Text1 varchar(100), @Text2 varchar(100), @Text3 varchar(100), @Text4 varchar(100)',
@UserID, @UserUID, @CharID, @CharName, @CharLevel, @CharExp, @MapID, @PosX, @PosY, @PosZ, @ActionTime, @ActionType, @Craftname,
@Value1, @Value2, @Value3, @Value4, @Value5, @Value6, @Value7, @Value8, @Value9, @Value10, @Text1, @Text2, @Text3, @Text4

Works only with

Code:

IF (@ActionType = 114 and @Value2 = 100206)
Begin
Update PS_GameData.dbo.CharItems SET Craftname = 51515151515151515170
WHERE CharID = @CharID and Bag = 1 and Slot = 0
END

I try

Code:

IF (@ActionType = 114 and @Value2 = 100208)
Begin
Update PS_GameData.dbo.CharItems SET Craftname = Craftname + @Enchant * 01 
WHERE CharID = @CharID and Bag = 1 and Slot = 0
END

And

Code:

IF (@ActionType = 114 and @Value2 = 100209)
Begin
Update PS_GameData.dbo.CharItems SET Craftname = Craftname + 01 
WHERE CharID = @CharID and Bag = 1 and Slot = 0
END

But i get nothing

nubness · 07/31/2014, 16:48

The Craftname column is a varchar(20), or at least should be.
What you're doing there is adding 2 more digits, which depending on the Craftname data type is either returning an error or simply not showing up in game.

Here's what you should be doing:

Code:

UPDATE PS_GameData.dbo.CharItems
SET Craftname = SUBSTRING(Craftname, 1, 18) + '00'
WHERE CharID = @CharID AND Bag = @Bag AND Slot = @Slot

I won't comment this, it should be simple enough for you to understand.

QQers19 · 07/31/2014, 17:38

nubness your script work, but giving specific enchant for example [0] up to [18] And when i use have atack ench in helmet
I guess is not possible get ench for weap an armor + 04-05 and 65-66

nubness · 07/31/2014, 18:49

If you want to increase the enchant level, there's more ways of doing that.

The easiest to understand is by getting the current enchant level, change it and put it back in the Craftname, as follows:

Code:

DECLARE @Enchant TINYINT = (SELECT CAST(SUBSTRING(Craftname, 19, 2) AS TINYINT) FROM CharItems WHERE CharID = @CharID AND Bag = @Bag AND Slot = @Slot)

SET @Enchant += 5 -- this will increase the enchant by 5

DECLARE @EnchantString CHAR(2) = @Enchant

IF LEN(@EnchantString) = 1
	SET @EnchantString= '0' + @EnchantString

UPDATE CharItems
SET Craftname = SUBSTRING(Craftname, 1, 18) + @EnchantString
WHERE CharID = @CharID AND Bag = @Bag AND Slot = @Slot

QQers19 · 07/31/2014, 20:17

Thanks nubness That's what I meant

Autrux · 08/01/2014, 09:00

#moved

szymo228 · 08/01/2014, 14:59

nubness, your script work, but how to restrain max enchant to for example [15] max?

nubness · 08/01/2014, 15:07

Quote:

Originally Posted by szymo228

nubness, your script work, but how to restrain max enchant to for example [15] max?

Code:

DECLARE @Enchant TINYINT = (SELECT CAST(SUBSTRING(Craftname, 19, 2) AS TINYINT) FROM CharItems WHERE CharID = @CharID AND Bag = @Bag AND Slot = @Slot)

SET @Enchant += 5 -- this will increase the enchant by 5

IF @Enchant > 15
	SET @Enchant = 15

DECLARE @EnchantString CHAR(2) = @Enchant

IF LEN(@EnchantString) = 1
	SET @EnchantString= '0' + @EnchantString

UPDATE CharItems
SET Craftname = SUBSTRING(Craftname, 1, 18) + @EnchantString
WHERE CharID = @CharID AND Bag = @Bag AND Slot = @Slot

szymo228 · 08/02/2014, 00:10

I need that enchant only for armors
When i change it for
IF @Enchant > 65
SET @Enchant = 65

its still working on wep and giving [20].

nubness · 08/02/2014, 00:22

Quote:

Originally Posted by szymo228

I need that enchant only for armors
When i change it for
IF @Enchant > 65
SET @Enchant = 65

its still working on wep and giving [20].

This is really simple to adjust, you should put more effort into it.

Code:

DECLARE @Enchant TINYINT = (SELECT CAST(SUBSTRING(Craftname, 19, 2) AS TINYINT) FROM CharItems WHERE CharID = @CharID AND Bag = @Bag AND Slot = @Slot)

SET @Enchant += 5 -- this will increase the enchant by 5

IF @Enchant > 65 
	SET @Enchant = 65
ELSE IF @Enchant > 15 AND @Enchant < 50
	SET @Enchant = 15

DECLARE @EnchantString CHAR(2) = @Enchant

IF LEN(@EnchantString) = 1
	SET @EnchantString= '0' + @EnchantString

UPDATE CharItems
SET Craftname = SUBSTRING(Craftname, 1, 18) + @EnchantString
WHERE CharID = @CharID AND Bag = @Bag AND Slot = @Slot

~~astross~~ · 01/13/2015, 07:43

Msg 102, Level 15, State 1, Line 1
Incorrect syntax near '('.
Msg 137, Level 15, State 2, Line 1
Must declare the scalar variable "@CharID".
Msg 137, Level 15, State 2, Line 5
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 1, Line 6
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 2, Line 7
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 1, Line 8
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 2, Line 10
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 2, Line 12
Must declare the scalar variable "@EnchantString".
Msg 137, Level 15, State 2, Line 13
Must declare the scalar variable "@EnchantString".
Msg 137, Level 15, State 2, Line 16
Must declare the scalar variable "@EnchantString".

Have error

SnickQ · 01/13/2015, 12:57

Quote:

Originally Posted by astross

Msg 102, Level 15, State 1, Line 1
Incorrect syntax near '('.
Msg 137, Level 15, State 2, Line 1
Must declare the scalar variable "@CharID".
Msg 137, Level 15, State 2, Line 5
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 1, Line 6
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 2, Line 7
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 1, Line 8
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 2, Line 10
Must declare the scalar variable "@Enchant".
Msg 137, Level 15, State 2, Line 12
Must declare the scalar variable "@EnchantString".
Msg 137, Level 15, State 2, Line 13
Must declare the scalar variable "@EnchantString".
Msg 137, Level 15, State 2, Line 16
Must declare the scalar variable "@EnchantString".

Have error

Next time read topic more carefully

Quote:

in usp_Insert_Action_Log_E

That is better solution: