Memory Read (Not Working)

[Shortpants]

Fixed :]

[Interest07]

you use offset[4] here:

$NPC_ID_OFFSET[4] = $i * 0x00000004

and offset[5] here

$NPC_CURRENT_HP_OFFSET[5] = $i * 0x00000004

whatever else is going on, I can't imagine that being correct

That being said,

$NPC_COUNT_OFFSET[1] = 0x0000001C
$NPC_COUNT_OFFSET[2] = 0x0000001C
$NPC_COUNT_OFFSET[3] = 0x00000024
$NPC_COUNT_OFFSET[4] = 0x00000014

would be the size of the NPC list, so you don't have to loop through 769 values.

Also, HP values of NPCs don't get updated until you've selected them.

[Shortpants]

Originally Posted by Interest07

you use offset[4] here:

$NPC_ID_OFFSET[4] = $i * 0x00000004

and offset[5] here

$NPC_CURRENT_HP_OFFSET[5] = $i * 0x00000004

whatever else is going on, I can't imagine that being correct

I fixed that, NPC_ID_OFFSET[4] is now [5] as well. ( Sorry, I tried a lot of things )

2148532959 - 0/0
2148533140 - 0/0
2148533142 - 0/0
2148533143 - 0/0
2148533144 - 38336/38336
2148533145 - 0/0
2148533146 - 0/0
2148533147 - 0/0
2148533166 - 0/0
2148533167 - 0/0
2148533168 - 0/0
2148533257 - 0/0
2148533311 - 0/0
2148533312 - 0/0
2148533313 - 0/0
2148533314 - 0/0
2148533316 - 0/0
2148533359 - 0/0
2148532841 - 0/0
2148532843 - 0/0
2148532849 - 0/0
2148532843 - 0/0
2148532849 - 0/0
2148532849 - 0/0
2148532845 - 0/0
2148532849 - 0/0
3361502062 - 828125655/1953393007

Still,, makes no sense. ( I have been trying to figure it out for hours now ).
Edit: As you can see the ID works, but max/current hp doesnt.

[Sᴡoosh]

Keep in mind that the HP/Max HP is only sent from server if you target the NPC. Otherwise it's not loaded.

[Shortpants]

Then what is the x * 4 for?

[Sᴡoosh]

Originally Posted by Shortpants

Then what is the x * 4 for?

That's what resolves the pointer to the individual NPC structures.

Pointers are 4 byte in 32 bit processes, so that+ why it's i * 4. The i is the index, i.e the place where mob is found in list. I guess you're using unsorted mob list? I didn't check your offsets/code

Edit : yeah, you are using unsorted one.

[Shortpants]

Originally Posted by Sᴡoosh

That's what resolves the pointer to the individual NPC structures.

Pointers are 4 byte in 32 bit processes, so that+ why it's i * 4. The i is the index, i.e the place where mob is found in list. I guess you're using unsorted mob list? I didn't check your offsets/code

Edit : yeah, you are using unsorted one.

I am targeting mobs using packets.

It will select the first monster ( this takes a while because it's using packets to target), then it will wait until the target state ( BASE+0x34+0xBB4 ) is different than zero.

Then it will hit an other loop where it will wait until the monster is dead.

The thing is that it will try to target already-dead targets because they're not removed from the index instantly. Resulting in an infinite loop.

The only thing that I can think of ( since checking whether the current target is different than the last one, is still not fast enough ).. is to check the monster HP before actually targeting it. :-/

Since you stated such thing is impossible, then, what is a good different approach?

[Sᴡoosh]

+0x02C8

(1 - Idle; 2 - Physical Attack; 3 - Magical (ranged) Attack; 4 - Die animation; 5 - Moving)

[Shortpants]

Originally Posted by Sᴡoosh

+0x02C8

(1 - Idle; 2 - Physical Attack; 3 - Magical (ranged) Attack; 4 - Die animation; 5 - Moving)

Hmmm..? What is that supposed to mean?

[Sᴡoosh]

That you can find out if the mob you're trying to target is already dead, but still in list because of unfinished dieing animation.

[Shortpants]

Thanks alot sir! Works like a charm now :]]

[Sᴡoosh]

Nice to hear

[Shortpants]

Which pop-ups a question, how would you integrate Anti- KillSteal?

[Interest07]

Originally Posted by Shortpants

Which pop-ups a question, how would you integrate Anti- KillSteal?

Several ways really:

Before targeting a new mob for killing:
-check if it's full HP
-check if it isn't actively targeting something else (compare its targetId with your playerId and/or your petId, make sure its aggressive flag is also set)
-you could check if it's moving towards a certain player ('complicated')
-check if it's next to another player
-...

So just implement a function isMobAvailable(NPC* npc, int yourId) which uses 1 or more of the above checks and return a true or false.

Then whenever you're done killing your current target, loop through the npc list, check whether one of them is already attacking you (kill this first), and otherwise find the closest that is available.

[dumbfck]

Just a quick note... It's potentially helpful if you leave your posts intact when your problem is fixed rather than editing them to just "fixed" - That way, others can see if the problem relates to a similar problem they might be facing and if the thread is relevant to them