[OPEN SOURCE] Moonlight

[Blowa]

Originally Posted by iArtrix

Och I like argument ad personam and I know.

I don't except antything it's you project.

I can't in CPP and push only small changes. I don't evaluate your code, but the whole project, without documentation has no value.

Lack of documentation is the main problem, most people on this forum haven't experience with programming (like me XD).

PS. Keep calm and more chilled gentlemans.

PS2. Nestle developing is serious business

From what I know and what I'm used, a self explanatory code is a good documentation, at first.

Secondly, there are unit tests written by Roxeez (even thought it does not cover all use cases, it supports most common cases), it's another kind of documentation.

Thirdly, most of methods are documented, any sense developer that sees Roxeez's project would use it as a submodule repository (no other choice, there is no package yet published), the source is accessible.

And, my point of view is that Roxeez wastes his time on this project because there are only few able to use that.
Also cause this community does not deserve that kind of work, people will just leech it or expect a drag & drop project to make money with it rather than supporting Roxeez's work.
But I still respect his choice and his work.

[Roxeez]

Originally Posted by iArtrix

Lack of documentation is the main problem, most people on this forum haven't experience with programming (like me XD).

Well that's not my problem, i'm not gonna teach them.

Everything is not commented/documented but in most case a good method/property/field name is enough to understand what is going on if you use it.

Character.Hp -> Character hp
Character.Map -> Character map
Map.Players -> Players on map
Map.GetEntity(EntityType, EntityId) -> GetEntity according to entity type & id

And even with good naming, most of public methods/properties are still documented with xml comments.

/// <summary>
///     Walk until character is in range of the specific position
/// </summary>
/// <param name="position">Target position</param>
/// <param name="range">Range</param>
public async Task WalkInRange(Position position, int range)

So i guess you didn't watched the project at all before saying it's a shitty project without documentation OR by documentation you're talking about how to setup a project and that's exactly what's in github readme getting started section.

Ofc that's not fully explained people need to make some research about DllExport, Injector etc.. but any decent developer can do it easily and if there is a bug or something they can just contact me on discord or open a GitHub issue but i'm not gonna give a drag & drop project.

And btw i don't give a fuck if nobody use it because it's "to hard" i'm making it because i've fun developing it and i'm just sharing it because i think it can be useful to some people

[qwe1234622]

you should just ignore negative comments lol, you are the creator and those negative comments are stupid which this is already an open-source which is free stuff. I don't get why people are complaining about free stuff while they are just sitting here and judging. I mean they could suggest but not to complain unless this is what they paid for.

btw its a really cool project even though i know nothing about coding and just downloaded visual studio, but i think i will start learning a bit of coding and google it just so i could be lazy and use this bot xd.

Thank you so much (**** i feel positive)

[Bejine]

Originally Posted by qwe1234622

you should just ignore negative comments lol, you are the creator and those negative comments are stupid which this is already an open-source which is free stuff. I don't get why people are complaining about free stuff while they are just sitting here and judging.

I'm not trying to defend iArtrix, but this argument really ****** me off. If you got a free sample at a shop, and it tasted horribly (and I'm not saying Roxeez's project is bad), would you also not complain and tell that to the person, because it was free?

[ryuuzaki77]

Originally Posted by iArtrix

No, it's another ****** project without documentation. Sorry but you know how this use probably you can write own code.

I'm not even a C# / .NET developer and know how to use this project and it's actually pretty good, you don't really NEED a documentation for a project like this if you can actually understand what has been done there. He actually even made an Example and a little guide to set it up, don't know what you need more to know how this works

Actually I don't really have experience about all that ASM thing and this project makes it actually easy to develop without all that part (until the patterns change then you will have to fix it yourself )

If you want to criticize this project give some more arguments and some improvements he should do not just "****** project no documentation lol"

If you don't know programming try to learn how to if it really interests you and start with some smaller projects, this kind of project is not only for cheating on games but to learn how it works

[Worldie]

poceblo Roxeez

[Blowa]

Post before Roxeez writes a 3d Nostale version NO EMULATOR BULLSHIT in a few months only

[Singleplayer™]

the first good release since ON,
keep this thing up , good job

[Ekk*]

This actually looks pretty cool, nice job! However, are you sure it is safe to support remote client? Can't they know whether someone is logging in with or without the official client?

[Roxeez]

Originally Posted by Ekk*

This actually looks pretty cool, nice job! However, are you sure it is safe to support remote client? Can't they know whether someone is logging in with or without the official client?

Idk but i've made bunch of clientless app in the past without problem

[Ekk*]

Hello again. Thanks for your first answer, if you say so, it shouldn't be an issue then!

I have some tiny remarks about your code after lurking some part of it.

- Why did you make your own "ThreadSafeDictionary<K, V>" when "ConcurrentDictionary<K, V>" exists in .NET FX4.7+
- Same goes for your "ThreadSafeList<T>"

- AssemblyExtensions.GetAssignableTypes<T>(this Assembly assembly);
Couldn't you avoid double enumeration by merging the two Where statements? (it's just about micro-optimization )

Thanks again for your great work. That's really neat.

[Roxeez]

Originally Posted by Ekk*

Hello again. Thanks for your first answer, if you say so, it shouldn't be an issue then!

I have some tiny remarks about your code after lurking some part of it.

- Why did you make your own "ThreadSafeDictionary<K, V>" when "ConcurrentDictionary<K, V>" exists in .NET FX4.7+
- Same goes for your "ThreadSafeList<T>"

- AssemblyExtensions.GetAssignableTypes<T>(this Assembly assembly);
Couldn't you avoid double enumeration by merging the two Where statements? (it's just about micro-optimization )

Thanks again for your great work. That's really neat.

ThreadSafeList/Dictionary was at the beginning my current InternalObservableList/Dictionary and i've just splitted both into different collection without thinking of replacing InternalThreadSafeList of both observable collections with already existing ConcurrentBag/Dictionary

And about extension it's just for readability, this method is just called twice on startup so performance is not a problem.

[Roxeez]

Here is some bot i've made for a friend using Moonlight. (Just to show you what you can actually do using Moonlight)

 Pii Bot

 Minigame Bot

I've also made a party timespace stone bot but no point to share a screenshot since it's just a start/stop button
Btw since DllExport is now fully supporting .NET Core 3, i'm gonna work on migrating Moonlight from .NET Framework to .NET Core asap.