Register for your free account! | Forgot your password?

You last visited: Today at 10:50

  • Please register to post and access all features, it's quick, easy and FREE!


[C++]Check Moving Item minor bug fix

Reply
 
Old   #1
 
elite*gold: 30
Join Date: Mar 2012
Posts: 517
Received Thanks: 329
[C++]Check Moving Item minor bug fix

Hello

Most of u will ignore it ( even ymir did ) but there's somepeoples who love to keep it all clean , even the small non effect bug

Before fix the bug :



After :


#UPDATE
I've fix also fix this bug :

and another bug related to inventory



To fix it :
Client Source / EterPythonLib/PythonGridSlotWindow.cpp
Serach for fucntion :
Code:
BOOL CGridSlotWindow::CheckMoving(DWORD dwSlotNumber, DWORD dwItemIndex, const std::list<TSlot*> & c_rSlotList)
replace with this :
Code:
BOOL CGridSlotWindow::CheckMoving(DWORD dwSlotNumber, DWORD dwItemIndex, const std::list<TSlot*> & c_rSlotList)
{
	if (m_dwSlotStyle != SLOT_STYLE_PICK_UP)
		return TRUE;

	for (std::list<TSlot*>::const_iterator itor = c_rSlotList.begin(); itor != c_rSlotList.end(); ++itor)
	{
		TSlot * pSlot = *itor;
		
		if (0 != pSlot->dwItemIndex || pSlot->dwCenterSlotNumber != pSlot->dwSlotNumber) // 아이템이 있고
		{
			if (dwItemIndex != pSlot->dwItemIndex || c_rSlotList.size() != 1) // 다른 아이템이면 못 옮김
				return false;
		}
	}

	return true;
}
Now Save and compile




MrLibya is offline  
Thanks
12 Users
Old 03/12/2017, 16:03   #2
 
elite*gold: 330
Join Date: Jan 2012
Posts: 1,833
Received Thanks: 1,308
Esthetic fix on a high level. I like these kind of attention.


MaxChri is offline  
Thanks
3 Users
Old 03/12/2017, 17:02   #3
 
elite*gold: 0
Join Date: Jun 2013
Posts: 171
Received Thanks: 44
Do you have any solution when you trying to move the item on the 1x slot at the top?
try with a 2 hand or 3 hand weapon and put it on the second slot and try to move it up, you can see the white slot but the weapon aren't able to move 1x slot up. (remove your fix first).

EULOG1SON is offline  
Old 03/12/2017, 23:01   #4
 
elite*gold: 30
Join Date: Mar 2012
Posts: 517
Received Thanks: 329
Quote:
Originally Posted by EULOG1SON View Post
Do you have any solution when you trying to move the item on the 1x slot at the top?
try with a 2 hand or 3 hand weapon and put it on the second slot and try to move it up, you can see the white slot but the weapon aren't able to move 1x slot up. (remove your fix first).

I've fix it and update the topic , i also fix another bug related inventory


MrLibya is offline  
Thanks
1 User
Old 03/19/2017, 23:36   #5
 
elite*gold: 30
Join Date: Mar 2012
Posts: 517
Received Thanks: 329
Topic Updated
MrLibya is offline  
Old 09/24/2017, 16:24   #6
 
elite*gold: 50
Join Date: May 2011
Posts: 266
Received Thanks: 980
Hello,

Here is an update for this fix, because it isnt' complete. If you are moving an item which size is > 1 onto the same item that makes false value.
Rubinum:



Gallery 1


I didn't find any bugs, but if you will, feel free to explain how did you find it.
xP3NG3Rx is offline  
Thanks
9 Users
Old 09/24/2017, 23:02   #7
 
elite*gold: 0
Join Date: Oct 2013
Posts: 115
Received Thanks: 191
Quote:
Originally Posted by xP3NG3Rx View Post
Hello,

Here is an update for this fix, because it isnt' complete. If you are moving an item which size is > 1 onto the same item that makes false value.
Rubinum:



Gallery 1


I didn't find any bugs, but if you will, feel free to explain how did you find it.
Omgg thanks boyyy
.T4Ump is offline  
Old 09/25/2017, 19:22   #8
 
elite*gold: 0
Join Date: Sep 2017
Posts: 10
Received Thanks: 0
nice...
HKwork is offline  
Old 12/10/2017, 14:01   #9
 
elite*gold: 0
Join Date: Mar 2011
Posts: 3
Received Thanks: 0
Quote:
Originally Posted by xP3NG3Rx View Post
Hello,

Here is an update for this fix, because it isnt' complete. If you are moving an item which size is > 1 onto the same item that makes false value.
Rubinum:



Gallery 1


I didn't find any bugs, but if you will, feel free to explain how did you find it.

In official, I can move the item x1 slot or x2 slot to up or down, but in your fix I'm not able to do that, only if I put the item in the first page of inventory I could only move the item down .


plz fix that






.
jeddawee is offline  
Old 02/20/2018, 10:47   #10
 
elite*gold: 50
Join Date: Aug 2014
Posts: 505
Received Thanks: 201
Also bei mir funktioniert es nicht, hat jemand einen fix?
x"Kazuki is offline  
Old 02/28/2018, 11:35   #11
 
elite*gold: 0
Join Date: Nov 2014
Posts: 29
Received Thanks: 1
nice


pask94 is offline  
Reply



« [Release]Natural boss 1 | [Release]Ingame Wiki by .Kori »

Similar Threads
[Fix] Minor item shop security issue
03/23/2016 - Metin2 PServer Guides & Strategies - 1 Replies
Hi, while looking through the servers source code I received in 2013 I found a minor security issue regarding the item shop. An attacker is able to temporarily delete items bought in the item shop from the game, so the buyer is unable to receive it. All deleted items are restored after the server restarts though, as they are only removed from the databases cache, not from the database itself. Also the attacker can only remove the item from the cache if the user didn't login after buying it...
Adding NEW ITEM. But not moving with char. [HELP]
07/15/2012 - SRO PServer Ask the Experts - 3 Replies
Hey guys. I'm adding a new Chest for EU, H.ARMOR. But when i do this, the item is not moving with char. staying where it is. you can see in pic.: http://i.imgur.com/BbYrK.jpg And this is full view of item.: http://i.imgur.com/wFcP7.png What am i doing wrong? Look, and this is the pic of model in Blender & Autodesk Maya 2013.: Blender: http://i.imgur.com/AAwcp.png Autodesk Maya 2013: http://i.imgur.com/huKXQ.png
How to check id of an item...
12/04/2008 - WoW Main - Discussions / Questions - 5 Replies
Like in the topic: I want to know can I and how to check id number of an item on a private server.



All times are GMT +1. The time now is 10:50.


Powered by vBulletin®
Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.
SEO by vBSEO ©2011, Crawlability, Inc.

Support | Contact Us | FAQ | Advertising | Privacy Policy | Abuse
Copyright ©2018 elitepvpers All Rights Reserved.