[C++]DevilTower minor bug fix

[MrLibya]

Hello

It's a minor bug but it's important , when u kill the devil tower boss and get ur reward and try to upgrade ur weapon or anything if u press yes and u haee money less then the cost u will lost the reward .

so here even if u have no money u will not lost the reward

to fix it :
open input_main.cpp

add : 
#include "refine.h"
// find this
    if (!item)
    {
        ch->ClearRefineMode();
        return;
    }
// a new code block
    const TRefineTable * prt = CRefineManager::instance().GetRefineRecipe(item->GetRefineSet());
    if (!prt)
    {
        ch->ClearRefineMode();
        return;
    }  
now search for : 
if (ch->GetQuestFlag("deviltower_zone.can_refine"))
replace the whole condition with this : 
if (ch->GetQuestFlag("deviltower_zone.can_refine"))
                {
                    if (ch->GetGold() >= prt->cost)
                    {
                        ch->DoRefine(item, true);
                        ch->SetQuestFlag("deviltower_zone.can_refine", 0);
                    }
                    else
                        ch->ChatPacket(CHAT_TYPE_INFO, LC_TEXT("±¹°ي؟، µ·ہج ؛خء·اد°إ³ھ µ·ہ» °،ء®؟أ¼ِ ¾ّ´آ »َب²ہش´د´ظ"));
                }

sry 4 my english

[MaxChri]

Nice thanks for the fix. I still can remember the bug again.

[Metin2 Team]

well done

PHP Code:

// find this
    if (!item)
    {
        ch->ClearRefineMode();
        return;
    }
// a new code block
    const TRefineTable * prt = CRefineManager::instance().GetRefineRecipe(item->GetRefineSet());
    if (!prt)
    {
        ch->ClearRefineMode();
        return;
    } 


should look like this because it might cause a crash if the proto is null.

[MrLibya]

Originally Posted by Metin2 Team

well done

PHP Code:

// find this
    if (!item)
    {
        ch->ClearRefineMode();
        return;
    }
// a new code block
    const TRefineTable * prt = CRefineManager::instance().GetRefineRecipe(item->GetRefineSet());
    if (!prt)
    {
        ch->ClearRefineMode();
        return;
    } 


should look like this because it might cause a crash if the proto is null.

Oh , thx i will update the topic

[EULOG1SON]

Find:

 Spoiler

if (!item)
{
ch->ClearRefineMode();
return;
}

Replace it with:

 Spoiler

const TRefineTable * prt = CRefineManager::instance().GetRefineRecipe(item->GetRefineSet());
if (!item || !prt)
{
ch->ClearRefineMode();
return;
}

[Yiv]

You can just check the return value of the DoRefine function:

Replace this:

if (ch->GetQuestFlag("deviltower_zone.can_refine"))
{
	ch->DoRefine(item, true);
	ch->SetQuestFlag("deviltower_zone.can_refine", 0);
}

with this:

if (ch->GetQuestFlag("deviltower_zone.can_refine"))
{
	if (ch->DoRefine(item, true))
	{
		ch->SetQuestFlag("deviltower_zone.can_refine", 0);
	}
}

I just did a real quick look but the DoRefine function returns false if the requirements to do the upgrade are not fulfilled by the player so this should be enough.

Regards