[C++] Check position for shops

wezt · 11/07/2016, 11:41

Hello!

I'd like to show you how you can check position for shops (probably offline shops too).
I don't like when the map is full of shops or when shops are too close for each other. So I've made few functions for checking if the shop is in safezone or if it too close to other shops.

Let's start

char.h

Find there:

Code:

		void			CloseMyShop();

	protected:

		LPSHOP			m_pkShop;
		LPSHOP			m_pkMyShop;
		std::string		m_stShopSign;
		LPCHARACTER		m_pkChrShopOwner;

Add few new lines:

Code:

		void			CloseMyShop();
		void			SetShopValidPos(bool value) { m_bShopValidPos = value; }
		bool			GetShopValidPos() { return m_bShopValidPos; }

	protected:

		LPSHOP			m_pkShop;
		LPSHOP			m_pkMyShop;
		std::string		m_stShopSign;
		LPCHARACTER		m_pkChrShopOwner;
		bool			m_bShopValidPos;

char.cpp

In 'void CHARACTER::Initialize()' find:

Code:

	m_pkMyShop		= NULL;

Add below:

Code:

	m_bShopValidPos = true;

Then search for 'void CHARACTER::OpenMyShop(const char * c_pszSign, TShopItemTable * pTable, BYTE bItemCount)'

Add above new function:

Code:

struct CheckShopPos
{
	LPCHARACTER m_ch;
	CheckShopPos(LPCHARACTER ch)
	{
		m_ch = ch;
	}

	void operator()(LPENTITY ent)
	{
		if (ent->IsType(ENTITY_CHARACTER))
		{
			LPCHARACTER ch = (LPCHARACTER) ent;
			if (ch->GetRaceNum()!=30000) //shop mob vnum
				return;

			if (DISTANCE_APPROX(ch->GetX() - m_ch->GetX(), ch->GetY() - m_ch->GetY()) < 200) //distance between shops
			{
				m_ch->SetShopValidPos(false);
			}
		}
	}
};

Then in 'void CHARACTER::OpenMyShop(const char * c_pszSign, TShopItemTable * pTable, BYTE bItemCount)' search for:

Code:

	if (bItemCount == 0)
		return;

Add below:

Code:

	//shops pos check
	LPSECTREE sectree = GetSectree();
	if (sectree)
	{

		SetShopValidPos(true);

		CheckShopPos f(this);
		sectree->ForEachAround(f);

		if(!GetShopValidPos())
		{
			ChatPacket(CHAT_TYPE_INFO, "You cannot open a shop here (too close to other shop).");
			return;
		}

		if (!sectree->IsAttr(GetX(), GetY(), ATTR_BANPK))
		{
			ChatPacket(CHAT_TYPE_INFO, "You cannot open a shop here (use safezone).");
			return;
		}
	}
	//shops pos check

P.S.:
1. Make backups before change your source.
2. If you'll repost this solution somewhere, please keep credits.
3. Likes and comments appreciated.

That's all, have fun

Regards.

_xmr · 11/08/2016, 20:24

Stop using nested conditionals
Use that instead:

Code:

if (!sectree)
    return;

Also, why do you declare sectree as NULL?

Code:

LPSECTREE sectree = GetSectree();

And you don't need to define bShopValidPos in the Initialize method
Just define it in the declaration

wezt · 11/09/2016, 12:04

Hey, thanks for your reply.

Quote:
Originally Posted by _xmr
Stop using nested conditionals
Use that instead:
Code:
if (!sectree)
    return;

I don't see any problems with it, there a lot of such conditionals in whole source (don't sure if it's right or not, but it works), examples:

Spoiler

Already applied this:

Code:

LPSECTREE sectree = GetSectree();

And I've added m_bShopValidPos in the Initialize method because as far I know each variable should be initialized.

Regards.

~~悪地城~~ · 11/12/2016, 03:34

I really like this function, thx for the rls.

AcronicDesign · 11/19/2016, 12:54

Thank you for posting