[C++]FIX Cube_request_result_list: Too long cube result list text

[Exygo]

How to fix Cube_request_result_list: Too long cube result list text. ?


1. Go in cube.cpp

2. Replace:

        if (resultText.size() - 20 >= CHAT_MAX_LEN)
        {
            sys_err("[CubeInfo] Too long cube result list text. (NPC: %d, length: %d)", npcVNUM, resultText.size());
            resultText.clear();
            resultCount = 0;
        }

With this:

 Spoiler

        int WildFantasytFIXED;
        if (resultText.size() < 20)
        {
            WildFantasytFIXED = 20 - resultText.size();
        }
        else
        {
            WildFantasytFIXED = resultText.size() - 20;
        }
        if (WildFantasytFIXED >= CHAT_MAX_LEN)
        {
            sys_err("[CubeInfo] Too long cube result list text. (NPC: %d, FIXED_size_value_exygo: %d, length: %d)", npcVNUM, WildFantasytFIXED, resultText.size());
            resultText.clear();
            resultCount = 0;
        }

The problem was caused by a comparison between a negative number and a number

[.Shōgun]

Sorry, it's not this one xD never mind

[Isolation_]

Hier noch eine Version:

        int resultsize = (resultText.size() < 20) ? (20 - resultText.size()) : (resultText.size() - 20);
        if (resultsize >= CHAT_MAX_LEN)
        {
            sys_err("[CubeInfo] Too long cube result list text. (NPC: %d, resultsize: %d, length: %d)", npcVNUM, resultsize, resultText.size());
            resultText.clear();
            resultCount = 0;
        }

So ganz ohne Werbung und etwas kürzer. Eigentlich kann man sich sogar die Variable schenken.

[rollback]

Originally Posted by Isolation_

Hier noch eine Version:

        int resultsize = (resultText.size() < 20) ? (20 - resultText.size()) : (resultText.size() - 20);
        if (resultsize >= CHAT_MAX_LEN)
        {
            sys_err("[CubeInfo] Too long cube result list text. (NPC: %d, resultsize: %d, length: %d)", npcVNUM, resultsize, resultText.size());
            resultText.clear();
            resultCount = 0;
        }

So ganz ohne Werbung und etwas kürzer. Eigentlich kann man sich sogar die Variable schenken.

Und kürzer ist besser?
Finde die Lesbarkeit sehr wichtig.
Deine Lösung finde ich besser zu lesen als die des erstellers, das ganze allerdings direkt im if block zu schreiben wäre meiner Meinung nach allerdings zu unübersichtlich.

[fcsk_aim]

This fix it's useless.
I never had this in my syserr. :d

[rollback]

Originally Posted by fcsk_aim

This fix it's useless.
I never had this in my syserr. :d

My gf never got pregnant yet, why should i prevent?

[fcsk_aim]

Originally Posted by Seחsi

My gf never got pregnant yet, why should i prevent?

There's nothing to prevent.

[JeyMaker]

Originally Posted by .Shōgun

Sorry, it's not this one xD never mind

Sorry it's not this one -> xD <- Yes I think u r a bit mad today?

[Lefloyd]

Warum kam eigentlich keiner auf die Idee einfach eine int-Konvertierung zu benutzen? o_o

[Mashkin]

Originally Posted by Lefloyd

Warum kam eigentlich keiner auf die Idee einfach eine int-Konvertierung zu benutzen? o_o

And why not just do this - which will only fail if CHAT_MAX_LEN > MAX_INT - 20.
This is basic math.

if (resultText.size() >= CHAT_MAX_LEN + 20)

This inequation also shows that the original code is pretty much bullshit because the resultText is asserted to be 20 characters longer than CHAT_MAX_LEN.
In fact, resultText should be at maximum 20 characters shorter than CHAT_MAX_LEN.

The number 20 comes from the string to which resultText is appended which is assumed 14 + 6 = 20 characters in length.
In the code, the inserted numbers are assumed to be at maximum 5 and 1 characters long.
This might not be true for NPCs with vnums greater than 99.999 or(vnums ares of type WORD) more than 9 results.

Deducing 20 from CHAT_MAX_LEN thus does not safely determine the maximum length for resultText in some quite realistic cases, especially as resultCount and with it (on average proportionally) resultText's length grow.

ch->ChatPacket(CHAT_TYPE_COMMAND, "cube r_list %d %d %s", npcVNUM, resultCount, resultText.c_str());
// example: "cube r_list 20383 4 ..."

As becomes clear the function is actually broken in several ways, and your proposed change only removes one minor issue of it.

Your turn to fix this.

[DasSchwarzeT]

Originally Posted by Seחsi

My gf never got pregnant yet, why should i prevent?

Don't even expect her to get pregnant.