[Release] Metallurgy Bot

[shaggyze]

looks like a logic error

	While ($load=0 AND $counter<50)
		$loaded = _ImageSearch("loaded2.BMP",1,$x1,$y1,60)
		if $loaded=1 Then
			$counter = $counter + 1
			SLeep(1000)
		Else
			if $multipan=1 Then
				CheckPan();if there was an error loading the skill, it's probably a dead pan, this will switch it out if so.
				[b]$load=0[/b]
				ContinueLoop
			Else
				Exit
				ExitLoop
			EndIf
		Endif
	WEnd

looks like its going to open inventory and checkpan() wither the skill loaded or not and thats also when it decides to change weapon slots to another sieve with TAB too which could be put before using the skill.

adam you might be able to fix it temporarily by just making $load=1
link you could move $load=0 into checkpan() "if $pan=1 then $load=0 else $load=1" but that would still mean it opens inventory every loop so guess the main problem is the logic with the skill being loaded or not.

[SSDarkLink]

Ah yes, my mistake, was hurrying through it w/o testing myself, getting more unbusy I'll test it myself as I code along, as well as pay more attention, this is also why I reffered beginners to my earlier version that isn't Alpha.

[mynameis_]

Hm. Good job on this. One thing I would like to comment on though is what SKAKERA mentioned on the first page. I'm not sure if I missed a solution on this but the character tends to get the metallurgy spots that are the farthest away (near edges of the screen). When I get to the farthest spot possible, it usually spins the camera and leads me somewhere far far away owo. Is there a way to set it so it starts looking for spots in the middle of the screen?

[shaggyze]

all macros that use imagesearch scan the screen from top,left,bottom,right so that makes it search for the farthest away and nothing can be done about that except to limit the region to the center of mabinogi the problem with that; is then it will miss sites if you have already mined the ones around you and will just spin the screen forever unless it uses location reset.

[mynameis_]

Ahhh I see. Though i did find an easy fix for this. Zooming out max with the camera looking down on your character (Helps a lot with zoom out mod) keeps a nice wide area for image search to look for. Also I just realized instead of using itemdb.xml, wouldn't it be more efficient to use itemdb.english.txt to change the gems to have an "Ore" suffix? As oppose to crashing the game with an outdated xml it would be better to have the txt file? o.o Just my opinion though .

[shaggyze]

yea, that's what i use for mine, but dunno if SSDarkLink will switch over its not a big deal as long as he updates his release the same time as a new mabi update.
although i change my Gems to have Gem suffix so i can choose to have it pick up all, just gems, just ores, or all but unknown ores or whatever with a few clicks.

[adam_j]

Diometer's code searches the middle of the screen for things, as I recall.

You could just do that, for one search, if nothing is found, broaden slightly, repeat until you have scanned the entire screen.

[shaggyze]

yea, his does, by using a 1/2 screen region of the center of mabi and then fullscreen search, link removed all dio's code for this but left in some of the global declarations so wouldn't be too much work to get it working and then this macro would work in a windowed mode smaller then pc resolution again.

[devilcon01]

i am get the Error: Subscript used with non-Array variable to but it is Line7 and i have a 32bit what can i do to get it to work

[SSDarkLink]

I planned to make it search the center of the screen and closest to you first, but that's the least of the error's at this current moment, I'll fix the error's first in this alpha then add that shortly.

Edit: Added the new version with Reset Location(Only the waterfall, if you want more wait for me to add them or simply add them yourself by taking a screen shot of the yellow and blue square on your map, of course after adding my map I modified) also fixed the bug with the checking pans(I believe so anyway, work 100% for me), sorry about that.

[sunbeam21]

Hey darklink. The bot is working except the part where Tiara does not show "silver" over the metallurgy spots, just some untranslated stuff. I replaced the itemdb.xml but mabi wont load since of a "client.exe" error. Is there way i could edit the orginal itemdb and make it translated?

[adam_j]

Originally Posted by sunbeam21

Hey darklink. The bot is working except the part where Tiara does not show "silver" over the metallurgy spots, just some untranslated stuff. I replaced the itemdb.xml but mabi wont load since of a "client.exe" error. Is there way i could edit the orginal itemdb and make it translated?

Yes.

[kotarou3]

Originally Posted by adam_j

No.

Fix'd. itemdb.xml doesn't control the props. propdb.xml does

[shaggyze]

better to do it with propdb.txt though since its updated less often and won't cause client crashes but propdb.xml is still needed to enable the names as well.

[adam_j]

He asked if it was possible to edit the itemdb.

It is.